Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 7 Dec 2023 00:37:00 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Eric Dumazet <edumazet@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        Arun Ramadoss <arun.ramadoss@microchip.com>,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v1 2/3] net: dsa: microchip: Remove redundant
 optimization in ksz8_w_phy_bmcr
Message-ID: <20231206223700.45ta3kc45aac7pyp@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231121152426.4188456-2-o.rempel@pengutronix.de>
 <20231121152426.4188456-2-o.rempel@pengutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r4LT+OR7svphHYj+1gg8+APWcOD0QR/3/icV1A30zIOvOhw6iGzsT5aI3lL9?=
 =?us-ascii?Q?cuS/OYAFS1mOWA2sEgvlJB26Rn1dW+h3V91qNEylTOid25NcC+PenD0S+2K1?=
 =?us-ascii?Q?PQ9cqLmVQmlzqioC9BLxSILnZJUShoMDge/86e9DcHYLQArrV/LjhAqlnatG?=
 =?us-ascii?Q?8nCI8nDE0ObPVVO8XxDl2IUd0QT6y9/XyuWK9fYVvU8pdG0HryTJrkkJKJxw?=
 =?us-ascii?Q?Q1djE7xWoIoqBPuF/Eh2jeLsjuLh7J0Zrui+S1OP8wtac8X4oczmhKXuw4vX?=
 =?us-ascii?Q?BTNYth5m8vCiETyrmwyvp0HsktehJNYUTc3kjVuhEA2i+/kqaJJzSuNCqp+1?=
 =?us-ascii?Q?cDSGZt1ol4v92vmwHBLB5DqGgG9booxwaM/zhnC1QAkZ84ecdan4+nMISRDa?=
 =?us-ascii?Q?bE31kC+1gtGUpaLr7E5+WcLUVRXOLHfVGelRexKWZUeF2MGB5gGj+tYxMorz?=
 =?us-ascii?Q?oykPiBDjtIwWI6ygyAnjaiefiMNHu0Ljii3lu6Hia3bJJ10wsMORdwDT+Y47?=
 =?us-ascii?Q?N0+9OLbEeEzYKUliSRk/zAJG5NjcXEfl/ZaGuWzjrqYcO4ARmRd5/MlayAK3?=
 =?us-ascii?Q?OCGWnhDjjUBgr0kF4n4iWUUaFqX+RBw0/1/VESSvZZMeenGKYbIXPFoDw8xk?=
 =?us-ascii?Q?fmt9YRV210narMI7tR427c3z19URvQIg+yzf9JAt1UyAylsTuUKkHk0SYs4c?=
 =?us-ascii?Q?ZvluRp4tqaTqJF6R+pzYE9Nu3Ij1y4ctIzl8/xEK6x1l94DasSBUw9FdV9e9?=
 =?us-ascii?Q?h1FgUBzsBC/E4IuV0AbSSCqZDaP/rPwSquvztyPq01vyTIChHhQycGczI4Eq?=
 =?us-ascii?Q?PlRviV9sgyObl57qodKYBurhDXfKHw8QUiV4aPsXdF8QlkhE41vxxa8677/D?=
 =?us-ascii?Q?U7RoKiGuJgBftlHvs1dEUPLkytRZZB3klZ+cepjZZw7cLBDvCYDudsa7avpo?=
 =?us-ascii?Q?yD+RlY/usOUUQeSRKrGunMO3FZEmeifLeekZV6B0yIiBM564TO+X7F7pNZZz?=
 =?us-ascii?Q?KX7toG9AEyDap7DG5PsGNBS7NAPTLcUtcr98pnfY86m26lfcznHL80a7CZoE?=
 =?us-ascii?Q?76UWdprkN7Y8PTJfhRRVdBQIIQyk6A0WqzQ1qT2Db7jnhUNhkZn/cCmfTZu4?=
 =?us-ascii?Q?2w/K2/LhmACVNMcMkgaEacRdBNQEYOfA1n2krRUCO/Ch3DTgNw/XF3UtloNT?=
 =?us-ascii?Q?jRe409JbcQitbA2evppmcHG1zNAJEmL5l7seGMlqmgn2o8QAQyHRNTnzPVXL?=
 =?us-ascii?Q?IcFzU+DEJhhs+Eh4/hjKEuIcaMCEPL3AokVQjA5IGjNFGBEGo4ZcxGcf1mk1?=
 =?us-ascii?Q?olFre+Mv9Dg3eIXQAGyHVFiqZduWe9aUmpbJkHfh1K2WaHUI4nmC6xhLYBe/?=
 =?us-ascii?Q?xX6mi67F1RHf923LtUo+S7lXt/NZgHyMIcQ6uVjXHZUJYctRtCSot7QzeDM/?=
 =?us-ascii?Q?S/Dz8I9ajxepfaH78WDnI6v6FraQNX+74vPqsmbESIHu+DzZk6/M7bkJC1qT?=
 =?us-ascii?Q?O9k9cwMHqHSLT+EwtjbkCR9wQ0qf6cB8l+wRhkZtHoHMUsAu7FNr5UyYnYKp?=
 =?us-ascii?Q?kbrtPm0OhHWM0n0t35uD6liagdbTr2+48bdtjVBBphGcGkKdkmO6GHoxQkvh?=
 =?us-ascii?Q?mA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cafc147d-4720-4e09-d693-08dbf6abdf50
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 22:37:05.2222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xEs/ByPJ1N4UX1yCAQZwYSR5zr9GE48q/ZlkWKI/+UBX17CWtW/BTz5TlYDgHd+vbQCGo/u6RpOi21Ow3Dgabg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7506
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 06 Dec 2023 14:37:19 -0800 (PST)

On Tue, Nov 21, 2023 at 04:24:25PM +0100, Oleksij Rempel wrote:
> Remove the manual checks for register value changes in the
> ksz8_w_phy_bmcr function. Instead, rely on regmap_update_bits() for
> optimizing register updates.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  drivers/net/dsa/microchip/ksz8795.c | 95 +++++++++--------------------
>  1 file changed, 28 insertions(+), 67 deletions(-)

The diffstat is nice. It's good that we can benefit from the "(tmp != orig)"
check from _regmap_update_bits().

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>