Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1296139rdb; Wed, 6 Dec 2023 14:37:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOTLbK3vNxC/YrueBQDuFFGMtQK7NQkMTAD2MatAhd/Q1x9tuzTTnBJI7p3xlQQgHQ3Z4Q X-Received: by 2002:a05:6a00:6c94:b0:6ce:6407:2264 with SMTP id jc20-20020a056a006c9400b006ce64072264mr1397192pfb.56.1701902273425; Wed, 06 Dec 2023 14:37:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701902273; cv=none; d=google.com; s=arc-20160816; b=AN455SIZ4W3L8nMtkWiAhq46YOlTvVTfNkrpijuN233OMEHOQEZmujkMndz3dEbl42 jhfFNsU331PVZPMe18nYTWzl/cCSK1I/CfOJyT/cR5/QAPNbBI4z3vg0v8ledxxmXdTZ wWASdUeKvH1NAl/DiICuFHZLeLlgZQGmhM+xhxmrswalwk2BjyOWHs15rW4Dyn9pYZlL XnhC5zIf5O77LzVzz7Db7/RR7qUPRd5SZoPPIvp2qamXmMGQMIqSt5s2KMnzJwdxSXbO QixDkp1p5SAizJnfdeT1JXpOIuojJgOJECuY1NXOn/lw5r/YRLwbeZf55xdERrKCvSxl aBBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SpHMtoBxIkmYrYXlggD/bi1zaqbK4AdCKk/C2BprrYU=; fh=wf+eCremt86cLwnHsVcOdmjnv1aKySXKXPZTcyWo2mQ=; b=ObVmeZiGamjhFLC2U7wOa3W4HbSiGDgBlQKI7fIIEV39Xyg0zuCb54kiPoO0Vnosq5 JIXEG8F48z+2o9qRpeZHFUVTF6/3DjOUM9muYTS5l/C3yhkWgwLsI0yAAdQwepox/FBy RA2ESy3ADT5jsefW+KH/L4UenB8F0KcPFAFaiG9udURts/SMm241VylWzT6tiyDdtKr7 U1nQsJ2gaOfDqocyQBIXvGxXT5ejXBGAs68ofAKcJQoZ7QWqm4NAyHSE9JBO5Gr/4lWm 31BXVqMBSTLCB1pHNCduN+ly13aRIovVv01uJIMK4l5r3F8kh7wbSP1jQzUi96i3qDfK WWwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qW35m9mQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id q21-20020a63f955000000b005641315d956si8565pgk.147.2023.12.06.14.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 14:37:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qW35m9mQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 97D3580B120F; Wed, 6 Dec 2023 14:37:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377199AbjLFWhV (ORCPT + 99 others); Wed, 6 Dec 2023 17:37:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231128AbjLFWhT (ORCPT ); Wed, 6 Dec 2023 17:37:19 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 756A410C6 for ; Wed, 6 Dec 2023 14:37:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04672C433C7; Wed, 6 Dec 2023 22:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701902244; bh=SpHMtoBxIkmYrYXlggD/bi1zaqbK4AdCKk/C2BprrYU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qW35m9mQvl/FxtFLb4vNeX3KAGURfIyLQFALthVHe3pChiNyjfjfmZezgHouAPoDA K2FLC+/OwqfM2goIgGuqWuXvu22A9VkKt1B3ZxsgDvo/SOww1F6vOF9UuBTYizK+Vu PKV8PqhoJ6SWA5jjs1xYc5nEyhwaZJvBndUVCYC4LrDs2g1oaMs5EPpBCE33e56Wgi j0wPZE4Se3xhKOPPFgLJW15egZLwnEJZWelNxeC9z4FTIM1ymwrOaUWtros2tsy2Wx 9DBtKtBX6KcycNiL+sSWGBoP224WPg38w8PR7o+eZLH+QKLt2i+gJWaDLw0QT70Zn5 +KFjh9f68sy2Q== Date: Wed, 6 Dec 2023 14:37:22 -0800 From: Saeed Mahameed To: Jiapeng Chong Cc: saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] net/mlx5: DR, Use swap() instead of open coding it Message-ID: References: <20231117071947.112856-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20231117071947.112856-1-jiapeng.chong@linux.alibaba.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 06 Dec 2023 14:37:50 -0800 (PST) On 17 Nov 15:19, Jiapeng Chong wrote: >Swap is a function interface that provides exchange function. To avoid >code duplication, we can use swap function. > >./drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1254:50-51: WARNING opportunity for swap(). > >Reported-by: Abaci Robot >Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7580 >Signed-off-by: Jiapeng Chong >--- applied to net-next-mlx5 -Saeed.