Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1308985rdb; Wed, 6 Dec 2023 15:08:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1AfLCNnEYIJZFGI3w/eHR6+hV2f3i1wib8rT1Y5H2oixBRbOWAqrRCvAnWeRVERbUPKLE X-Received: by 2002:a05:6a21:78a6:b0:190:6d:1c5a with SMTP id bf38-20020a056a2178a600b00190006d1c5amr167419pzc.56.1701904128035; Wed, 06 Dec 2023 15:08:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701904128; cv=none; d=google.com; s=arc-20160816; b=phIE/6bJ2+HFQZ+Ms6WNcOnKaVhT5QhkjyCJh4e1Rr0p6X9i8zncHd818uEiFDLGLo 22Xaru8BTfGAyx/7ckXjEBuosaidfw3Oum/3mKTyAVC0nDWGDKEwUEA8msh8Of0hOLeJ Jz9iScd38TRsKEVwKlvTWJDdMTSfyWo8b34LuHH2ntGnjy1GpyLKzKi22jbN9oQHZSwR Luwe6/gKzWHXsm9EzyysF/gR8cnIZwglk3M7FCAPEOnEGq7ifICaV82Csq/Z0VVAWQ80 pehZbuZlI1tPgFOf7qKO1jSQ/u6y1MmishOWcEGJ2iWjvGJ1mQ9Y/NHASD4qbU5J1s9+ fU4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=n3VJWMSAr8PiiKRo3IRIr36dxC1pAm2F08dzBDdvITE=; fh=2lrUEWDt3TxxQzw7aIkvaX6ygMnEJl8n9hjTF/61Bxs=; b=LZ6Une15YGPFCHHvuCmv/IgerQqan9IK13afkkE1NakhnDZ7Lu14N2g4D2WvUPn7lb DuWfCC2Qb6fxmNyBSQMNokk8RIf2YNoJeLAoPtah2PuBTbDOKJ70x74YKJdC2RUo/oIf M5VSqYQfquvpnlNyAy2X+s91Q5llV1sbKtDe87DmYmvXiIRpnSVgTebWChKJ1Q3dQPX4 AfO4/EK7RYkvXhbvPoD4lMBY4bEukfvIz6spX1WWE3OteWHB9h2cKkB3NjhJqV/yALfv Zxo9I1XkRyDHc5I108NpYHZ4HfZLR0GR1QmHe5ZHsQw14rXAMl1yfD8YWsTC5RVCPwTv 4xZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YeM3t9qF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id w17-20020a056a0014d100b006ce5b642330si83711pfu.212.2023.12.06.15.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 15:08:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YeM3t9qF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7037E802400B; Wed, 6 Dec 2023 15:08:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379592AbjLFXIg (ORCPT + 99 others); Wed, 6 Dec 2023 18:08:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379561AbjLFXIf (ORCPT ); Wed, 6 Dec 2023 18:08:35 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A76DD4B for ; Wed, 6 Dec 2023 15:08:42 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6A01C433C7; Wed, 6 Dec 2023 23:08:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701904121; bh=AO1ty7D6PaKp6YDUkB6GcaoW3ZWSgt+tWyq663+Pm1Y=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=YeM3t9qF4gO99MzKrXKOOaZSPdSn/RA80k5Anw846HM1ng+H7TvW6Ve27idk2Wcl7 QkAxlobS+pcETYJbQSJF3epD1OzwL7IhBfgbyRsfsG+7pqfPgwRB3Lzt6mXP145rd1 4omKqqli/+EuDT1yh/2YZT9p+LEVINP7aqySAzp2uwqubJCBolDIVQnXih1pn8z2Nm Py+n5MRhtqs2zPi5NVB3qWIbpGPjlPZvC6MpSmtFCvLWPnTD5hDZpvy39W8NHI7rrn J45fhSVhQtZWWq5HloDYZkuHBw4pWR9N1NHlrhuwT2Py9Zln+XS7nR/zP0Mnqcs9W/ u3Cc7xlccykqg== Date: Wed, 6 Dec 2023 17:08:40 -0600 From: Bjorn Helgaas To: LeoLiu-oc Cc: rafael@kernel.org, lenb@kernel.org, james.morse@arm.com, tony.luck@intel.com, bp@alien8.de, bhelgaas@google.com, robert.moore@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, acpica-devel@lists.linux.dev, CobeChen@zhaoxin.com, TonyWWang@zhaoxin.com, ErosZhang@zhaoxin.com, LeoLiu@zhaoxin.com Subject: Re: [PATCH 3/3] PCI/ACPI: Add pci_acpi_program_hest_aer_params() Message-ID: <20231206230840.GA733691@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231115091612.580685-4-LeoLiu-oc@zhaoxin.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 06 Dec 2023 15:08:46 -0800 (PST) On Wed, Nov 15, 2023 at 05:16:12PM +0800, LeoLiu-oc wrote: > From: leoliu-oc > > Call the func pci_acpi_program_hest_aer_params() for every PCIe device. > Extracting register value from HEST PCIe AER structures and programming > them into AER Capabilities are implemented in this function. > The implementation of the function is an effective supplement to _HPP/_HPX > method when the Firmware does not support the _HPP/_HPX method and can be > specially configured for the AER register of the specific device. Rewrap into a single paragraph or add blank lines between. If this is needed to make some machine work correctly, please include that information here. Based on Rafael's comment about getting the actbl1.h change merged via ACPICA first, I assume this entire series is will wait for that ACPICA update. Bjorn