Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752295AbXLDGvP (ORCPT ); Tue, 4 Dec 2007 01:51:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751499AbXLDGvA (ORCPT ); Tue, 4 Dec 2007 01:51:00 -0500 Received: from astoria.ccjclearline.com ([64.235.106.9]:49391 "EHLO astoria.ccjclearline.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbXLDGu7 (ORCPT ); Tue, 4 Dec 2007 01:50:59 -0500 Date: Tue, 4 Dec 2007 01:50:53 -0500 (EST) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Dave Young cc: gregkh@suse.de, linux-kernel@vger.kernel.org Subject: Re: The use of KOBJ_NAME_LEN In-Reply-To: <20071204064547.GA17094@darkstar.lan> Message-ID: References: <20071204064547.GA17094@darkstar.lan> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - astoria.ccjclearline.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 34 On Tue, 4 Dec 2007, Dave Young wrote: > Hi, > Does the KOBJ_NAME_LEN really means the limit of kobject name length? seems not . And if it's true, is the KOBJ_NAME_LEN of 20 enough to use? > > In the kobject_set_name, the limit is 1024. Looks like either the comment or the code should be updated. > > /** > * kobject_set_name - Set the name of an object > * @kobj: object. > * @fmt: format string used to build the name > * > * If strlen(name) >= KOBJ_NAME_LEN, then use a dynamically allocated > * string that @kobj->k_name points to. Otherwise, use the static > * @kobj->name array. > */ the comment seems fairly clear -- if the name is sufficiently short, it's stored in the static array. if not, then it's stored in dynamically allocated space. rday ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/