Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <76fd4d99-e7b5-4fdc-8864-af4a198e9981@intel.com>
Date:   Thu, 7 Dec 2023 08:56:23 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 02/39] mm/rmap: introduce and use
 hugetlb_remove_rmap()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Hugh Dickins <hughd@google.com>,
        Ryan Roberts <ryan.roberts@arm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        Peter Xu <peterx@redhat.com>
References: <20231204142146.91437-1-david@redhat.com>
 <20231204142146.91437-3-david@redhat.com>
 <ac9a63ab-e83b-41d5-8a59-c4a137cdebd4@intel.com>
 <e2061158-678c-4a3c-b94b-88005cff15b1@redhat.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <e2061158-678c-4a3c-b94b-88005cff15b1@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3lDOWx5dkFmbEhSR1NuWGk1dWtVSlF6SS9KN1dKd0ViejREQ0VpSlE5NlVy?=
 =?utf-8?B?dUgrdmdYOFpNRlByWGhaTlRZaFZZYzFuaUVxVzV1aThDTzQwQXUvU2ZVMWpo?=
 =?utf-8?B?bGlmR2FYdUIyUW5zQUVvdHFYM2p6WWIxTDRCaEFCcm9aTG1pVlgrVWt6Y0pr?=
 =?utf-8?B?MWpFWnY0R0ZrUlJGSFVybGY4SXRUK2lOZkhDVVB0V3ZmOXNYRm42UTNRd2da?=
 =?utf-8?B?eFJwMGNSMjFUdGV1VGdiVFEzYldVSnFIWVJNd0xJOXVUTUNTQ1NZbm9CNG1u?=
 =?utf-8?B?a1U4RjQyUjg1ckQ5bTQ5TlR5dzJwaHllSFZFNWJkeXR6djZUNUFPQzdmK1Fl?=
 =?utf-8?B?M25ZR2Y0eWlUMlZJQUVXV2pWbk96eFhWbU1CWDRnaHdxOE5DWmd4RFBnaThk?=
 =?utf-8?B?NnZKMVR3aGdPTXMySzVqQmtyMTJSZjMzRjQzV0ZaSXZpZkxuUWRsZ1VaaUdi?=
 =?utf-8?B?andXcDR1ZHFOdHRBaDhaV2xXUUVTbkNodjlpWkZaRHV6dkFGd2l0ZHFlTTRi?=
 =?utf-8?B?VjEvdHFSemNEelgxV29oMFBUb2xyWHVnSG1wSVdXU3hjWk9QRlNJMEZQOE5s?=
 =?utf-8?B?WmRIeGF4elVLR2hMdnJldTlPM2xZK1RqcjFEcXI1UkFKaFhTd096Qkt6dUY0?=
 =?utf-8?B?VkVxN0djTHZVTDIvc1BJODFsVFJLYW5ZcXFLbklnNjhpcHA1dllIMFRYY1JU?=
 =?utf-8?B?ZHVkNmVsbmNmVi9nd09VNmdKY2RyRG9vZVlVNjhtZFVHZUgyM2k1UUdBbGc2?=
 =?utf-8?B?bkFTbEwwMnZLcmJobU1tTVZZakQ4czhQVUZpNlpObFNJUnU2UXRSMGZyQnB3?=
 =?utf-8?B?VlBSMVdjVWRVUFF1S0VHa3BwU25nQS9ENlR2NCtpbnpCNDc4ZzFwNnN3QUFq?=
 =?utf-8?B?R3FlZGZheVNEL3poV1M3Y2FWWGQvSFZTa3dldFh6MXhlTGFmQThUcjlxUEhR?=
 =?utf-8?B?VmlVY2FOL29QWXkwaTl6RkoydzMxdlFxT0YzTGNUQnoyT1BvVUVYNXRBeUZs?=
 =?utf-8?B?L210MktFRXdIOTlCOVBwbFVzUFZxN2YwaTlXaERNNnJrR0ZMNU8vK3VsYm9J?=
 =?utf-8?B?Sm0ySGV1WjNZc01FQ3lyU0dGM3laTDNNci9UUklsdE5VbXZjUXZwcjVIMEZG?=
 =?utf-8?B?RmtMdmVDWTdQenhyaDNpazFSU1VaZ3l3SWlwY2c4THBtVHdtMlRTRnRBdm5i?=
 =?utf-8?B?djFoTG9MOE85MEN5d0JFNTBMSFFZVWo3K3A4bVZhRFZmNzI0UnJSdFhIOWZC?=
 =?utf-8?B?NkF2cmNueVJFKzhCNStEdGMrZjdtMnhzVTI5dTdZbUI0VGhNbHBvMm1YRzJv?=
 =?utf-8?B?NVlLRzhsVEpoaVVaMlNTQVRpUjBXMUo0SllHYVRGRTNGNnh2bzlxOGU3c1NS?=
 =?utf-8?B?Yk81NnZmU3dRVFF5clVYNTZpWHBCNVdZdVJMNGZXb3NTN0F1SC90bjhWRExW?=
 =?utf-8?B?UklxdzFYOFdkU3NTQlRHZzlKd3k5TnNLSy92ejhIWUhkQ2t5dndkUmdSWi9F?=
 =?utf-8?B?ejJkK1ZzRnBQSy9yU0g0UG9EZTN2MUp2Zk5GYVhJYmFXV00vRGVPTTJ1d3NV?=
 =?utf-8?B?dFNvT1gzOUVpWUFMVnBFVzJvL3ZUL20rOEMwMmRVNjRPTlUxa3gyTk5vVS81?=
 =?utf-8?B?bzUzZHVpUUJVcFpNKzFTanlPUVlaRE0xS3lVMXQrK3h5NWp3bVFGdEl3bXJN?=
 =?utf-8?B?SXByRFpWR09HakduNmhmSmE3cG9uZ0pJc1FQTVZxUVB3bDZNa0ZyV25yeUds?=
 =?utf-8?B?bHQ3NlNhYVZKN0Y0SVp2bExZbzU2OTVSbmRVSGFTV0pkcXRhR3FXT2dLK1E4?=
 =?utf-8?B?UTZ2aGljRU11Y0toSnVrVFM0TG9XQTRGTTBTNEJHSHFJTGRFWUxhZmNTM1g1?=
 =?utf-8?B?WGRuWUorRjdkRURIZWxzVm41TURUU1BUdUZFWGpXR0VxK0QxeXhuVnVFSCtY?=
 =?utf-8?B?aFhyT0JGTVV1Q0JDdE1iRTBvRXplYUQ3RWcvWjFTMlJXVE83THc3MTJJakZa?=
 =?utf-8?B?Q0toRmJvaWMrcVh5dkFVekc0K2FWQzA2eUF3NXBoMUJCdm1qQ1hJY3ZMYWd2?=
 =?utf-8?B?YWVzL2ZzbEZSZm1ISmo4a0JHSHdUa3BRSEt4T2ZzZDhnQjh3QUU0OXZncHMx?=
 =?utf-8?Q?1gzY6iPmvj2032l1TmbTzka/O?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0008f894-6bdc-4bf9-59ff-08dbf6bfa516
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 00:58:37.5907
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ykqdz+iXhgqGw+1GJ1KqXbOK7DcJvJbvx4i81JTnED7QXP1cCOWY//2Bmn2hlsq2Og+6kWq0pw5MDIkwgd5izQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6716
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 06 Dec 2023 16:59:35 -0800 (PST)


On 12/6/23 20:11, David Hildenbrand wrote:
> On 06.12.23 02:22, Yin Fengwei wrote:
>>
>>
>> On 12/4/23 22:21, David Hildenbrand wrote:
>>> hugetlb rmap handling differs quite a lot from "ordinary" rmap code.
>>> For example, hugetlb currently only supports entire mappings, and treats
>>> any mapping as mapped using a single "logical PTE". Let's move it out
>>> of the way so we can overhaul our "ordinary" rmap.
>>> implementation/interface.
>>>
>>> Let's introduce and use hugetlb_remove_rmap() and remove the hugetlb
>>> code from page_remove_rmap(). This effectively removes one check on the
>>> small-folio path as well.
>>>
>>> Note: all possible candidates that need care are page_remove_rmap() that
>>>        pass compound=true.
>>>
>>> Signed-off-by: David Hildenbrand <david@redhat.com>
>>
>>
> 
> I suspect you wanted to place your RB tag here? :)
Oops. Yes. I meant my RB tag here.


Regards
Yin, Fengwei