Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <87il5aomh1.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Rob Herring <robh@kernel.org>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-sound@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ASoC: audio-graph-card2: fix off by one in graph_parse_node_multi_nm()
In-Reply-To: <1032216f-902f-48f9-aa49-9d5ece8e87f2@moroto.mountain>
References: <1032216f-902f-48f9-aa49-9d5ece8e87f2@moroto.mountain>
User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Thu, 7 Dec 2023 01:00:50 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5kDy+4ESosqAVYj3PnukDZfqFZ2L/uNDHrnlZNjF8GA1XenuNrkl0XFx5tTa?=
 =?us-ascii?Q?/EFFeRmXRaj1LiuJUWvqtjqcyMzCF5HTFSUo7o0M9FPVnnmSCA07W/++GdS3?=
 =?us-ascii?Q?PncNR1rFE7dcbvNjeyCB6zxqBpP9ebqOgysgl1HVmvNBK/R8EAlR/2TV8DBX?=
 =?us-ascii?Q?DscACNCSwqiUoN2qAxXS01l53JYtNYMmjLM1MPU+NXuFmjU/Umt9e+4aGZX4?=
 =?us-ascii?Q?lPqWR30CJsjpN88Ow70wvlh1XD+i9epR3UoGYvSa0HVhmYtrWb+r5xXrTpi9?=
 =?us-ascii?Q?89v/H9vvLQKymxWDVp8Er9hdFKdY/BPh8OeB9OSzgFtJnjJp+BIr/LcOCipm?=
 =?us-ascii?Q?zspo/YebQN/S/GjCKzRA3bXN6v7uZcTcSPGllp/rXXqPTlcgnZmEysGtyuWY?=
 =?us-ascii?Q?EG98Yla2c3SjPLQfJwJwBF5bB48AyYeznQ4qTXbkQGN84gvvnevTtDyCwJY2?=
 =?us-ascii?Q?Lca/zH5PlssI/DI0lkoJQyUzs65yLzCrMuUwUAttukzaDuUac8T8znKvotBZ?=
 =?us-ascii?Q?1YsoOl9bH76toIeJxo8IdopjboS3y6P2EZk4vSZ5uZ2BGDGzqsOFS4a/pCe6?=
 =?us-ascii?Q?g6BsfQQ5TAUSC+6hxxFgiY+MZi1vFyrmdqxRFGncIHKsWnPdc0YqfAE3V0wf?=
 =?us-ascii?Q?3Xx0NAjZvTQupa/dwE+/oFcXr19EWVjnvqCLDAAdn8LioHEYL2u8vn4LNLxT?=
 =?us-ascii?Q?4GJAJZ7ugmd0xLfkGRYC22+VcT9LJq2aVrzYWjB/tnXcDkw/Vq5IUZVkOa66?=
 =?us-ascii?Q?LWSg4CIf2JZ5Inw/cJHOHTr26muojDBmfgty8T2YuZnbjENreQKAey+/p+om?=
 =?us-ascii?Q?Pt8oxwxixUNwrWZ0ejgJYmEXnZ4hbefslePp1/L78SWOQTDgjzMkRWsLVUSQ?=
 =?us-ascii?Q?5PE4qESdhPcfKX1nkj/xKDCcz3mg3VzJVQWmi/GWQkax6EAZmEDCMVxvz97J?=
 =?us-ascii?Q?+wPqE0TJbX61geXlAriOZaWCbfh6iH6ChekI3GGUrpkxiuWtBpde5mz7kiny?=
 =?us-ascii?Q?BdlPQ8qc/M0dniyTK0Vxxx7B/OKjquWW0vvyVpOoyQvBc6PUSCIT4ybs7NYi?=
 =?us-ascii?Q?5PKrkwBZ2q3rN3Eux+9EQ3gTmAcFxAKnyxC8rNMQJsnc81RBYFvv1iH6CY+I?=
 =?us-ascii?Q?gB8mnwuGZ6fTtkH8XwC5bRt2gua4e2gufcvlq9xSWoe/k1KzUxqUd0I1dNcv?=
 =?us-ascii?Q?4oNOjzOeACbIXUKVUc4ksNipOrWFt+R5uOZ+GjZ019Jm1ygEueu6WYogADUY?=
 =?us-ascii?Q?tkU5ogcvJG5mrtnFOequVEJ2tiIJ2TaV94ksUlmfHltKGqhLU/rk8t2Z6tA0?=
 =?us-ascii?Q?0Ix/0FXZyNoLxowxPNeySEcfs5RTtjyGxdrGO8HhabMaRaOJZOqJBNuv35W9?=
 =?us-ascii?Q?uJQKj3eeJv8v3XWcZJcJ2YTw7QA8V8LzfwK+2chfXPinxYk155x1ilwbZvf3?=
 =?us-ascii?Q?kWkxg6vTzRYIG5NKKP9byDqMZaR+1tX36ZP2DUGfVmP1vNRiYByIZpIYXTR6?=
 =?us-ascii?Q?GIyFKbvfqz5aAbld2o9Tga1zdO4JkLMpLMZb+GK2LL2D6fbdXQAvxqXLfsok?=
 =?us-ascii?Q?6z24/nS9AxDSWiiN7TrWgjf9gmtAu2rrxqZdyfSXgWe5ZENuPqF8aL7hV8b5?=
 =?us-ascii?Q?QtxfguO+CawO7kIrwiwY1L0=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4166a4ef-9f63-4ebc-f3b0-08dbf6bff4b1
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 01:00:51.0300
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s9vhkYh1NaUoRZoFScantmgWPfxv4azV0q13mNvpGeEDeutlFjC3lnfnwI11fQ4AeE4GM8iT3iXKxUtzpzf2ro/cng253w6450ix3k6FuFmZCbUIlD4FosG0o6+5apny
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8618
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 06 Dec 2023 17:01:04 -0800 (PST)


Hi Dan

> The > comparison should be >= to avoid writing one element beyond the end
> of the dai_link->ch_maps[] array.  The dai_link->ch_maps[] array is
> allocated in graph_parse_node_multi() and it has "nm_max" elements.
> 
> Fixes: e2de6808df4a ("ASoC: audio-graph-card2: add CPU:Codec = N:M support")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> In this same function I was also concerned about these conditions:
> 
> if (cpu_idx > dai_link->num_cpus)
> if (codec_idx > dai_link->num_codecs)
> 
> But I wasn't able to see out how those idx variables are actually
> used.

These also ">=" I think.

Thank you for pointing it

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto