Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <bf2b1671-2911-4d74-abfb-e6dbfe03d626@acm.org>
Date:   Wed, 6 Dec 2023 15:06:14 -1000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V4] scsi: ufs: core: store min and max clk freq from OPP
 table
Content-Language: en-US
To:     Nitin Rawat <quic_nitirawa@quicinc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_cang@quicinc.com, Manish Pandey <quic_mapa@quicinc.com>
References: <20231206133812.21488-1-quic_nitirawa@quicinc.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20231206133812.21488-1-quic_nitirawa@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/6/23 03:38, Nitin Rawat wrote:
> +	list_for_each_entry(clki, head, list) {
> +		if (!clki->name)
> +			continue;
> +
> +		clki->clk = devm_clk_get(hba->dev, clki->name);
> +		if (!IS_ERR(clki->clk)) {

Please change the above line into the following:

	if (IS_ERR(...))
		continue;

to reduce the indentation level of the code below this statement.

Thanks,

Bart.