Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Feedback-ID: ifd894703:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069
MIME-Version: 1.0
Message-Id: <40b5e438-22f4-43e5-9663-db44dd402a35@app.fastmail.com>
In-Reply-To: <c10194f2-097f-4455-9932-19961edbf990@infradead.org>
References: <202312041909.lwhcU35R-lkp@intel.com>
 <5f1caaf8-1edf-444a-b017-c4d08e52213b@infradead.org>
 <f712a65b-4984-46e8-bd43-1309b5cd41f0@app.fastmail.com>
 <c10194f2-097f-4455-9932-19961edbf990@infradead.org>
Date:   Thu, 07 Dec 2023 01:21:48 +0000
From:   "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To:     "Randy Dunlap" <rdunlap@infradead.org>,
        "Arnd Bergmann" <arnd@arndb.de>,
        "kernel test robot" <lkp@intel.com>,
        "Masahiro Yamada" <masahiroy@kernel.org>
Cc:     oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        "Nicolas Schier" <nicolas@fjasle.eu>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: pm.c:undefined reference to `i8042_command'
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E5=9C=A82023=E5=B9=B412=E6=9C=886=E6=97=A5=E5=8D=81=E4=BA=8C=E6=9C=88 =E4=
=B8=8B=E5=8D=885:26=EF=BC=8CRandy Dunlap=E5=86=99=E9=81=93=EF=BC=9A
> On 12/5/23 22:52, Arnd Bergmann wrote:
>> On Wed, Dec 6, 2023, at 06:24, Randy Dunlap wrote:
>>>> All errors (new ones prefixed by >>):
>>>>
>>>>    mips64el-linux-ld: arch/mips/loongson2ef/lemote-2f/pm.o: in func=
tion `setup_wakeup_events':
>>>>>> pm.c:(.text+0x118): undefined reference to `i8042_command'
>>>>>> mips64el-linux-ld: pm.c:(.text+0x154): undefined reference to `i8=
042_command'
>>>
>>>
>>> How do we feel about this?
>>> I suppose that an ARCH or mach or board should know what it requires.
>>>
>>>
>>> ---
>>>  arch/mips/loongson2ef/Kconfig |    3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff -- a/arch/mips/loongson2ef/Kconfig b/arch/mips/loongson2ef/Kcon=
fig
>>> --- a/arch/mips/loongson2ef/Kconfig
>>> +++ b/arch/mips/loongson2ef/Kconfig
>>> @@ -40,6 +40,9 @@ config LEMOTE_MACH2F
>>>  	select ARCH_HAS_PHYS_TO_DMA
>>>  	select ARCH_MIGHT_HAVE_PC_PARPORT
>>>  	select ARCH_MIGHT_HAVE_PC_SERIO
>>> +	select INPUT
>>> +	select SERIO
>>> +	select SERIO_I8042
>>>  	select BOARD_SCACHE
>>>  	select BOOT_ELF32
>>=20
>> I think it's bad style to force-select an optional subsystem.
>> How about making the entire file optional? It seems that there
>> are already __weak functions in its place.
>
> Yes, I agree in general.
>
> Hopefully the maintainer will opine your suggestion.
> Jiaxun?

LGTM, PM is not an essential function here.
Arnd, do you mind making it a patch?

Thanks
- Jiaxun

>
> Thanks.
>
>>=20
>> --- a/arch/mips/loongson2ef/lemote-2f/Makefile
>> +++ b/arch/mips/loongson2ef/lemote-2f/Makefile
>> @@ -8,5 +8,6 @@ obj-y +=3D clock.o machtype.o irq.o reset.o dma.o ec_=
kb3310b.o
>>  #
>>  # Suspend Support
>>  #
>> -
>> +ifdef CONFIG_SERIO_I8042
>>  obj-$(CONFIG_SUSPEND) +=3D pm.o
>> +endif
>>=20
>>      Arnd
>
> --=20
> ~Randy

--=20
- Jiaxun