Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <5fed153a-6668-c980-c573-3a31077c52ac@intel.com>
Date:   Thu, 7 Dec 2023 10:29:18 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] cxl/core/mbox: get next_persistent_bytes by
 next_persistent_cap
Content-Language: en-US
To:     Ira Weiny <ira.weiny@intel.com>, <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <pei.p.jia@intel.com>
References: <20231201164005.135912-1-huaisheng.ye@intel.com>
 <656f9a94d9b48_18297729452@iweiny-mobl.notmuch>
From:   Huaisheng Ye <huaisheng.ye@intel.com>
In-Reply-To: <656f9a94d9b48_18297729452@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzhGNTBqNGhBZWFzY0U0WHBqQXNLVDIvcUMxTW1jKzlVUHRtVVc3bU11ek5H?=
 =?utf-8?B?KzhuZm9BVWpRdEUvSFBWZGJjVnkzWXZ5VERBNU1KbTVadjdKZG5lQ3ZhRmJS?=
 =?utf-8?B?QWhITDN3eWJ6U3dSUHloaHRITmtGRW1vc092RDF5SWtpeTRvZ25aVG54TnRG?=
 =?utf-8?B?ZTZvZS9GOXJweDVob1VXNWN0amZIcmNuM2tjbldad251WHdDS3ZZWVZ3QUZP?=
 =?utf-8?B?aGZ0bnJMeWR1YktJSzN4ckpDUFFsQm42aThmcm9jN1dPK1JDQzVsaTAyaURv?=
 =?utf-8?B?MFFlUkNUcHh3Y09GbDVtWkdOaUZTUExsYTZSWnoyMDdtU21XK2lncG9jdXRC?=
 =?utf-8?B?dytVMHdHWVgwSjdwQm1qT2NtNUVGTVFHUDl2OEZha2hTS1p1Nm8wOWQxYVlU?=
 =?utf-8?B?Ymo2cVZha2hRNEhHY0x3YWF2SFM5ZFM3SHVVWXBlSWJPVXNBNnNvWUxqMXUw?=
 =?utf-8?B?bzU5c25EVm9MUE52b1hjMTZ4b1Bid3N3M0xpY1ZuM21pQ1BOelBiOXNNV0p4?=
 =?utf-8?B?YVZ4a1ErQlRud2NKVUF3Yk9XaGUyZGtOWS91MGV0TkNRWHlycWdRd3Z3Y3A4?=
 =?utf-8?B?MmRPK3ovNWJMcWpKWW5Ic2N0K1JlTmxmaFVINlovR2lEbnc5VHo2cGZobU94?=
 =?utf-8?B?VVBwTmR5SjRLc3V0bjhXaHZzL0RTNnlJWTRRWm1oQzVGeER4L014ak1XUUo4?=
 =?utf-8?B?TEJpUWRKOTlvMWl2Y3FlUUVWNDVVcTlVaVM1djZES2poMGRXVTdCQk94VUw1?=
 =?utf-8?B?bHdKWlBxNGJGTFJodm5Xcjh4b3I5d0REOEF5c29iL3J5emdhL3Z5ODRqL3Zw?=
 =?utf-8?B?VThNMFNsWCs0L2taUXhHUnZHMHl6NExDOHBiL3lLb1JUWXN5VDQ2SUhCVEdN?=
 =?utf-8?B?bkNXTHVWUk5EVlZIdjgzMlFlczRMcHlRR1ZxQklnanZ4Y2tCRmsrM1p2Znlr?=
 =?utf-8?B?Qm9KV2JjKzBTUmhSK1RuKy82YUtUUlBrbnpidncrdE9HWVV1R3hGK3FhVXd5?=
 =?utf-8?B?RW1PRmh4dmx4OUcxSzZkdm83ZlhvNXV2Q0lJZXIxZnZmbFE2UStSMkVSWHB4?=
 =?utf-8?B?RG4zTWxjVU93SzgwS3RKY0hDSkJRaENRWVRaRTZYRW4rL29yYTl0Q1dxK3E1?=
 =?utf-8?B?UFpWdFp3ZTZ2WGUweEY2RUY4cWp4QVdUR2k2TFNUd0EwSUp3UG82V1NtZnJL?=
 =?utf-8?B?VjRrdW51ejUrVEY4YUF6WGl2TXFmaE05ZTA3RFFNRnVIUFB5amxyb2JmdldP?=
 =?utf-8?B?RzZvQXhSU0pscnhmdmpnQlRqRGNSeDRTbDV0TFRUN0FydFc4UUJYNDZVaGhu?=
 =?utf-8?B?blJvS3hYT2VCWUNucUUxUkt3Y0wyeEZPN1BpNjRRWEpiZGZlbXlRRjM3Z2wy?=
 =?utf-8?B?N2ZnOTdvN1lIYkhERDlTdzR5WXBmUjVnSVo0TVZ2T0xBNUJxbzh3VXloR2lE?=
 =?utf-8?B?eVI5WXlzSmtObDUvZStobk85Mk5LSmRMSHBHMVJPc2Z4L2x5VmxPSkFhMnV3?=
 =?utf-8?B?T0ZsSW5tTW96eThwNG9wcE92cG1yYXRSaGVqMnlRR2pwSVY3b3E1aEx3K1NE?=
 =?utf-8?B?SzZ2NUlxVkdHV3Y2cGVMaFFEZ0ZWakZTWjlLR25Gc05WU2ZqRHNJS2p5R0ZJ?=
 =?utf-8?B?N2M2aFlyc3lCRFdBNGZpdm9LTHVJUllKR2tPRDJhR0VNZHhtSEc2b0xpS1cy?=
 =?utf-8?B?akpqOGNZMzlKcERmbXRLV0xyWE5BRFgvb0hpUzNxNTVqbDlWdGNNWXkyenUr?=
 =?utf-8?B?TjBkSWhSdkduN0RUeWxoSENIc2pLMGNzOWd4dEhKSW1jMVZSMEljUWp3enpG?=
 =?utf-8?B?TW43azBOck5jVCtnUTdNY2Rja2NoS2c1MkxoV3BnMGhkYmdvcWw5N0RnSExh?=
 =?utf-8?B?ZEVQSk1QY1RpTU52Z2RmdHlIZkJwTkd2VkxSb0pHdFdvVWNndyt0ZnhUQnFm?=
 =?utf-8?B?b2RoZjZlNGMyb1ZqSkRPU09GQk5TTktnOUZEL1BrZjl5RkVFN1JwY0I2TTFG?=
 =?utf-8?B?Sk5qTVIyWDRaakJWNWxIL2FMZVFHNzR3a2NKR3g0Q3NYQWp3NUpPckVFblZr?=
 =?utf-8?B?MW5zMm9tRzV2ajZKcGNVK0VENTNuVmx1dDRhbXRiYVdZL2FuT0VCaVZxU0FD?=
 =?utf-8?B?WmtmT2tNMEEzTmF1YTVVK0lncXFTTng5VjhqckpOZ3FoSjg0U05ld1RicnNB?=
 =?utf-8?B?dEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 87f864da-9b93-47b4-79c7-08dbf6cc54cb
X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB7461.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 02:29:26.2593
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /kIqwctwXoo3fSFYgnssi32lPlX5QypYjskMIaTc9Xhsj11vC/Oss5+DOHxSn7axTSv1YFm09P/bqoaikR1zFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5128
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 06 Dec 2023 18:29:49 -0800 (PST)


On 2023-12-06 05:48, Ira Weiny wrote:
> Huaisheng Ye wrote:
>> According to CXL 2.0 8.2.9.5.2.1 table 176, the next Persistent
>> Bytes should be calculated by next Persistent Capacity.
>>
>> Signed-off-by: Huaisheng Ye <huaisheng.ye@intel.com>
> Do we have a fixes tag for this?  Was there a bug associated with this
> find?
>
> Ira

Hi Ira,

This bug could be found in cxl-next branch.
It looks like just cxl-pci would calculate next_persistent_bytes during
probe. Afterwards, it will no longer be accessed by current cxl drivers.

For v78 ndctl, cxl_cmd_partition_get_next_persistent_size is calculated from
next_persistent, which is correct.

May I have your Reviewed-by?

Huaisheng