Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1387514rdb; Wed, 6 Dec 2023 18:33:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFf/KcG+2r38kphjR3Q1NfZ9MehdHpd7hVhb/JJboKPQflO9MPaIgUgz+ig0fEZ6ysYxpJT X-Received: by 2002:a17:903:110c:b0:1cf:5d08:18f with SMTP id n12-20020a170903110c00b001cf5d08018fmr1733638plh.31.1701916390515; Wed, 06 Dec 2023 18:33:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701916390; cv=none; d=google.com; s=arc-20160816; b=qSkJJHkJrfsXo/qOioJMlpXNe7X4ZCPKvteTxt/LsBUYpwqVUrpzr7T8zgjGIkSkWy fHiNwANgar6DRaH1RwBkLSBOG7/OHdGzzEy8iOnxWJUgCljH8qliCb/TwOWK9BMqpsq7 T0JaXXJIszrHPrKWD57voTm9Sdm/c3aTFK90Ep4z5tIql+YBfQnJRWBdKaHSNkTMUIS5 ljMjR1f6iptItIwmgBzBV333U8hoSS6TFrBPhiDfqQOirg5uavGJfwB2hxGxKIWzLuFR oF8xU5lvPpoL/0hGkkx6LQN5c39MODV8NFgZBWdutCuBCEte0VtxVrfhaxnT0eW4jDL/ xvJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :dkim-signature:message-id; bh=XaTAr3n1Zo+WQ9fxFhHx7mUs6gY/pefswV7mSrJu1Fs=; fh=Kn3Y5LH1dxt99i54eWJt6E+AQUiTl0pXsDy5IymNPd8=; b=tRF87HgSFLwZpPUe/FNlD3YCb4B6v5gRKneHUMmDMv1rBdSLocaDbcD9v5uHCnvLPj EV+OxgO2Q+AuQ+pOajehg2AYdztMYbUXbNlRDACZzuHqArZ3uXFELwO64DRP3t4nrdP2 NiH92AI/4QQrMwXg5H1mYW/0a1o11Lp3zoIPauJWRmul3e9iidQUTxmhkB6fUvXZ9DzL HyPBDexdlO7xB5PRH/ke27CjmNgu/p6bqkCSMhtomt3DmS/lPiFzrLZvj9ROkibt/jdZ emj7rzzXpvJSOnbVbWJ1HtKpQyKQnEIU5cmtROtuAGuJzbPzkcuZjDS0ivsOITAocX6S K0rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=tOpou7Zj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id jg21-20020a17090326d500b001cfbd3f38c6si247495plb.302.2023.12.06.18.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 18:33:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=tOpou7Zj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 4832D80D6ACC; Wed, 6 Dec 2023 18:33:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443025AbjLGCcx (ORCPT + 99 others); Wed, 6 Dec 2023 21:32:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235174AbjLGCcw (ORCPT ); Wed, 6 Dec 2023 21:32:52 -0500 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [IPv6:2001:41d0:203:375::b5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ABBAD73 for ; Wed, 6 Dec 2023 18:32:58 -0800 (PST) Message-ID: <544aad70-0492-496c-8747-ff6b2a204b3e@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1701916375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XaTAr3n1Zo+WQ9fxFhHx7mUs6gY/pefswV7mSrJu1Fs=; b=tOpou7Zj9UjoYiMxw+NoscyXn9cK0IYzeHsVMBiOwD0nec5YxQ0rQp1TMC3hIXUIaThmev 3teqqT5qXRJE6u4ptQpmA4CSU0IX5NLOj/w1+HipZklpBVwLWh2sccQ9nW3H7/ZZUQi1TE I3tnOXYu5KHOJvs4ymbxt3WpxqT6fZ0= Date: Thu, 7 Dec 2023 10:32:48 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v8 6/6] zswap: shrinks zswap pool based on memory pressure Content-Language: en-US To: Nhat Pham , Yosry Ahmed Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org References: <20231130194023.4102148-1-nphamcs@gmail.com> <20231130194023.4102148-7-nphamcs@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 06 Dec 2023 18:33:08 -0800 (PST) On 2023/12/7 03:47, Nhat Pham wrote: > [...] >> >> Hmm so how should we proceed from here? How about this: >> >> a) I can send a fixlet to move the enablement check above the stats >> flushing + use mem_cgroup_flush_stats >> b) Then maybe, you can send a fixlet to update this new callsite? >> >> Does that sound reasonable? > > I just sent out the fixlet. Yosry and Chengming, let me know if that > looks good. Thank you both for detecting this issue and proposing the > fix! Yeah, also looks good to me. Thanks! -- Best regards, Chengming Zhou