Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231206181317.27515-1-rdunlap@infradead.org>
In-Reply-To: <20231206181317.27515-1-rdunlap@infradead.org>
From:   Peter Chen <hzpeterchen@gmail.com>
Date:   Thu, 7 Dec 2023 11:00:22 +0800
Message-ID: <CAL411-rcnuJtNJnvpkq4KWMib7xP08SEH8c5F1eT2mgZi4H6ng@mail.gmail.com>
Subject: Re: [PATCH] usb: cdns3: starfive: don't misuse /** comment
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org,
        Minda Chen <minda.chen@starfivetech.com>,
        Peter Chen <peter.chen@kernel.org>,
        Pawel Laszczak <pawell@cadence.com>,
        Roger Quadros <rogerq@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Dec 7, 2023 at 2:13=E2=80=AFAM Randy Dunlap <rdunlap@infradead.org>=
 wrote:
>
> Use a common C comment "/*" instead of "/**" to prevent a warning
> from scripts/kernel-doc.
>
> cdns3-starfive.c:23: warning: expecting prototype for cdns3(). Prototype =
was for USB_STRAP_HOST() instead
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Minda Chen <minda.chen@starfivetech.com>
> Cc: Peter Chen <peter.chen@kernel.org>
> Cc: Pawel Laszczak <pawell@cadence.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> ---

Acked-by: Peter Chen <peter.chen@kernel.org>

Peter


>  drivers/usb/cdns3/cdns3-starfive.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/usb/cdns3/cdns3-starfive.c b/drivers/usb/cdns3/cdns3-st=
arfive.c
> --- a/drivers/usb/cdns3/cdns3-starfive.c
> +++ b/drivers/usb/cdns3/cdns3-starfive.c
> @@ -1,5 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
> -/**
> +/*
>   * cdns3-starfive.c - StarFive specific Glue layer for Cadence USB Contr=
oller
>   *
>   * Copyright (C) 2023 StarFive Technology Co., Ltd.