Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1401124rdb; Wed, 6 Dec 2023 19:15:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIxbWd+StujzyJCmJXeW0YkfAuVnv6DcsiTkeTEphiH7z+1EhCkskiwhQp9y1j6xGinHDK X-Received: by 2002:a17:90b:1905:b0:286:6cc0:cabd with SMTP id mp5-20020a17090b190500b002866cc0cabdmr1975248pjb.52.1701918959490; Wed, 06 Dec 2023 19:15:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701918959; cv=none; d=google.com; s=arc-20160816; b=gsz+NHpHNCxZPy9NycZ4nmwqVaPVXtQRt0YBUXfTBjQbCXEDaYPgCPrFC6RCwLxu2y xl0iXiJd/66X3AS78aexPE3Cqbb/gBEmiOrejEwACjt7J7pnLJCYbNMvk6XQd6Y1QbDT QQqDagueu2TZrB/wmZFYfmJfphRaar1zufo8u1CzdDkbG6V8twbBeF+a2yvJFTjukFH1 MEcT6Q/Bvmu1gPQ61ovCruGnFWLoM8JlvbtQwjS08j7BRQARv9OXrHZ//faOBN2bil8k eletTgl2cFcG+WFoM7El9i55oIqD/k0d1+ZyznH2JQSQauRkzwDr46qupFoC8P/pkheA CZQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=SRAZz73xZ/wQzq9LmH5D7EgARdnZgItIkeFCCGRI57E=; fh=oA21W5moCBUIUAQP8yzrgGO77YB5JThv9uqMK6PWddg=; b=Q9fYozIEGayszc3/W2nbBqNgursnC3KBMzicNs875KJTithIlx7xUW8R6vbk3rM24Q yC2xNlPc0D1wYrhO0Toe4LihJsjYWt1glx90Q4uN2nev0N/TNJ7AG1qmk4m6AoptH2WW akhMFzBQePv+3ykIzvTr+uYfIlgr2IvkfUE7KrV1lXl3xWqNfj6Snwu9WHlD4LdaCFru rSZSI91TlwtzSpsVo5dsdR4tXG/V0+/ouzmpIPexWJR/KBZ1lherHQOrPD02n7u0f0PI oqTOPsID/098/IzLvk5/F2T1EUcZaByM5P+d2WbcZLhJYIiQyy7nOij1Ub7MTt2IQmYo D8Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aSLju+4e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id x4-20020a17090a970400b00286942b512dsi306050pjo.6.2023.12.06.19.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 19:15:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aSLju+4e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0ED8081F3703; Wed, 6 Dec 2023 19:15:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229594AbjLGDPi (ORCPT + 99 others); Wed, 6 Dec 2023 22:15:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjLGDPh (ORCPT ); Wed, 6 Dec 2023 22:15:37 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CD09D5A for ; Wed, 6 Dec 2023 19:15:43 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10411C433C8; Thu, 7 Dec 2023 03:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701918942; bh=SRAZz73xZ/wQzq9LmH5D7EgARdnZgItIkeFCCGRI57E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aSLju+4eEJeIUkqF6JDwTQfuLhzmDJ3EawX3T13ddxPpFum1+fPbsj9nN606wV3Mq i9fFZsr1jJtPLFJNEBZz4TSt7+0iMaPrlnhPsLXKTaMRuk17aZaO+Xjbh0r7MKa/F4 PiIH69Ri+ANuMK62qJSvqZjqDCCS9PtCMGtT8zcdxxb20oB1v5wc/DBO0yiVpeXBst TLQIuVhMPSr0RjbRX8EWaqJCX4ZR0hYyOXcBq2USAcsHg5Nhm8CKxAe04C5MAIt5zP JKlDkDFzKEPewUkcECvkdDBN0H/53XREjVLSBABKEG/VUThI5J8G349GXQk+Z7+6Ce ixELhIZx2p/cw== Date: Wed, 6 Dec 2023 19:15:39 -0800 From: Jakub Kicinski To: Yunsheng Lin Cc: , , , , Alexander Duyck , "Michael S. Tsirkin" , Jason Wang , Andrew Morton , Eric Dumazet , , , Subject: Re: [PATCH net-next 2/6] page_frag: unify gfp bit for order 3 page allocation Message-ID: <20231206191539.06d955f3@kernel.org> In-Reply-To: <20231205113444.63015-3-linyunsheng@huawei.com> References: <20231205113444.63015-1-linyunsheng@huawei.com> <20231205113444.63015-3-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 06 Dec 2023 19:15:57 -0800 (PST) On Tue, 5 Dec 2023 19:34:40 +0800 Yunsheng Lin wrote: > __GFP_DIRECT_RECLAIM is xor'd to avoid > direct reclaim in skb_page_frag_refill(), but it is not > xor'd in __page_frag_cache_refill(). xor is not the same thing as masking a bit off. The patch itself LGTM.