Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Wed, 6 Dec 2023 20:51:31 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Huaisheng Ye <huaisheng.ye@intel.com>,
        Ira Weiny <ira.weiny@intel.com>, <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <pei.p.jia@intel.com>
Subject: Re: [PATCH] cxl/core/mbox: get next_persistent_bytes by
 next_persistent_cap
Message-ID: <65714f53394a3_1b2839294ce@iweiny-mobl.notmuch>
References: <20231201164005.135912-1-huaisheng.ye@intel.com>
 <656f9a94d9b48_18297729452@iweiny-mobl.notmuch>
 <5fed153a-6668-c980-c573-3a31077c52ac@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <5fed153a-6668-c980-c573-3a31077c52ac@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0xg8h5APdfJiZSp+eeTBaSAxhiPS5fLKtCoE9eb+igiZK3PpTqexG9nbVkIc?=
 =?us-ascii?Q?Qa5npZPxt3kJLwBeICpmg+FpCWYaG9dZeIQRdTBuNQ55HoqhpyO3+Q3vFDsS?=
 =?us-ascii?Q?YxOssp125xAysJIQusNzlRTeL4wb0btEazwfyObkV4F0m5opvUv8QlEL1e+8?=
 =?us-ascii?Q?KKKSYa/w7FvLHc6Fu3EqR208bnE38s59lCai3V6PYl6DROqYQAMG4mUMsznE?=
 =?us-ascii?Q?JH6HI6DjP53cDDebasPGjO/dUOzfSe6Vu6xfCPl1yZ7IGPDVchkhdBlei1VW?=
 =?us-ascii?Q?TPeY9K/k/C8zB1xBf3YWsZK7Yzuch5nQ5cPSNsV15NUHtufu32J9PDiRmhDw?=
 =?us-ascii?Q?TCB5zgGssZKYnVMwqvyb3hiGJHoI+vA/K9dv5/x3KtSiQtMkkJc5IRgyR0A5?=
 =?us-ascii?Q?+ZqyPomCe8U8UOWwCGvzJ4DNtaUaWB3oGmURgS3gpFc+ofB5g/Z9erRsgS3l?=
 =?us-ascii?Q?5LQcjwCNPxWHf6COGZoZM+xC/ebzmQ7nniIP+M2ndU4TvDYQQbcmnaouGXOc?=
 =?us-ascii?Q?4xBEzvugYRxZFO8T0JesCkeT0UF9yU1dTP93WWlwYSIisvyljHdPq9uYZ44+?=
 =?us-ascii?Q?Cc7DWelFWQQR+p03/83FnhbzUCbn0KQQ5GnqRq8ymsn9H4eRgHrUWWQ69Bhs?=
 =?us-ascii?Q?mVHQA3/hptcEWzFnHxMnBdyEO1UQDs/kPP/Ed6PmHlTIy/fd2b9WOyndJVNe?=
 =?us-ascii?Q?YouDROF2R0HYuYLfIOMYKywGJ+EiQeARc2ZZ3i+FcACmfyfHiqTvv3pHrqDD?=
 =?us-ascii?Q?lOLoPoRzgklggAeSJnd+dfUwo2a0wJHD9KmHix04xYarZW5qmwHkTkmZ+gxs?=
 =?us-ascii?Q?EpxqFMaXCbtBQUvWb3zri5ZbY/FMYDnvjfgin7HMSfdTa5ifiWSh2d82AEMs?=
 =?us-ascii?Q?aFDIeTDQ6BVsYkh1GBqGBvkYphAPRezEriy0UfrDhukpLaYLJ48S0XfKJJ2D?=
 =?us-ascii?Q?B/DWH93IlomJsDrFcp46zIXS0whfsrjmi9CWpgX0WzfLbXISudaNdJwCTUKo?=
 =?us-ascii?Q?1uKH3k9K296jmZA/iLCrNPyQXO+lGksNh9snm8Vu1tKBRId03ljwuzwUnjuM?=
 =?us-ascii?Q?V984vlez/G2yQWuih0QeYfU7afWRwqbmHAsGlrUy9DKJxPNnOrNfIXXlX5NX?=
 =?us-ascii?Q?7lpV3cgTZVdpLUmrbaBEjSluf2ubHpfCyStmdI4eWP31gI48q90wyB7H93oY?=
 =?us-ascii?Q?0MaczAItmKCuFbqbSzo5hWvvswG44vnPaDPMoK5Wcc7jNg1PH1jXJ1AmZM4T?=
 =?us-ascii?Q?hKbRwOJAP8K1CBIpYLCn7/wnDqWRtk9enlTr5NjKtlwN3+j/91Chmk7kdSFk?=
 =?us-ascii?Q?TmHSfMECkCwVuuusP6DO4Sd3kKw7Tr89vjtKAGdv40APMnG8gKFSVj0kLW6X?=
 =?us-ascii?Q?sBx6xwiCTQPierf2Jqyi6q6qDoaUoRbN0JBeKuJjWVxjd6K54ANu/8w+LKHp?=
 =?us-ascii?Q?+b1+IQyduhnABVujSvqPQCKdg8iX5KKBJPX3/6lHwpxkaeJmOu/DT8kypikA?=
 =?us-ascii?Q?6J1KIcgQ5Za/FSwxEbuZiXB/U9wOTiM55f6snN65hc9hq95Yz7kBceNsJ3dE?=
 =?us-ascii?Q?RrUp6r31YHtgRguSq/iXPqwv60SNrGSfy/QzSbtq?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e958143-e9cb-4876-fe77-08dbf6e03075
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 04:51:35.0721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aljMSOnpXaQmzr7Oap0cO0cJGvIEwNpjapwn9SnEh+4ysb39lWxhObKqxpgJC1t6cU/0LmpbwxEieYjIj/4Vyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8310
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 06 Dec 2023 20:52:05 -0800 (PST)

Huaisheng Ye wrote:
> 
> 
> On 2023-12-06 05:48, Ira Weiny wrote:
> > Huaisheng Ye wrote:
> >> According to CXL 2.0 8.2.9.5.2.1 table 176, the next Persistent
> >> Bytes should be calculated by next Persistent Capacity.
> >>
> >> Signed-off-by: Huaisheng Ye <huaisheng.ye@intel.com>
> > Do we have a fixes tag for this?  Was there a bug associated with this
> > find?
> >
> > Ira
> 
> Hi Ira,

Hey...  First off thanks for the patch.  This is obviously something which
is wrong.  I'm just trying to get more details about how much work should
be done to fix this.

> 
> This bug could be found in cxl-next branch.

This looks like it has been a bug for a while.

59f8d1510739e   (Dan Williams   2023-06-14 18:30:02 -0700       1071) mds->next_persistent_bytes =        
4faf31b43468c   (Dan Williams   2021-09-08 22:12:32 -0700       1072) le64_to_cpu(pi.next_volatile_cap) * CXL_CAPACITY_MULTIPLIER;

Both of those commits were refactoring so the fixes goes back a bit more.

My question is: what problem is this causing for the user and should we ID
which commit's this fixes for potential backporting to stable kernels?

Do you have that information?

> It looks like just cxl-pci would calculate next_persistent_bytes during
> probe. Afterwards, it will no longer be accessed by current cxl drivers.
> 
> For v78 ndctl, cxl_cmd_partition_get_next_persistent_size is calculated from
> next_persistent, which is correct.

This too seems to be old behavior.

4f588b964dccf   (Alison Schofield       2022-02-22 11:56:03 -0800 4142)cxl_cmd_partition_get_next_persistent_size(struct cxl_cmd *cmd)

> 
> May I have your Reviewed-by?

Not yet.  I want to know should this be backported and what problems this
causes.  The next values are not going to take effect until the next
reboot/reset of the device.  So they are basically informational, Right?.
Is that why you did not add a fixes to the patch?  If so mention that a
fixes is not needed.  If not, explain why this is something a user might
see and lets figure out what fixes tags to add so this gets backported.

Thanks,
Ira