Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Thu, 7 Dec 2023 10:33:16 +0900
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
Cc:     Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org
Subject: Re: [RESEND PATCH] tty: serial: 8250: Fix MOXA RS422/RS485 PCIe
 boards not work by default
Message-ID: <2023120755-dance-request-8293@gregkh>
References: <20231201074055.259207-1-crescentcy.hsieh@moxa.com>
 <2023120146-pyramid-salsa-d8cd@gregkh>
 <ZWmhKS+quI3dmOND@moxa-ThinkCentre-M90t>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZWmhKS+quI3dmOND@moxa-ThinkCentre-M90t>
Precedence: bulk

On Fri, Dec 01, 2023 at 05:02:33PM +0800, Crescent CY Hsieh wrote:
> On Fri, Dec 01, 2023 at 08:27:05AM +0000, Greg Kroah-Hartman wrote:
> > On Fri, Dec 01, 2023 at 03:40:55PM +0800, Crescent CY Hsieh wrote:
> > > MOXA PCIe RS422/RS485 boards will not function by default because of the
> > > initial default serial interface of all MOXA PCIe boards is set to
> > > RS232.
> > > 
> > > This patch fixes the problem above by setting the initial default serial
> > > interface to RS422 for those MOXA RS422/RS485 PCIe boards.
> > > 
> > > Signed-off-by: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
> > > Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> > > ---
> > >  drivers/tty/serial/8250/8250_pci.c | 58 +++++++++++++++++++++++++++++-
> > >  1 file changed, 57 insertions(+), 1 deletion(-)
> > 
> > Why is this a RESEND?  What happened to the first attempt, did I miss it
> > somewhere?
> 
> This RESEND patch is the first patch of this patch series [1], Jiri
> reviewed the first patch and suggested to split the second patch, so I
> split the second patch and sent it as a new patch.
> 
> However, the first patch seems to be overlooked, so I resend it.
> 
> [1] https://lore.kernel.org/all/20231027062440.7749-1-crescentcy.hsieh@moxa.com/

Looks like 0-day had a problem with it, please fix that up and resend a
new version.

thanks,

greg k-h