Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <79adaf72-2401-9e95-f760-9d52adfd074c@intel.com>
Date:   Thu, 7 Dec 2023 08:12:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [Intel-wired-lan] [PATCH net-next v5 1/3] ethtool: Implement
 ethtool_puts()
To:     <justinstitt@google.com>, "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Shay Agroskin <shayagr@amazon.com>,
        Arthur Kiyanovski <akiyano@amazon.com>,
        David Arinzon <darinzon@amazon.com>,
        Noam Dagan <ndagan@amazon.com>,
        Saeed Bishara <saeedb@amazon.com>,
        Rasesh Mody <rmody@marvell.com>,
        Sudarsana Kalluru <skalluru@marvell.com>,
        <GR-Linux-NIC-Dev@marvell.com>,
        Dimitris Michailidis <dmichail@fungible.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Louis Peens <louis.peens@corigine.com>,
        "Shannon Nelson" <shannon.nelson@amd.com>,
        Brett Creeley <brett.creeley@amd.com>, <drivers@pensando.io>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Ronak Doshi <doshir@vmware.com>,
        "VMware PV-Drivers Reviewers" <pv-drivers@vmware.com>,
        Andy Whitcroft <apw@canonical.com>,
        "Joe Perches" <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        "Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        "Andrew Lunn" <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "Vladimir Oltean" <olteanv@gmail.com>,
        =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>,
        Daniel Golle <daniel@makrotopia.org>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        =?UTF-8?Q?Alvin_=c5=a0ipraga?= <alsi@bang-olufsen.dk>,
        Wei Fang <wei.fang@nxp.com>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        "Steen Hegelund" <Steen.Hegelund@microchip.com>,
        Daniel Machon <daniel.machon@microchip.com>,
        <UNGLinuxDriver@microchip.com>,
        Jiawen Wu <jiawenwu@trustnetic.com>,
        Mengyuan Lou <mengyuanlou@net-swift.com>,
        "Heiner Kallweit" <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Jesper Dangaard Brouer" <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>
CC:     <linux-hyperv@vger.kernel.org>, Kees Cook <keescook@chromium.org>,
        <netdev@vger.kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        <linux-kernel@vger.kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        <oss-drivers@corigine.com>, <intel-wired-lan@lists.osuosl.org>,
        <linux-mediatek@lists.infradead.org>, <bpf@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <20231206-ethtool_puts_impl-v5-0-5a2528e17bf8@google.com>
 <20231206-ethtool_puts_impl-v5-1-5a2528e17bf8@google.com>
Content-Language: en-US
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20231206-ethtool_puts_impl-v5-1-5a2528e17bf8@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUxCZlExM2FNMWdBWG16UU1zeW1WVktlY1A5TnRFOXpNQUlidGlKU0lQbTNG?=
 =?utf-8?B?THVKYVRodG1NQVJoY1dRY1VQakZ5aHhISzhmd3ZhS0R0LzFrQ3ZmeWd5U0oy?=
 =?utf-8?B?c3c4QzV2U3hKM2lpVDRPM1NEa0txYTZOMXlBZnJucCs4K2MzTERzQjZQVzNz?=
 =?utf-8?B?QVZYMDVJNEJDUWhsRERDTVhHdkdnRTJJS0IwWm9GVk4ya25URmd3MTZmYmRa?=
 =?utf-8?B?dkFyMkc2YU5GMGZRc3djMmdsbEpNdkJENWpPWUVIeTFmbC9FdSs1OWM1SVRp?=
 =?utf-8?B?WUVPcEs5eGt1YWQxRVBUbG1USnN5aG92TFpKWVl4NDBjSFdXU3A2TS91Rk9G?=
 =?utf-8?B?ZGpQZGFPeStJSkZtUkJBMUsyZFFrR0d3YWVjTDExNDY3dXlQZUZIUTJSdEw3?=
 =?utf-8?B?QXJDNW5QN3VKSzBwV2o4eDVvRnYrTmk0Z2JSZ2NhK1V0dWMwRi9tcjZabzRy?=
 =?utf-8?B?TlVRNWRjWUpISzRYZE9DY09LdU1rMVNGNnFPZ3IyV2J3eUQ4cUtOY0Q1VFV4?=
 =?utf-8?B?RFJSb04zbWNWRmJDelVhRDN4Y2dIaHlxSzlzaWhiVnduVXExSnZBZ0FRaE0v?=
 =?utf-8?B?YXczUzZwUWN2bENOb1E4TFgxTkhXbXBWVytDNmFIeWJxUE5PN2gzTHJsQ1pq?=
 =?utf-8?B?MUdrdmpSRzJadzhEWVJBZjZJYU8wNEs0WXNiYkZlaTk4eUNIeUhTOXdOQjlv?=
 =?utf-8?B?QjE2QWRPS3JDbkVzV2lmQXIxeDFVY201UHZ3QitUTXlNSm9oQ3RzRXNaeDZv?=
 =?utf-8?B?Zzd2MW4xU0VtakF0czR4TFZLRHZ2ZkFpRXovekdqckZBTkUrN0xJQUJDb0h1?=
 =?utf-8?B?OXhsaHhySHVGMmdTTWowRjNuZ0pTeWljdnp2alM3MEZ3SjFEYmdsaUFUMCt6?=
 =?utf-8?B?dmVXdWN4am1MZ1JoQzdNRjVHQ1Q4dTdsRTE1RzlnWGFUM1hlNHdlYmFVUk9O?=
 =?utf-8?B?d0M1YzFYMlpDKy9yOVcza0FJU3QyTkkrWVc5N1JYVG9rUkVxdTl4ZEs4QXhI?=
 =?utf-8?B?YTFKdWYzaFEvRHF4Z0NRdk9UdVZ1ZzB1OHpNaGN4ZlJLZHRzYkdFeEFtZGhU?=
 =?utf-8?B?ZGYyRDJMU202dmIrZkRXZWRLNnBaa1g3REtWUUlZVXZzYWNyaDR3N3BiR2Vi?=
 =?utf-8?B?OHQ2R01iRWJ2Z3BKdW5YLzRqTDZOT2owN01LYURZYkRkY2pPTllxb283MWhQ?=
 =?utf-8?B?SUh6cGFSWTcrdjZPWGpJQlZuSGdERExjYnl3ZEdsMzZoRlQyL3dqQkRZdjBC?=
 =?utf-8?B?ejdYaDVaZnBpRkRtVFJqaUY1aytsSkpUY0lyUmRnUXlaYm5jSndKUzR0azFu?=
 =?utf-8?B?WmYxckJJd1psdnJTVzc1TEI3dDlDcXhFd3J4di9MdTlJWGZSa1RicXpOK21h?=
 =?utf-8?B?czBuQnUrR2lWZEM2SGN1RmZFMUdMZGNiayt2Zkd2SXRRTlJVQUE5L2FZUnFG?=
 =?utf-8?B?NndUNENMTnVNVGxqUG9xc2diWWVFc2l1dkRSRFppT0NnZWtzVkRaVTZkK2Zx?=
 =?utf-8?B?RFphYm43RTVYT1FWcjdpNVNtZm9Pb01QYVlzRTJBbXdCRkkvbXBsOGlyT3V4?=
 =?utf-8?B?VGtCUkFIdkdOcnFGRElKY0JvcVlNZTJ2QnVETEUwcTYxbEo0amVSQ3J0RzFX?=
 =?utf-8?B?bk16cGczRzZKY2NldkxzY2orU3dzOTBBZmdlYUxyYkpqbHVEeER3OG5KTFBh?=
 =?utf-8?B?QUhVYXN2THZWV0svNTg0Z3hNZ3V3elNNRy8yNDNqVERuS2FZZWorSkl6UVI3?=
 =?utf-8?B?ZmdwbjNSTldGc1Q0YjlzMG9lTkFGWjdnby81T3NMazJhWmViTFlkZW9ITEZV?=
 =?utf-8?B?WmhJV3Vxa2xIcFFYaDVEWWVUeFNNajcrRWloZVMrYVkwMjl2SjQ1NThod2pC?=
 =?utf-8?B?SEY1MElpUmR4OFE1NSt0NEVkOEZhZU4vZ3BQRzFsSmRmeXNzd2w1eEtrV2F6?=
 =?utf-8?B?aGVpN0V6U05DWExBeE9uUm9nYi9pdFFjb3RGem5DNGhPbGx0VU9aYzBsaGts?=
 =?utf-8?B?bzZqNktQdW03Lyswd1BLRWZLdi9JOGRUTlZFRFZ1dWJDSk5wWklLbkZ4RVBh?=
 =?utf-8?B?YXBidXJHaHc5Vk1XZk5sM0FHYkRoeUFZRlk2RG1INktDdG9ReXU2c3dROVFw?=
 =?utf-8?B?RkdSa2hXTGRjODk5VnFNem9xcjZtTng3ZVYxSlM3TW1sLzlYT3hiL0twS25W?=
 =?utf-8?B?YlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ffb3ea1a-77d6-4605-6e8f-08dbf6f3fbe4
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 07:13:16.9678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ErjUcHtz9LQWqrLi4WbM0osCO+ATADT/kiw99dwpr35AE4AFNh73vBpgP23rCRxyBSEKKoti0Z+M+vtyCaui8Xfc34XIAlc4iMifQrFokkM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5385
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 06 Dec 2023 23:13:47 -0800 (PST)

On 12/7/23 00:16, justinstitt@google.com wrote:
> Use strscpy() to implement ethtool_puts().
> 
> Functionally the same as ethtool_sprintf() when it's used with two
> arguments or with just "%s" format specifier.
> 
> Signed-off-by: Justin Stitt <justinstitt@google.com>
> ---
>   include/linux/ethtool.h | 13 +++++++++++++
>   net/ethtool/ioctl.c     |  7 +++++++
>   2 files changed, 20 insertions(+)
> 


Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>