Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1493913rdb; Thu, 7 Dec 2023 00:01:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/PEdz6JcDEaBaHUQLNCMF5XVa2J2ctOI+YLx/WrgvFoaFM8jYNT/X+q/jbuh+DP0Fi6on X-Received: by 2002:a17:902:b683:b0:1d0:568e:83d9 with SMTP id c3-20020a170902b68300b001d0568e83d9mr5183814pls.10.1701936095887; Thu, 07 Dec 2023 00:01:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701936095; cv=none; d=google.com; s=arc-20160816; b=GghZrCvb7pJyCQRIi7uJ0AS7MAjIgquIOUiyaYmUmjPz57wolwjfe95cCafs0WNf5g Ov8avttwp55HetT/rGpy/klDD2Q6Obio7zvf/akycfPq9yuzPmWCuGd6zH71C9/ChFAQ 0V7yCHuvkWdhAIus0Ir4I50TPLLBLjUIcsiep4BSZr6ttEtSk+IkLKDmCNhUaTrg/MYC c/eRecXAfFPZxI+fIhdcreYDaJO++Pvtwl8jJweKTzccyjX0B3YBDbZ9KclSjbxnLbkn WdUSVANxb/H54jlTVkcvSb9kMqUMG/iiK6XjV01bIIH4aR2HzOtPJ7LAzkOH83y3Qd00 Sy1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1XN7/1mSt6jrbd5J57oYed0Yh2BaXUbwVPDlGNXVGO8=; fh=PpoF1jFCZKs8Q8WgR4DSuMRfCY/+vqZDYNYM6urGvhM=; b=hNVjzEFMz2qivmUE8Q3vYsakxmWOrq01GJsug5ppcg6lKOZgbS+1/a6Jcovt861gYI TRz+n3d5nQ3li2UmM0Dh9r0KPhwUue/K6ksXDuohIaHljjAeKtGunK22HUQl1jGlEUdq IkoI9Y1FBC69QYX6J63sGrPTMQ9y3V3ncoUOto/n3P+hj/iZYc1HTo1AHkB3XqZdZtDi Lvh1dsPVfBscj9dvta496wxdKKeRmjocx/4xcW4NjOKPBs9AdDlOsQClCBv1ZSpID/Jp zjrkxO+obGUcsZxEMOOkZgCEXWXEC67nOi/KYXxVcOtAY0LapeZQ5lhZElW2YYdzWXmg +mhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=isIq0Z1Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id bw7-20020a056a02048700b005c65eb2bc62si756761pgb.237.2023.12.07.00.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 00:01:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=isIq0Z1Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 3244F80DFA6E; Thu, 7 Dec 2023 00:00:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbjLGIAB (ORCPT + 99 others); Thu, 7 Dec 2023 03:00:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbjLGH77 (ORCPT ); Thu, 7 Dec 2023 02:59:59 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F674A9 for ; Thu, 7 Dec 2023 00:00:05 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECB39C433C7; Thu, 7 Dec 2023 07:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701936004; bh=I681gHWMUSa0Ipi09gdgntlBhUESlz33stQ0H29C43o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=isIq0Z1Zo2xyN9yQmONswOxPpZI/SHW+J6RK13AEY+reg6kdXEMFUqnajpRgxtE9p TVYV2YD6CTK7DynnWBIwybKrVQ+38vg/j7jZCv11QEbzPwCzaZ1fi+hcB6G0rl91Ww 08D9+pnkkOBNUsF5+VBm5Uj0XtODYcCoArh+EJ7AZ2e7fmO0Eql9hVbjrMqW1zhXjH bK/3tBQ4GkxuG34ULsud3h/+pMxbP54UdhZf+J3talfW3WZGQ2DML9ie2Kx5FPixLU qoUKVBMRgBug4xnCswBjbfrpWFqO7gU0LBsRgvmAHzWVlPr13yWRaedbNqyiPYr7BV Dz88b1LGr7pgg== Date: Thu, 7 Dec 2023 13:29:52 +0530 From: Manivannan Sadhasivam To: Manikanta Maddireddy Cc: bhelgaas@google.com, thierry.reding@gmail.com, petlozup@nvidia.com, rafael.j.wysocki@intel.com, lpieralisi@kernel.org, robh@kernel.org, jeffy.chen@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, jonathanh@nvidia.com, dmitry.osipenko@collabora.com, viresh.kumar@linaro.org, gregkh@linuxfoundation.org, steven.price@arm.com, kw@linux.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, vidyas@nvidia.com Subject: Re: [RFC,v14 4/5] arm64: tegra: Add PCIe port node with PCIe WAKE# for C1 controller Message-ID: <20231207075952.GG2932@thinkpad> References: <20230208111645.3863534-1-mmaddireddy@nvidia.com> <20230208111645.3863534-5-mmaddireddy@nvidia.com> <20231206153627.GJ12802@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 00:00:19 -0800 (PST) On Thu, Dec 07, 2023 at 12:54:04PM +0530, Manikanta Maddireddy wrote: > > On 06-12-2023 21:06, Manivannan Sadhasivam wrote: > > External email: Use caution opening links or attachments > > > > > > On Wed, Feb 08, 2023 at 04:46:44PM +0530, Manikanta Maddireddy wrote: > > > Add PCIe port node under the PCIe controller-1 device tree node to support > > > PCIe WAKE# interrupt for WiFi. > > > > > > Signed-off-by: Manikanta Maddireddy > > > --- > > > > > > Changes in v14: > > > New patch in the series to support PCIe WAKE# in NVIDIA Jetson AGX Orin. > > > > > > .../dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts > > > index 8a9747855d6b..9c89be263141 100644 > > > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts > > > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts > > > @@ -2147,6 +2147,17 @@ pcie@14100000 { > > > > > > phys = <&p2u_hsio_3>; > > > phy-names = "p2u-0"; > > > + > > > + pci@0,0 { > > > + reg = <0x0000 0 0 0 0>; > > > + #address-cells = <3>; > > > + #size-cells = <2>; > > > + ranges; > > > + > > > + interrupt-parent = <&gpio>; > > > + interrupts = ; > > > + interrupt-names = "wakeup"; > > WAKE# should be part of the PCIe controller, not device. And the interrupt name > > should be "wake". > > > > - Mani > Hi, > > Please refer to the discussion in below link, WAKE# is per PCI bridge. > https://patchwork.ozlabs.org/project/linux-pci/patch/20171226020806.32710-2-jeffy.chen@rock-chips.com/ > PCIe Host controller (RC) usually represents host bridge + PCI-PCI bridge. We do not represent the PCI-PCI bridge in devicetree for any platforms, but only RC as a whole. Moreover, PERST# is already defined in RC node. So it becomes confusing if WAKE# is defined in a child node representing bridge. So please move WAKE# to RC node. - Mani > I carried wakeup name defined in previous version, but wake seems to be > sufficient. > > Thanks, > Manikanta > > > > > + }; > > > }; > > > > > > pcie@14160000 { > > > -- > > > 2.25.1 > > > > > -- > > மணிவண்ணன் சதாசிவம் -- மணிவண்ணன் சதாசிவம்