Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1502899rdb; Thu, 7 Dec 2023 00:22:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEH5TIT5rEZqTC2UvJv8VGNLlhfd2iMP17omZB5kQYNTIlMMaOdIxDpXlXlB01dOKR9dEtF X-Received: by 2002:a05:6a00:419b:b0:6c4:d12c:adf0 with SMTP id ca27-20020a056a00419b00b006c4d12cadf0mr2416174pfb.33.1701937335072; Thu, 07 Dec 2023 00:22:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701937335; cv=none; d=google.com; s=arc-20160816; b=oXcOZtallvaI3suye/aTyxc7GCxkqJHkhfioPnHpRfG6SIWzViruz3EEdKk/D18G7i mXVike07+iupITpe/LK3BT2X4yGaxI7/k4XM3xoZ0/XZS/AQWfTnacOIpLJBY6XcrfBW 8CqyVWKomnfNtNzOUtF89L+4Z8XFyFTy2TZ9DoesrqjpAX0IoVmonI7T7MD5ugvdJ04q srIXD+CBSWG7whqNCOgV0Ui0y5twuFWSEr+DOpYdRA4Enak4M52ZT3WVaJ+BVCug59y6 psmBqkMNym9dBwxH8DDw66gGKo9Xy4CXU2WjtC1vL9+NQayiJbvHpietyO274g0OdDNW Azxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=iesPq3HcqaI2YSNevRCTph9mFOv6dmjQ5O0wlQYX1uw=; fh=K06Jco0a5Hd2X5wdXGCplGw8z+4vmGZK/avjKpeDM8o=; b=GVvZyVvSNH/GkdI9xFe2sONLx/+ietpQkrE/re7w4BvGI8o0b87neB46u9zFh5NXxz 2g80Ee5OUpI5K1tEWz4Wz86/BV4VVGojO3kTBvt6F1djImsIs91T0NQ5/FDD0Pvjx/uk PWy3xJOx4VN9jdx+LbCF44CU8JJj1kb0NNiC85Gx3+MGOL00WCijVENG2WO5IUVEoK4C 5J1eI/u2lsiCr2jvJIhwiEte1bGJqWImNegMiLTapDVHIuPd8b4LTYKqVPC0GD7/sSJG LVINDT8WaeANuoDDjxp1dz33pbdYJgWWXQqCZvL62UFa7fUtW9q9lKNzMzkEbOk9P2ZV 8OGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id p12-20020a63c14c000000b005c661a0e6b5si735897pgi.750.2023.12.07.00.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 00:22:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id C8E4180775BA; Thu, 7 Dec 2023 00:21:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231845AbjLGIU5 (ORCPT + 99 others); Thu, 7 Dec 2023 03:20:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231876AbjLGIUV (ORCPT ); Thu, 7 Dec 2023 03:20:21 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4299410DB; Thu, 7 Dec 2023 00:20:24 -0800 (PST) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Sm6Xw0KSszShmK; Thu, 7 Dec 2023 16:16:00 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Dec 2023 16:20:22 +0800 From: Yicong Yang To: , , , , , , , , , , CC: , , , Subject: [PATCH 2/2] perf hisi-ptt: Fix one memory leakage in hisi_ptt_process_auxtrace_event() Date: Thu, 7 Dec 2023 16:16:35 +0800 Message-ID: <20231207081635.8427-3-yangyicong@huawei.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20231207081635.8427-1-yangyicong@huawei.com> References: <20231207081635.8427-1-yangyicong@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 07 Dec 2023 00:21:14 -0800 (PST) From: Yicong Yang ASan complains a memory leakage in hisi_ptt_process_auxtrace_event() that the data buffer is not freed. Since currently we only support the raw dump trace mode, the data buffer is used only within this function. So fix this by freeing the data buffer before going out. Fixes: 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet") Signed-off-by: Yicong Yang --- tools/perf/util/hisi-ptt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c index 43bd1ca62d58..52d0ce302ca0 100644 --- a/tools/perf/util/hisi-ptt.c +++ b/tools/perf/util/hisi-ptt.c @@ -123,6 +123,7 @@ static int hisi_ptt_process_auxtrace_event(struct perf_session *session, if (dump_trace) hisi_ptt_dump_event(ptt, data, size); + free(data); return 0; } -- 2.24.0