Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1503334rdb; Thu, 7 Dec 2023 00:23:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGiwp+Y6vY1XIyf1cf8XVVXrxeWhxnWMi1JkAn4vg0T3l+kL7mZww8lsboD0WjxvdAJVYpB X-Received: by 2002:a17:902:b60f:b0:1d0:c7e0:c82c with SMTP id b15-20020a170902b60f00b001d0c7e0c82cmr1695520pls.8.1701937411325; Thu, 07 Dec 2023 00:23:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701937411; cv=none; d=google.com; s=arc-20160816; b=x60bDe0h2XyRrJooVPKrq/EnCn/J0WBv7r/MttS/xOrrIbNsWmZkdUnQvAvCLOKZ4l AHsGll3V396Gu4JpY3B8CqAT/0U7aXdjeyrGm4HZ+8XtjN+zqrfvyaJAEdtY1SLJzG4E 8+hVJqnW1kmFIsSgBg6N+kFCJVrjw+6/rJ7t+Kf/3kRU3FfSctisPqXTbscVzcRFDdRy HQMln2Dv32orn/1RcA1b1uQuZ3mM5r09hs46WJp1QraWCOC0bzS2yQnvhaiNbI/vti2Y RD4GoH4A8Ofc1s3uoEKTIWomDe6k7BbdnisE/1Rcosy94VIcEZlEyh6WzA7vLR/GJIl3 czfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZrFkvVjmgGqgbYVIpnx13kdaPXXAZZlJh+/DhftTK40=; fh=JJ6XuJws04ZTDoXMtogHpkKD8YDwoIWFzY7xNjodiaE=; b=HtwTY7Bl8UA/fV/APXsIjvAJK367mEiCQNorscj0jqiMlzWkvYqy6qHjOQAF1leOMO OGf4sr8HWJQfDmAdpdmG4q/iLAzWDb05DiZCCheVX04uZXJIz8BPbteAoXfNzT2/vM7O YAWVQKLRYqonxFV15axHmYWudrFwLcAESyBRYgDSkIA7L2SBhT716Q6PwtcicWgrcSEg BSXlNwsZiM6Sjsh+SdV3oZNtpCO2iD3jnV9HG6br3yAfFeHTrLJu//rdgua0GIAJO0vA PbM6ffop440npYQvVrRQOmybvzysIWA0ucWwVLvHyVc6tpGZ36LyvTx/fm7iS1TqMTmi z0lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=C7D41x5B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id ju17-20020a170903429100b001d06eae7137si715224plb.260.2023.12.07.00.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 00:23:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=C7D41x5B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id D2F0C8075295; Thu, 7 Dec 2023 00:23:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbjLGIXO (ORCPT + 99 others); Thu, 7 Dec 2023 03:23:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbjLGIXE (ORCPT ); Thu, 7 Dec 2023 03:23:04 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F6A4173E; Thu, 7 Dec 2023 00:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZrFkvVjmgGqgbYVIpnx13kdaPXXAZZlJh+/DhftTK40=; b=C7D41x5BQlcgnROxpxe2FuMQCO NqP32cw6wsk+h5AodZ+vpsjltQ6pmrzcfG9fsTeQ2/7TRT8Bzj5xc77Y5bFg+DjR7qRU4BOPRPsFO pkL2rMBszmQcNNiHxSiyBd7BcmwkrLz8fTcQ70BCNs+/MBJT1BXbeFCGt5HqEcnwZ0IjOSs+81JB3 VOYJ6FlBerKIelhEG6tYS0WEmx05l4+3OPjzjoMAv8OUqmj4IiSqf3jBx/vMVf/2pJQJpyR2Ddq4c NUVHcPDOAWcYwPUkWj1sll505OSjhGlzb7q0jKkBY8z/gY7yps4NCeQl69OOFfURPa1DmaIuYE9M7 lXuKNBKA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rB9ev-00CCR5-0I; Thu, 07 Dec 2023 08:23:01 +0000 Date: Thu, 7 Dec 2023 00:23:01 -0800 From: Christoph Hellwig To: Sergei Shtepa Cc: axboe@kernel.dk, hch@infradead.org, corbet@lwn.net, snitzer@kernel.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, viro@zeniv.linux.org.uk, brauner@kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Sergei Shtepa Subject: Re: [PATCH v6 06/11] blksnap: handling and tracking I/O units Message-ID: References: <20231124165933.27580-1-sergei.shtepa@linux.dev> <20231124165933.27580-7-sergei.shtepa@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231124165933.27580-7-sergei.shtepa@linux.dev> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 00:23:29 -0800 (PST) > + > +static int (*const ctl_table[])(struct tracker *tracker, > + __u8 __user *buf, __u32 *plen) = { > + ctl_cbtinfo, > + ctl_cbtmap, > + ctl_cbtdirty, > + ctl_snapshotadd, > + ctl_snapshotinfo, > +}; Please use a switch statement like the rest of the kernel. Besides being simple to follow it also avoid having a speculation gadget on user controlled input.