Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231206-th1520_mmc_dts-v8-0-69220e373e8f@baylibre.com> <20231206-th1520_mmc_dts-v8-2-69220e373e8f@baylibre.com>
In-Reply-To: <20231206-th1520_mmc_dts-v8-2-69220e373e8f@baylibre.com>
From:   Guo Ren <guoren@kernel.org>
Date:   Thu, 7 Dec 2023 16:23:10 +0800
Message-ID: <CAJF2gTTnhBZWZxad8=+9W38WL7sRFmugxAyDDzK=BUPK44q4qA@mail.gmail.com>
Subject: Re: [PATCH v8 2/4] riscv: dts: thead: Add TH1520 mmc controllers and
 sdhci clock
To:     Drew Fustini <dfustini@baylibre.com>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Jisheng Zhang <jszhang@kernel.org>, Fu Wei <wefu@redhat.com>,
        Conor Dooley <conor@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jason Kridner <jkridner@beagleboard.org>,
        Robert Nelson <robertcnelson@beagleboard.org>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 6, 2023 at 4:09=E2=80=AFPM Drew Fustini <dfustini@baylibre.com>=
 wrote:
>
> Add node for the fixed reference clock used for emmc and sdio nodes.
> Add emmc node for the 1st dwcmshc instance which is typically connected
> to an eMMC device. Add sdio0 node for the 2nd dwcmshc instance which is
> typically connected to microSD slot. Add sdio1 node for the 3rd dwcmshc
> instance which is typically connected to an SDIO WiFi module. The node
> names are based on Table 1-2 C910/C906 memory map in the TH1520 System
> User Manual.
>
> Link: https://git.beagleboard.org/beaglev-ahead/beaglev-ahead/-/tree/main=
/docs
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> ---
>  arch/riscv/boot/dts/thead/th1520.dtsi | 34 +++++++++++++++++++++++++++++=
+++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/=
thead/th1520.dtsi
> index ba4d2c673ac8..8b915e206f3a 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -146,6 +146,13 @@ uart_sclk: uart-sclk-clock {
>                 #clock-cells =3D <0>;
>         };
>
> +       sdhci_clk: sdhci-clock {
> +               compatible =3D "fixed-clock";
> +               clock-frequency =3D <198000000>;
> +               clock-output-names =3D "sdhci_clk";
> +               #clock-cells =3D <0>;
> +       };
> +
>         soc {
>                 compatible =3D "simple-bus";
>                 interrupt-parent =3D <&plic>;
> @@ -304,6 +311,33 @@ dmac0: dma-controller@ffefc00000 {
>                         status =3D "disabled";
>                 };
>
> +               emmc: mmc@ffe7080000 {
> +                       compatible =3D "thead,th1520-dwcmshc";
> +                       reg =3D <0xff 0xe7080000 0x0 0x10000>;
> +                       interrupts =3D <62 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks =3D <&sdhci_clk>;
> +                       clock-names =3D "core";
> +                       status =3D "disabled";
> +               };
> +
> +               sdio0: mmc@ffe7090000 {
> +                       compatible =3D "thead,th1520-dwcmshc";
> +                       reg =3D <0xff 0xe7090000 0x0 0x10000>;
> +                       interrupts =3D <64 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks =3D <&sdhci_clk>;
> +                       clock-names =3D "core";
> +                       status =3D "disabled";
> +               };
> +
> +               sdio1: mmc@ffe70a0000 {
> +                       compatible =3D "thead,th1520-dwcmshc";
> +                       reg =3D <0xff 0xe70a0000 0x0 0x10000>;
> +                       interrupts =3D <71 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks =3D <&sdhci_clk>;
> +                       clock-names =3D "core";
> +                       status =3D "disabled";
> +               };
> +
>                 timer0: timer@ffefc32000 {
>                         compatible =3D "snps,dw-apb-timer";
>                         reg =3D <0xff 0xefc32000 0x0 0x14>;
>
> --
> 2.34.1
>
Reviewed-by: Guo Ren <guoren@kernel.org>

--=20
Best Regards
 Guo Ren