Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1546951rdb; Thu, 7 Dec 2023 02:09:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUACf7c5dLmQdLBAPXXFcKgdkUq1OKDtsAZTxvvAtXnWZ4PkGe1fxgbElkWGTSTwyxLSTz X-Received: by 2002:a17:90a:c095:b0:286:f3ec:289 with SMTP id o21-20020a17090ac09500b00286f3ec0289mr2186667pjs.45.1701943797325; Thu, 07 Dec 2023 02:09:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701943797; cv=none; d=google.com; s=arc-20160816; b=WbVpPyslBR4TfflJXEOjJO17sj9WOsa3VBRAw2kWpDSpB5wCfQXHZeGgPVAX/gVqWQ U+qzNXgmPdk0UaWbBp9uXl//ITKluhkAjN0zjROrBpIGDh+xBPHqIKBHuLpDjjgxhvjk NcCkpmAa/pQadgKQlirxXRkJ2SB86uD0UEKyIvOX7dVz+O5XIilTBJnOJrRCuEKFC5rm sQHoZPow58sf6ybHQraisu8AjfbbcnqpJFZ5JmabNKDW974Sdrn8jOjUeOiaJkcVFYlc CNpIFcbXWAKCTGu3pp7zDVs3Ntcr/cTB0p8ZOXEv3S9X6iHv/evYLMcIrcPCN/5x5VE2 IFQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from:dkim-signature; bh=3HnFZidrFPT7G3js2sYb5GGxgCdIbdFDyaF/b1eRIEQ=; fh=3QHIQ2u9thAcEPSUgMu7Sb7KHLxL1Vf5F0EuNQA/jtA=; b=rGkRuLtSqKPYNzOQZm3AQUedvXXBFH0N6R2mbBxcSMvkmWe41bpC7Q9BHteWbcXUTJ IOQ1/98bxvYpPzoAlfoppSMDFQqxtVBBKcPSM0XDLeS2MQqewxIQ2SmAALYw4m1h+u1/ IJZoC8Oc/8INftW1eCxcidv3OYfMLEEZ9EjPKzHyzOj+hXK7hXbYMFNGsnVbmrbP6xT0 jBr67gyWNX5mCiurrBfX4yH9qSjPfiG8RD3ISEatKfPGHpxpm7wwn4Xv09T47CpVVZcD ixoJaT94aCO02F7DhQxfiZXN/StycT3itsKE4xyo5hDoT4Y6IFvI5uEdRqHhINJ8Kk4K MGRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="nXDrK/Zf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id y1-20020a17090aa40100b0028515f9b7d1si804780pjp.168.2023.12.07.02.09.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 02:09:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="nXDrK/Zf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0375C80CF507; Thu, 7 Dec 2023 02:09:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232507AbjLGKJi (ORCPT + 99 others); Thu, 7 Dec 2023 05:09:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232033AbjLGKJg (ORCPT ); Thu, 7 Dec 2023 05:09:36 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97D25A4 for ; Thu, 7 Dec 2023 02:09:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701943782; x=1733479782; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=stqB4Md+ZZOYLCgF6qapx4pmRrG6lHUghmboWy8jyL4=; b=nXDrK/ZffGtlFrRQSDToBFvoH6v7MXYWLzrOro7xKYBi0s6FKVAv7wGn M6QC01Nn+t26CNgR9Zz4VXaEq6gxCK8LCj6uWQip9/q5hVPz8fJFC/aEL TwKMNk6qTvLbPnciNWdT/mb9/a73NeswRIjIhmNE+J+rirrGwyLBuC6s/ MAIauDWN+VvSVqXO4/t+fcefkoJlRzcfZCnIoIaJK40fv/pTtl4dIh7Ax w8koCdCaJz0/bM/QDTMQ/+SnPIBNFG3aVtC5Wp0L3zt8xHIgy08jAMhlo OOUUW8V1EIxlapzlkNmbYuk2xYj1m+NK4JWUf6g7w5r3z08aUlgExt17E g==; X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="1313255" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="1313255" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 02:09:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="800685910" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="800685910" Received: from mrehana-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.62.169]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 02:09:39 -0800 From: Jani Nikula To: Dario Binacchi , linux-kernel@vger.kernel.org Cc: Thomas Zimmermann , Maxime Ripard , dri-devel@lists.freedesktop.org, Dario Binacchi Subject: Re: [PATCH] drm/debugfs: drop unneeded DEBUG_FS guard In-Reply-To: <20231206150201.669055-1-dario.binacchi@amarulasolutions.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231206150201.669055-1-dario.binacchi@amarulasolutions.com> Date: Thu, 07 Dec 2023 12:09:36 +0200 Message-ID: <87cyvi1fz3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 07 Dec 2023 02:09:54 -0800 (PST) On Wed, 06 Dec 2023, Dario Binacchi wrote: > The Makefile enables/disables the file compilation depending on > CONFIG_DEBUG_FS. > > Signed-off-by: Dario Binacchi Reviewed-by: Jani Nikula > --- > > drivers/gpu/drm/drm_debugfs.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c > index f291fb4b359f..f80d9cf3e71a 100644 > --- a/drivers/gpu/drm/drm_debugfs.c > +++ b/drivers/gpu/drm/drm_debugfs.c > @@ -45,8 +45,6 @@ > #include "drm_crtc_internal.h" > #include "drm_internal.h" > > -#if defined(CONFIG_DEBUG_FS) > - > /*************************************************** > * Initialization, etc. > **************************************************/ > @@ -588,5 +586,3 @@ void drm_debugfs_crtc_remove(struct drm_crtc *crtc) > debugfs_remove_recursive(crtc->debugfs_entry); > crtc->debugfs_entry = NULL; > } > - > -#endif /* CONFIG_DEBUG_FS */ -- Jani Nikula, Intel