Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Thu, 7 Dec 2023 12:19:57 +0100
From:   Joel Granados <j.granados@samsung.com>
To:     Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC:     Luis Chamberlain <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Iurii Zaikin <yzaikin@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-hardening@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables
Message-ID: <20231207111957.b24ib4hcxr6xufll@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="5z5snkykkq6vptla"
Content-Disposition: inline
In-Reply-To: <d50978d8-d4e7-4767-8ea7-5849f05d3be1@t-8ch.de>
CMS-TYPE: 201P
References: <20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net>
        <ZW66FhWx7W67Y9rP@bombadil.infradead.org>
        <b4b0b7ea-d8b3-4538-a5b9-87a23bbdac5f@t-8ch.de>
        <CGME20231205171700eucas1p17edbc33ec1d0be37573b1977b76b9ce6@eucas1p1.samsung.com>
        <d50978d8-d4e7-4767-8ea7-5849f05d3be1@t-8ch.de>
Precedence: bulk

--5z5snkykkq6vptla
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 05, 2023 at 06:16:53PM +0100, Thomas Wei=DFschuh wrote:
> Hi Luis, Joel,
>=20
> On 2023-12-05 09:04:08+0100, Thomas Wei=DFschuh wrote:
> > On 2023-12-04 21:50:14-0800, Luis Chamberlain wrote:
> > > On Mon, Dec 04, 2023 at 08:52:13AM +0100, Thomas Wei=DFschuh wrote:
> > > > Tested by booting and with the sysctl selftests on x86.
> > >=20
> > > Can I trouble you to rebase on sysctl-next?
> > >=20
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/=
?h=3Dsysctl-next
> >=20
> > Will do.
>=20
> The rebased series is now available at
> https://git.sr.ht/~t-8ch/linux b4/const-sysctl
>=20
> Nothing much has changed in contrast to v2.
> The only functional change so far is the initialization of
> ctl_table_header::type in init_header().
>=20
> I'll wait for Joels and maybe some more reviews before resending it.
>=20
> > [..]
>=20
> For the future I think it would make sense to combine the tree-wide const=
ification
> of the structs with the removal of the sentinel values.
I don't see how these two would fit. And this is why:
1. The "remove sentinel" stuff is almost done. With the sets going into
   6.7 we would only be missing everything under net/*. So you would not
   be able to combine them (except for the net stuff)
2. The motivation for the two sets is differnt. This would confuse
   rather than simplify the process.
3. In order to introduce the const stuff we would have to go through
   another round of "convincing" which can potentially derail the
   "remove sentinel" stuff.

I would *not* like to combine them. I think the const set can stand on
its own.
>=20
> This would reduce the impacts of the maintainers.
>=20
>=20
> Thomas

--=20

Joel Granados

--5z5snkykkq6vptla
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmVxqlwACgkQupfNUreW
QU8frQwAmVCgALk4OWR4ZO/s1n4rLY7ci247QjM9Bmg1WdksPWp70HkrU5eSmb9t
BiHrNBMb9edU00xHbC0553m/HaeOq1sERcubT2LXmjagnshZzR4JHPj4qWi2k20k
Bwnsd8n/ZMY33T7Vq97o3rW2W5aPMBiqeY/fdBPqG3ArlXUISGtonYFmGERiNhyu
eZ6JBtjl5+Q50CwH01HbRm0uFLNWrZA3tBoJssnFJt06AaoYAYK302UL2DirCCuu
fCLSIsiz3CngsVs+cJHLZaOWB5lXLPGoQjjGJ0Lvdy8Q5Xlgx/ckugTw9AzDN9B+
y7Q22g7TY+Eg8aspEvICKEIuQYo1fi0WmqgS63t+Ttvdw/VpeEId2p15eRz3PJGz
KY0oOKoS2Xy52uNhxsL6zGtMqKM/hL3WJXtNyOeshXQWY2qrsF+t5+OckxODOCgR
5FFILM1DVgj5zJM2b7LC308T+ULLhU7HllJ9oLG6QzWotSx+M0TcbVmmNneN1nI8
BhCGk6c+
=2W1o
-----END PGP SIGNATURE-----

--5z5snkykkq6vptla--