Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Thu, 7 Dec 2023 12:23:22 +0100
From:   Joel Granados <j.granados@samsung.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>,
        Kees Cook <keescook@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Iurii Zaikin <yzaikin@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-hardening@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables
Message-ID: <20231207112322.uac2my3u4aafnxl2@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="2b7bopsuuvobq6c5"
Content-Disposition: inline
In-Reply-To: <ZW+juEWLSTybbujk@bombadil.infradead.org>
CMS-TYPE: 201P
References: <20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net>
        <ZW66FhWx7W67Y9rP@bombadil.infradead.org>
        <b4b0b7ea-d8b3-4538-a5b9-87a23bbdac5f@t-8ch.de>
        <d50978d8-d4e7-4767-8ea7-5849f05d3be1@t-8ch.de>
        <CGME20231205222712eucas1p109566babf1072328184c818d1b6965b5@eucas1p1.samsung.com>
        <ZW+juEWLSTybbujk@bombadil.infradead.org>
Precedence: bulk

--2b7bopsuuvobq6c5
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 05, 2023 at 02:27:04PM -0800, Luis Chamberlain wrote:
> On Tue, Dec 05, 2023 at 06:16:53PM +0100, Thomas Wei=DFschuh wrote:
> > Hi Luis, Joel,
> >=20
> > On 2023-12-05 09:04:08+0100, Thomas Wei=DFschuh wrote:
> > > On 2023-12-04 21:50:14-0800, Luis Chamberlain wrote:
> > > > On Mon, Dec 04, 2023 at 08:52:13AM +0100, Thomas Wei=DFschuh wrote:
> > > > > Tested by booting and with the sysctl selftests on x86.
> > > >=20
> > > > Can I trouble you to rebase on sysctl-next?
> > > >=20
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/lo=
g/?h=3Dsysctl-next
> > >=20
> > > Will do.
> >=20
> > The rebased series is now available at
> > https://git.sr.ht/~t-8ch/linux b4/const-sysctl
>=20
> I've applied this to sysctl-next as this all looks very sensible to me,
> except one patch which I'll chime in on, but I'm merging it to
That is the "move sysctl type to ctl_table_header" right?

> sysctl-next now without a promise to get this in as I really would like
> this to soak in on linux-next for a bit even if it does not get merged
> in the next kernel release. Exposing it on linux-next will surely
> iron out run time issues fast.
+1 for soaking it :)

>=20
> > Nothing much has changed in contrast to v2.
> > The only functional change so far is the initialization of
> > ctl_table_header::type in init_header().
> >=20
> > I'll wait for Joels and maybe some more reviews before resending it.
>=20
> It all is very trivial stuff, except a few patches, but it all is making
> sense, so my ask is to address feedback this week and post next week
> a new set so we can have changes merged as-is for Linux in case this
> really doesn't break anything.
Any thoughts on the size of the tree-wide patches?

>=20
> For some reason I raccall seeing som hacky sysclts that shared and
> modified an entry somewhere but the exact sysctl phases me, and I just
> cannot recall.
Its probably in net/*. There is were they are really taking advantage of
ctl_table.

>=20
> > > [..]
> >=20
> > For the future I think it would make sense to combine the tree-wide con=
stification
> > of the structs with the removal of the sentinel values.
> >=20
> > This would reduce the impacts of the maintainers.
>=20
> Indeed.
>=20
>   Luis

--=20

Joel Granados

--2b7bopsuuvobq6c5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmVxqyoACgkQupfNUreW
QU9Mfgv/W62R2aUunsSdN2DFcIRXKePW0Oyyu2RfLLT5I7Utd/1PdHjuhIyyOAGS
/9vP1zfp6ZGhrl/NqZpIIZH3t1E8/zxURK178TDc/d5zC6LzOTu+r7PVgGq0wN9Q
PiiEebBCA5bdfrEO4baxAofR981s92b+EH/914TTzn4McmwPCLkn6+6HujiSakz5
HNz8wIGczjzsnYDrHSWV8DlAH87vs+Zxa8/T9hzBhWm+yb1f0o+XCHhLLmfACfop
q+NEQwlRK/0Tfx3Xug43D5fU6kvZqgm0vJxOhEU3fnZClS08IZj4oVyixBcCtQuK
FQDoy1wy9nBLtea4ENrWbJ6mIhOB2a4N8mq3Nn31+OmcSqw+fr6uEbYGi2hmqcZy
rhkQU4qJL6BD387CrLxiglHbSVJ5SKEDXdZ99ukoXkQi60/zcOdr6ZnxA1NAkzLE
vtyQIcDYBIogDImnnNqSMJo5ETxVM1GxisxECDwK4izJrE0MznDZnPnyDAK+CbAl
6YZXT1C0
=8Yi9
-----END PGP SIGNATURE-----

--2b7bopsuuvobq6c5--