Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Javier Carrasco <javier.carrasco@wolfvision.net>
Date:   Thu, 07 Dec 2023 12:51:07 +0100
Subject: [PATCH 2/4] usb: typec: tipd: add function to request firmware
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20231207-tps6598x_update-v1-2-dc21b5301d91@wolfvision.net>
References: <20231207-tps6598x_update-v1-0-dc21b5301d91@wolfvision.net>
In-Reply-To: <20231207-tps6598x_update-v1-0-dc21b5301d91@wolfvision.net>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Javier Carrasco <javier.carrasco@wolfvision.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blVZejFVTDRqenFmZDUrRVBmSXpLVXJiMmM1MFE2ajZtWWlHTUpScGV2K0Vn?=
 =?utf-8?B?VFVzWUppcHJGMm9nQitQSTlka05Fakc2cU85cnpyTnpLRFNiSG91SFVPV2JI?=
 =?utf-8?B?bFlGa1hTeHlyc21yUFBkUjVlZTRtanl6OVMyRjlMbFpnaGMzalFTT3dPTjBJ?=
 =?utf-8?B?aDdMa25jMzZRUExsbTBCQkYrekVROTJJYVhvNnM3NjNPdDNyRFpqVDRPc3pn?=
 =?utf-8?B?WjJiaHhQMkRYUDhsMkJsYnpsZy9LQ0hJbTV6bDV2MXRIYkxSZXVsRUwyRHpJ?=
 =?utf-8?B?MzNROEl5VndBQ2djQWRmTk0zVG15bmxta0h1N1Q3M2dZbFhFVFZ2K3A1U3B6?=
 =?utf-8?B?UjQ3WlM2NUorZFFvMlZGMnZkOHNYUk00NGFvd2FvbVlHZlo4VmpoM0pZc2FP?=
 =?utf-8?B?RmU4T2Y2QkwwWlhub3RnbUFHZFhVUXpSUGIxZHVhUEhzaDdPUldRWlRBZkZM?=
 =?utf-8?B?dlJydEwvMEk5NjR2KzQyb2J4OTdNb25adForbWh4REpYM0o3RDRaUkFnWWJa?=
 =?utf-8?B?c0MzNEFRRE5DbW9xYmthd01VWmU5K3RYa2RQR0V3Tk1wK2JkbUdYSlJVeE00?=
 =?utf-8?B?dXIzclYzdkNPWUlhTzJPNWV4bjlaSHJ2cW1QS3ZnYWRVWU9BcC9lWlpqZVBC?=
 =?utf-8?B?NHhvYy9zTWNQNFREQnZJeVBrSzh4Q2VTTmE0dHdNY0pNQUdSaSs4aE84Z3Nx?=
 =?utf-8?B?bnBxN1hjRENjZFR6cGJ3S0tCRzZYVHdNNWNsaDQyazBhOTVGWGZKbHRrNjha?=
 =?utf-8?B?Q1lId2VDUUUyM0llaXA4b3VKd3l3Z1VvZTViRkZhR0hYUDd4b09LbmxNTFhQ?=
 =?utf-8?B?S0xtQ2Zodk0vaUpGM2FOY0x2MHpPemcwT2psTE1hSk1uSWZsS2oxZGphRmJU?=
 =?utf-8?B?MGRJQWNuWkw4L21VdlVnNjVZOG9EMEFVQ2VUcjhEd1l5VHNHNVlyaHZWdE9I?=
 =?utf-8?B?RFV1bWdJVlk5Q1ZPVmZ1UWZNMDc2citTUkZKc09HN0FwNmdIQmR3Nzh5dVZM?=
 =?utf-8?B?aGdpelhrazZLZG5JamtNbjZncWhPQWkvREhDaHVDR2RwU2dWdmJJcWlDWDVo?=
 =?utf-8?B?RXllS01rZ1RMSDJlNXJRQ21hMkJwb1BnVkxDR1hxdnVYRTYvZll5K3d5ZE9k?=
 =?utf-8?B?cGFuZWhmSVg4SXhsbTYrRjhuR3RvYmpWNGp0Q2lqOWFKeVZiT1k4Y1Jydklj?=
 =?utf-8?B?UE1tK1J0azZYMHFjVFN3WWZ0Y2pGMEdJUG80MVJxbFVXRlh1eC80VE1HVi9Q?=
 =?utf-8?B?Qk5mWUozcEdkeW1KSFNsVlNpM09Pd0MvY1dFY2dtVSttL0xrUklGMWQ5WEY1?=
 =?utf-8?B?V2lmWUlzTkpEWUhhZFFqd005NUZIRmZhUi9OVlhGbDFtdm5PNy9uMWVFUFdV?=
 =?utf-8?B?TlcvSTNjWXljMTRwNVhUaEREYlJxVG52VUN3S0xKZ1F4VWRPZVlrVm9ObG5m?=
 =?utf-8?B?NXl6MTl5VlhEWnFTOFpiZjREQWRVZWQ1dGx5QU8zS0tmMUtSYXgyWTVERFRT?=
 =?utf-8?B?blV5NHhhc21rUUp4ZDZPd1dmb1FvQnBYSVlvNXdnd0dPU3FlbFhFR3Z3Nytw?=
 =?utf-8?B?a1czK3dVUHdSNHkwL21iRFdQamRGZ0FUMGQ0NGtPRVVBaGV4anNSOWlKZURo?=
 =?utf-8?B?a3lab2dyVHpjcDNadVZJQUJBMGJQdDlhYytiRXdVdDdiVXBacFpHRWdlY1pR?=
 =?utf-8?B?c2UvY21RTjRWMXRuNFJUTXg0SEJrV3YzMGFTS2ttZGhiL0VvOXo5dkoxa092?=
 =?utf-8?B?Q2VyNUlNZ3h5NnRvSEFrQ25KdGF2M1NuZmF4MTBsWGdVS3JPQktKOXlQVFNq?=
 =?utf-8?B?ZFV4NGljd3BXSVBZTzlKQWZaUmdITlk3ZWdTd3pVYVRwRFg1V1g1Vjd4R2Mx?=
 =?utf-8?B?T2wydkpqdmMxWjV5a3ZjaFhLN2h5ZXRyNGwyNmFCUnozejlQZkFQS2NsalJl?=
 =?utf-8?B?Ym5meWVXYktJSXluRmpNdzNjVG5oaGFaWmRqZEJxOE81SmdaL0F2NUY2RmQv?=
 =?utf-8?B?S2V1SC9rbzJDSlI3ZlhNSkg0dXNIWloyeE40eG0rSGVQang1K1JMTzhuYjhq?=
 =?utf-8?B?bG9zVVFjbXcvMlRheGdUYXIyemRFSTE5ellXZlhGQUdNMnV4OVArV3JwYWU2?=
 =?utf-8?B?MkZ2TVNDRTArdE9XQlhMUVV6ZXQ5Vk5obXVBYUQ0QkVRNForcGhiNU8xb21l?=
 =?utf-8?Q?aptzM4pqBtRTEiiWyJX4KQM=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: b890cb81-ad2a-4f87-8d18-08dbf71ad02b
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 11:51:13.7891
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HTCWi00nD4a625C3drVdZs+QXipLfrXZG8Jqk0hO6sQMiHj2PtMK2eekLddUGwWHSwW3iolWzy1jNv+xPxb0ZtowvgucvxWFrDx6rfJiUmI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8054
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 07 Dec 2023 03:51:40 -0800 (PST)

The firmware request process is device agnostic and can be used for
other parts.

A probe deferring mechanism has been added in order to account for cases
where the file system where the firmware resides is still not available
when the probe function is triggered and no firmware is found.

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
 drivers/usb/typec/tipd/core.c | 36 +++++++++++++++++++++++++++---------
 1 file changed, 27 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index f0c4cd571a37..165a1391dc72 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -873,6 +873,31 @@ tps6598x_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
 	return 0;
 }
 
+static int tps_request_firmware(struct tps6598x *tps, const struct firmware **fw)
+{
+	const char *firmware_name;
+	int ret;
+
+	ret = device_property_read_string(tps->dev, "firmware-name",
+					  &firmware_name);
+	if (ret)
+		return ret;
+
+	ret = request_firmware(fw, firmware_name, tps->dev);
+	if (ret) {
+		dev_err(tps->dev, "failed to retrieve \"%s\"\n", firmware_name);
+		/* probe deferring in case the file system is not ready */
+		return (ret == -ENOENT) ? -EPROBE_DEFER : ret;
+	}
+
+	if ((*fw)->size == 0) {
+		release_firmware(*fw);
+		ret = -EINVAL;
+	}
+
+	return ret;
+}
+
 static int
 tps25750_write_firmware(struct tps6598x *tps,
 			u8 bpms_addr, const u8 *data, size_t len)
@@ -961,16 +986,9 @@ static int tps25750_start_patch_burst_mode(struct tps6598x *tps)
 	if (ret)
 		return ret;
 
-	ret = request_firmware(&fw, firmware_name, tps->dev);
-	if (ret) {
-		dev_err(tps->dev, "failed to retrieve \"%s\"\n", firmware_name);
+	ret = tps_request_firmware(tps, &fw);
+	if (ret)
 		return ret;
-	}
-
-	if (fw->size == 0) {
-		ret = -EINVAL;
-		goto release_fw;
-	}
 
 	ret = of_property_match_string(np, "reg-names", "patch-address");
 	if (ret < 0) {

-- 
2.39.2