Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Javier Carrasco <javier.carrasco@wolfvision.net>
Date:   Thu, 07 Dec 2023 12:51:08 +0100
Subject: [PATCH 3/4] usb: typec: tipd: declare in_data in as const in
 exec_cmd functions
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20231207-tps6598x_update-v1-3-dc21b5301d91@wolfvision.net>
References: <20231207-tps6598x_update-v1-0-dc21b5301d91@wolfvision.net>
In-Reply-To: <20231207-tps6598x_update-v1-0-dc21b5301d91@wolfvision.net>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Javier Carrasco <javier.carrasco@wolfvision.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzV4UDZXMTQvaC9pY3laakRZUFRRVDk4QTJLMnpZQ09uMS9NYWhoejUxVk5C?=
 =?utf-8?B?UGhDbnRQUmU5RlordDhDTjlWcTR2T2RMc0lRS3c0WXpiVlhibTR1STl1elBP?=
 =?utf-8?B?ayszN1hOclFjWWFPY2JZRWRRQTlQZm9NcGw2b0o4M3N0U2ROOFhzVEp4YjM3?=
 =?utf-8?B?QUVUdWhCaXhpZVZnYjRiMEVyeFluWlhiQTA3UXkrQmRHYzhVOGpwN0hPdzBW?=
 =?utf-8?B?QU5qQnloOFhtRkV2Y25mV2VvYmt0M0pkNzNhRFR2V0xiM3BQT1N5TWxIczJi?=
 =?utf-8?B?ZHdXNVRQZi9qS3Z4OG9UWGN6ZGoyeDRBYngrcmxLbzQ4T2pzMlJNSEVnc2dN?=
 =?utf-8?B?Mk1OcjBQQkh2Rzd2M2F3SkdZaUREemRwdjFQc3Q3WWwwM2g2TmJhRldIc3Vz?=
 =?utf-8?B?NWhUV0ZnUmw2cCs5c2VORUc5QU1YTURvbXlqSXRreWZkbkY1ajd4Y0pFRFdl?=
 =?utf-8?B?L0JGcUR6UlJsSmZZZS82VDZXWEFCaUZPMXpOb1lLc0lDTXk3L09JQ1JhVVBE?=
 =?utf-8?B?dVR2bFNMSERZaXdJTnVzMjNPeVEwd3ZQRkpMNEN5RytmZks2YnlCWlNsdnFJ?=
 =?utf-8?B?NDVjbUx4Y1NaNVdTTkRmWEV5Z0ZZUXB5SW8rMzZXWFlEejFuWXNKemVlaTdo?=
 =?utf-8?B?RE8wM2FpcG1pSDRJOUFMTTMrb0dGSEJldXN4eWcwbWo0WHlxSEpVVEJ6dGMz?=
 =?utf-8?B?N0xlUVoxaFdBYnF5K0ZxUFNFSyt4bWdYMi9GRFFLNFprdVl4OXQ3cVorMnZq?=
 =?utf-8?B?TUU3RUlkYXBDd1NreVpFWXVvL1NIejIyMnhuUkoreXZqb1dYSXUxWThlR0dl?=
 =?utf-8?B?OGl0dlF6eVpyR2hFQ1Q2K0VMcVlkbnhNWVI3WHA1QzVmTnpvYWhpZUpBenlX?=
 =?utf-8?B?Ykl4ZTdFc21Ja2M5RDhFQ1RqaFc2T1UxMzgwcmZXMGRoMkhwY1pyUnE3ajF0?=
 =?utf-8?B?L2ZneGxyRm5FSGVjZWF6RHdMZ2c3SUl3dHJoOHNOYVY2NGwzS1kxb3ZtWTJk?=
 =?utf-8?B?RVcyY1hwbmdQaG9sNDI3MGtob3JOak1EQXFualVTc2JmRHBjS3VBY0p4L0ow?=
 =?utf-8?B?dXhuZ3JKU2pieGRya2pUN095UE5zSnZLQTNoYy9GK1JBWUU5K2tkdmlWQjFM?=
 =?utf-8?B?U2hZWTVQdkhPblpHYUdNYWlCWW1oMEppSGdmN3NYZnNFNXZWYjNVSy80Mi9n?=
 =?utf-8?B?c0piNnpyaWhJUk9iaHNORUcrbUphekhWNUx2NzlXcmlYMWNWNUpmbERDaExw?=
 =?utf-8?B?QlVxZ05FQ0F4Z3ZObFJLRFBhVktpc0NzQlhOWVExWUtpeXVtb0V4MlhLeUhz?=
 =?utf-8?B?eEpSNjJKRmZTVmVObklOVUxjRVVHQ2IzM2NpTDhvQlgvci9rOXdSbUU2RU9N?=
 =?utf-8?B?NExsaEcxeVZFZW9UNStSMEQrNkpNamZGVlZBcEw5dmxadlRBTkNTemczZ3FN?=
 =?utf-8?B?TkhjTzM4UlBHWlpXMXZ1UFQvdkJEdk1kSFdxSno2QnJ2bURHc0VrMFo2S2V3?=
 =?utf-8?B?cVVHRE1NdE1OT3ZEbWRvMi9BVGdTbGFVYkJoS1pERU1KaWtvQnljZWpvYnFK?=
 =?utf-8?B?ZEpmV09qS1lMU3FNZWNTVVhDRURGN2hIdGpKNTQ5d28yeml3cEc5N2h5OFVV?=
 =?utf-8?B?c29PYzJuN2huNk9KMG5IV3B4d0Q4cnlDelZhbEZ2KzdCQjBjdDRFTDV5N1dT?=
 =?utf-8?B?eTdhM1FML1crSDBtcjIrRFhJelRkSFdFYlk2dE1WSFlESXo2dFF1ZXA0SXpn?=
 =?utf-8?B?YnRtdEYzUXF6bUFsbEhiRjEwZUZRUkE5ZWJDMnpVWDhSaDNLQW94S2pBYk1Z?=
 =?utf-8?B?aXhaRGJGQmxZR2tCK1ZGbDJFZzBDU24xRlowMk82Ym9Wakk1NHhueE9HZWJ6?=
 =?utf-8?B?RzVZelk3Zys1Mm5zVUlZazVmQXkrcVlPTkViRXBuM2Q5NzZjakJ6WFNpU0Nu?=
 =?utf-8?B?YndLc2VHaUxFbE02UnZoc0pLUGFjVjlHUkNGWXgweTBjYXd2UHdkcXJkazh5?=
 =?utf-8?B?Q1hqTEs1Qk1nM1BFbGNiZHAvVHlzVDFTZjNxSUJQWlZJTTJKeFFOREgxUUls?=
 =?utf-8?B?M3lydEdGb3JMbGd0UXVXcEVLVUtPVGl3Mkl4clMzY2psQlNOVjJPVXVRQkdh?=
 =?utf-8?B?aWhyL0o1bnIyeUtkWEN6T0N2ZXBQR09tVjZZMkZkKzl3c3lGNHJGTGpsQUhO?=
 =?utf-8?Q?SGr01Nvfdu/8ceWMh2l8WQo=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 11f2c7ea-5d21-4527-75fc-08dbf71ad075
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 11:51:14.2591
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CpetL/K0PjQMRcgRwfRIqXkiRY7NvVzsiee9iNsmikvlenkpzmW/ggJxFVfgMAujR71M+gsomYXMMj19slePBiJpAYNrFR9RYO/ng/5Faug=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8054
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 07 Dec 2023 03:51:50 -0800 (PST)

The input data passed to execute commands with tps6598x_exec_cmd()
is not supposed to be modified by the function. Moreover, this data is
passed to tps6598x_exec_cmd_tmo() and finally to tps6598x_block_write(),
which expects a const pointer.

The current implementation does not produce any bugs, but it discards
const qualifiers from the pointers passed as arguments. This leads to
compile issues if 'discarded-qualifiers' is active and a const pointer
is passed to the function, which is the case if data from a firmware
structure is passed to execute update commands. Adding the const
modifier to in_data prevents such issues and provides code consistency.

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
 drivers/usb/typec/tipd/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 165a1391dc72..cd5214c9799e 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -330,7 +330,7 @@ static void tps6598x_disconnect(struct tps6598x *tps, u32 status)
 }
 
 static int tps6598x_exec_cmd_tmo(struct tps6598x *tps, const char *cmd,
-			     size_t in_len, u8 *in_data,
+			     size_t in_len, const u8 *in_data,
 			     size_t out_len, u8 *out_data,
 			     u32 cmd_timeout_ms, u32 res_delay_ms)
 {
@@ -396,7 +396,7 @@ static int tps6598x_exec_cmd_tmo(struct tps6598x *tps, const char *cmd,
 }
 
 static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd,
-			     size_t in_len, u8 *in_data,
+			     size_t in_len, const u8 *in_data,
 			     size_t out_len, u8 *out_data)
 {
 	return tps6598x_exec_cmd_tmo(tps, cmd, in_len, in_data,

-- 
2.39.2