Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
MIME-Version: 1.0
References: <20231206123828.587065-1-arnd@kernel.org> <ZXGySCtdsxW4qCel@kuha.fi.intel.com>
 <CAA8EJprV3O24V0+MnPK1OdQZQ_7F2aMfN1Um13eH9ux4J+ucMw@mail.gmail.com>
 <ZXGzJlv9C3Z9lMeI@kuha.fi.intel.com> <c1df6dc4-ad3f-41ba-b024-1b432dac7af1@app.fastmail.com>
 <CAA8EJpp+ikpFZ1BL4PZJG_kK3n_u3mTTGZjd8A+=20gPm_SOyA@mail.gmail.com> <a6232a15-a7e6-47fd-ad4b-07319932a6f8@app.fastmail.com>
In-Reply-To: <a6232a15-a7e6-47fd-ad4b-07319932a6f8@app.fastmail.com>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Thu, 7 Dec 2023 14:20:45 +0200
Message-ID: <CAA8EJpqo7Ty-kyFs-94ddUNWNoDe6efghAfHbVYjQoYAP-PPxw@mail.gmail.com>
Subject: Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Arnd Bergmann <arnd@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 7 Dec 2023 at 14:17, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Dec 7, 2023, at 13:12, Dmitry Baryshkov wrote:
> > On Thu, 7 Dec 2023 at 14:00, Arnd Bergmann <arnd@arndb.de> wrote:
> >>
> >> On Thu, Dec 7, 2023, at 12:57, Heikki Krogerus wrote:
> >> > On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote:
> >>
> >> > Okay, so this probable should also be
> >> >
> >> >         select DRM_AUX_BRIDGE if DRM_BRIDGE and OF
> >> >
> >> > No?
> >>
> >> I think that fails if CONFIG_OF is disabled and
> >> CONFIG_DRM_AUX_BRIDGE, since drm_aux_bridge_register()
> >> will still be called from a built-in driver in that
> >> case but can't be linked against.
> >
> > If DRM_AUX_BRIDGE is not enabled, then the stubs from
> > include/drm/bridge/aux-bridge will be used instead.
>
> Sorry, I meant to write CONFIG_DRM_AUX_BRIDGE=m here.

Like having NB7VPQ904M=y, OF=n and DRM_AUX_BRIDGE=m? And the select
will not work, since the condition is not fulfilled. Good question.

-- 
With best wishes
Dmitry