Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1619713rdb; Thu, 7 Dec 2023 04:36:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBgH9NhjPTmuWPQ2CWMqGvMdWPmttGcUl0CVF42vIacB1Dn6CEao9QcXkENc/Ly3AQ4kls X-Received: by 2002:a17:90b:38d1:b0:285:d550:994b with SMTP id nn17-20020a17090b38d100b00285d550994bmr2174922pjb.40.1701952569457; Thu, 07 Dec 2023 04:36:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701952569; cv=none; d=google.com; s=arc-20160816; b=0pr90trHrzdYU4CO8JCWONfo0i2aXM+rStIwy2ZgG5Lq1ritz56GPvgpeqTmiHimFG FSL/xuSknya7mW3F53v+T37+jgEmzXVb8nCSAUPqnm00gxYHwyjnjFNGPzzgKFLvuugH XgWMyJ5j0pAVOsLAb26Y27NAhGa2yNj8ynZzkhY7wbT7D7oKVIuf/6Piwn/+mlxxdrzG RIlXgg4xQQ5kgAgwrjNh45XF0S/vKgwwIIhBMZqFa9NPloejZmWW9F+5xSKJLoY1TsBq D9oAF2JbfG0mmUSQ0a+nTooR57sMnNFasM/4cowHvb2Rk/i8nnLmtkUm+b/E4mCsWw8m 2hkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=c24VBQUZtyko9D18KDrXZ/lPA7XiA191TK/AoJjwCCw=; fh=7XrOiBWoGeKlr/r5RTT1Xk8Jnvs3pwWIU6QbTt61/+E=; b=zi0/AVqe75g8mf35pe5WCiqTf/TXl1RGH6U8TIQjUfcsfEDCN7qY2DLBZjec4fRU0D klPqJLSF+ygwwrg0BGbtzkoQ2XRObQ9vtLZcBIObAKtpaJxEAt6EVxaQtQVlujPEOOrw ewiuALYPbP+S9vgFdQrUrpgx2tYJUrtn8Msjxvt87FRpAoG6tfOKQKONPvLp2V/bacnI por/OfyWmn1+BSXNzNYmJCdMy3NVTHLUkeyAQYIaJzvAIdd0d0AxLMB2ncrXSXbPrJWy F45RDcS8qmtkAfg+y6SLRbZAqBiThMSyxCjsPazNFDhnk3l9/gHv+tI3RFKMilTvtiW2 hNDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LGDczdMO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id o12-20020a17090a744c00b00286f67f01b4si1020194pjk.184.2023.12.07.04.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 04:36:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LGDczdMO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EB46C80689EC; Thu, 7 Dec 2023 04:36:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232604AbjLGMfp (ORCPT + 99 others); Thu, 7 Dec 2023 07:35:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232642AbjLGMfh (ORCPT ); Thu, 7 Dec 2023 07:35:37 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBBA510EC; Thu, 7 Dec 2023 04:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701952533; x=1733488533; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AxuJODfeSyZXtb5X5FLkqlPIc2Wt4J6QcOdZzYwKh/Y=; b=LGDczdMOyHE4VcOk81Aeg7E3So6POyeAatZJ3xZ2V/HiPJNS+jRubBS4 QqXPRIELVHGJruhv0IYD+muPo275WUR/x2cQL+FrwIOYUEzRPyJjiB2Gy IVDbvm6+KuV/jnPBuZnZfbXqtKajeA2T0z6PmziL3buCq5zm6ai0rZyHv V25LA0oLy2tw8f6NaaFZgvIT2m4VW/oVqXSqdP3oRsJK2+w+W6EHvpzki eHquABXyDQWsS8+UcdFJU+ZHfxU9kq5hWZSiiDyEWNAz7ympX/PhzMNhR 3sxF1UpraWQ1bXOyik8vM5HB4MjpPpwzbNucczDaXRWLAqRWZ3pTJl65p g==; X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="460711669" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="460711669" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 04:35:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="747950280" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="747950280" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 04:35:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rBDbA-00000002bBU-3Czz; Thu, 07 Dec 2023 14:35:24 +0200 Date: Thu, 7 Dec 2023 14:35:24 +0200 From: Andy Shevchenko To: Lino Sanfilippo Cc: Christoph Niedermaier , Lukas Wunner , Rasmus Villemoes , Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , "brenda.streiff@ni.com" , Crescent CY Hsieh , Tomas Paukrt Subject: Re: [PATCH 1/2] dt-bindings: serial: rs485: add rs485-mux-gpios binding Message-ID: References: <20231120151056.148450-1-linux@rasmusvillemoes.dk> <20231120151056.148450-2-linux@rasmusvillemoes.dk> <20231122145344.GA18949@wunner.de> <3b8548b1-b8a9-0c9e-4040-5cfda06a85c6@gmx.de> <5c140498-69e3-4187-8703-db0c41e7ca89@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c140498-69e3-4187-8703-db0c41e7ca89@gmx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 04:36:03 -0800 (PST) On Wed, Dec 06, 2023 at 04:42:53PM +0100, Lino Sanfilippo wrote: > On 27.11.23 13:14, Christoph Niedermaier wrote: > > From: Lino Sanfilippo [mailto:LinoSanfilippo@gmx.de] > > Sent: Sunday, November 26, 2023 12:40 AM ... > > RS-485 (2-wire NO RX_DURING_TX): rs485->flags = SER_RS485_ENABLED|SER_RS485_MODE_HALF_DUPLEX > > RS-485 (2-wire RX_DURING_TX): rs485->flags = SER_RS485_ENABLED|SER_RS485_MODE_HALF_DUPLEX|SER_RS485_RX_DURING_TX > > I think we can omit the SER_RS485_MODE_HALF_DUPLEX flag if we assume that > a missing SER_RS485_MODE_FULL_DUPLEX means half duplex (i.e. controlling > the RTS line). You should be very careful on these assumptions, i.e. one must to check _all_ existing user space tools (at least that are in use / supplied by main distros) on how they behave. -- With Best Regards, Andy Shevchenko