Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1624532rdb; Thu, 7 Dec 2023 04:45:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLRjPfgt5cOyBWkseQqHw6jps+qzKKy3aexONTfrE/vkmqDHdbAgkDA3wzip/4aEXsV+Bd X-Received: by 2002:a17:903:2642:b0:1d0:6ffd:f214 with SMTP id je2-20020a170903264200b001d06ffdf214mr2017411plb.106.1701953113364; Thu, 07 Dec 2023 04:45:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701953113; cv=none; d=google.com; s=arc-20160816; b=mPrdlQuYgBGK6+684pPr16XsqZaHAkrbjaTMt8pkeF3AVGLeKltIMlw1xtN/ZBtytW TuYQ1Z0Ctipm855fxxc2jfvspiDHQNHfj1SnGvbnike33nfAB7j0xFXOgdIBEe1k6fzE o5/GI12gKJ+v7OYh1MxF6qt0dDu2pEvSpw4GUq5e9dvxE5XgXrwcIlb8mx0BgCJoYHGa K5LULVGU/f1On1SRolOnOKQQ/8yy+5wusweCvcRceZuKYXSO4jfkY2aVn9+3StjJelZy A4BkeFp4us7m+pU6UmXSCwTe7mSnRyxMzseLkUjZYQNNZBGqAdBpInWyUDPnPeTbRUCb 4TVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=ej9GOwl0loZy9Li/VUuRdIF0VV8D5BeLVYub23X/8Dk=; fh=Orli4O+NYIOGlLxfekHbPePR8MMAxvALquLR5AegOC0=; b=WafyOyxQj1cE+rVNxaLdmKG544CsXE3hLpG9MUwA6EsKL9yvFGljrpoK59RujOcuOI pvz5FOCCqAAmj/UhGXpjtzETDSbVQE/g2NoOSTY5ZvcHiVBNc0PN3NXZajNXGFax5HST Gfy62b/E6ipRCvA2G61SdmCTvZL/noy83Sl4EZ1L5k6fxkSNRQ5BCJhPes211iOkDF1e rxeBr1/kbO20q6V4TFxqcPTXa8bVycfa6JDzLaayyyCtYZSON0QGOxl57RvfA2t4RKV9 HjkJhDjUZ1xbhYJAM+L+vMHMJnM76kzyH3aKV5dTTMPzTL6lkV6WetgJA7E+Sqp7bJva S7+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id q9-20020a170902b10900b001d094766f1fsi1035247plr.404.2023.12.07.04.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 04:45:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 67E6B809F3B5; Thu, 7 Dec 2023 04:45:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbjLGMoh (ORCPT + 99 others); Thu, 7 Dec 2023 07:44:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232648AbjLGMof (ORCPT ); Thu, 7 Dec 2023 07:44:35 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BACE10DD for ; Thu, 7 Dec 2023 04:44:40 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SmDVt5l8Cz4xS0; Thu, 7 Dec 2023 23:44:38 +1100 (AEDT) From: Michael Ellerman To: Nicholas Piggin , Christophe Leroy , Mahesh J Salgaonkar , Palmer Dabbelt , Arnd Bergmann , Andrew Morton , Kees Cook , Nathan Lynch Cc: lkft-triage@lists.linaro.org, Benjamin Gray , Arnd Bergmann , Nathan Chancellor , Anders Roxell , Dan Carpenter , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clang-built-linux , regressions@lists.linux.dev, Linux Kernel Functional Testing In-Reply-To: <20231127-rtas-pci-rw-config-v1-1-385d29ace3df@linux.ibm.com> References: <20231127-rtas-pci-rw-config-v1-1-385d29ace3df@linux.ibm.com> Subject: Re: [PATCH] powerpc/rtas_pci: rename and properly expose config access APIs Message-Id: <170195271166.2310221.13174919656650959020.b4-ty@ellerman.id.au> Date: Thu, 07 Dec 2023 23:38:31 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 07 Dec 2023 04:45:06 -0800 (PST) On Mon, 27 Nov 2023 18:40:09 -0600, Nathan Lynch wrote: > The rtas_read_config() and rtas_write_config() functions in > kernel/rtas_pci.c have external linkage and two users in arch/powerpc: > the rtas_pci code itself and the pseries platform's "enhanced error > handling" (EEH) support code. > > The prototypes for these functions in asm/ppc-pci.h have until now > been guarded by CONFIG_EEH since the only external caller is the > pseries EEH code. However, this presumably has always generated > warnings when built with !CONFIG_EEH and -Wmissing-prototypes: > > [...] Applied to powerpc/next. [1/1] powerpc/rtas_pci: rename and properly expose config access APIs https://git.kernel.org/powerpc/c/9be4feb768b86c25da336a6c0f3e3caefd16f1e4 cheers