Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1669541rdb; Thu, 7 Dec 2023 05:59:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGVALNj3hAISIv+DdyhfBrVNzI3jNicnCVTIUEq17NRQUKP5RfGSZKkvFK1BGAz/E4iD/MN X-Received: by 2002:a17:90b:4cc1:b0:286:6cc1:28b with SMTP id nd1-20020a17090b4cc100b002866cc1028bmr2332341pjb.86.1701957575031; Thu, 07 Dec 2023 05:59:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701957575; cv=none; d=google.com; s=arc-20160816; b=KvtQcJBDOpAYEQ9ypZee/ziqUU2e+rx2HeWzWG8OefKQRIZ+ZwfgMrpa/BDsENrAAS NeQ0GQZsWeUNwvu205bAOiezERmPwFa68zcR3XJIZAduDz1B0tJAs0x5LEyZIwJaCDaY 1JFmHHYwwYADOSIyWppzNjYeJd0CXrZeYDy+s9gDqpaspIMdkEQi8SJ8mo6sDub8Y5n9 hL2i6niHT+vt1A84/1KeVecEYJ7zS9ezEtYD4ZRLq7P7uz5LxPjqDAXyqMJOmm91ae1b JturfO8fXrWWmQ6Tmm9836wL+VCriFoT+nUeg261Je3idj8EViCwmLVfIOvdHstTwWHi VNUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=7VhlyBWvF7AIoVEFkeguiWcyevvA3s/p0d2qIlxEjZs=; fh=re4mzXpxleuoJ0JZxSIjVHsGlUgBWHsPHz3knSa7984=; b=vMU+Li/RZp+DCBzqA8eEZSkS/qwlRU7NI7Mns2//0XNhX95SRjluCbACxLbZBOpCcD 0f5Uw3So6SJPH2AfItjC0tffwx1utVdi9+TkTEX6Loq2CQwpyVdDX/nbt4zOjwUxHqTR 7n22Uli5yATJsW5If8FRL4wZIa2LdqEDEbZbPr9n5VUQjzaa8V+dIKnBqA1fatWooAb6 P4/yj3kjt3HagkiAn91DVaYyMwy8LzsoAQtMMqTfhBHnW6pbV5eJg1ZfuXQovfmogKTn KeaIZIW2YYmPrqmb6GlrA9jv/i77a7rwYTyb7ABR8srz3EKCR5sdu6sAWYndewrdHZk+ 0bsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Kguz4/fu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id f2-20020a17090a664200b002869b531c26si1175133pjm.96.2023.12.07.05.59.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 05:59:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Kguz4/fu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8DB788034643; Thu, 7 Dec 2023 05:59:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232900AbjLGN7O (ORCPT + 99 others); Thu, 7 Dec 2023 08:59:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232739AbjLGN7N (ORCPT ); Thu, 7 Dec 2023 08:59:13 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F589D5E for ; Thu, 7 Dec 2023 05:59:19 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a1f37fd4b53so50550166b.1 for ; Thu, 07 Dec 2023 05:59:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701957557; x=1702562357; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7VhlyBWvF7AIoVEFkeguiWcyevvA3s/p0d2qIlxEjZs=; b=Kguz4/fuc6LUoJRsR6A3tv/BQlQXkU3J34ehskL29d5wqT2wK/zYLuL6nDiF/wcwxW S3irIOLTOB0V94bpPP1/aLPIxQGKjaZfm+p6PefzIcSpnKtgSeQPg8zV8MCivCyxArKq B0Ej81Tq9FaU0ybwa2zb6ntpM7TjkaA6kZjprre/MEKsUIcen+PVFLRDkjUhSI8S37n1 h4gndGLMGa03XafU+2HlQF5s2+12pIwFqLsFPt+SYYrRYQTUCZ3eHjkKMv9SnqA94vK/ 0E8kZkxvezbCSio1GuLc3y2VASq6dOWRLUjMzSjNH9W2Q+EtDQoPTHohUssp/Ej5ZtPm 2wmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701957557; x=1702562357; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7VhlyBWvF7AIoVEFkeguiWcyevvA3s/p0d2qIlxEjZs=; b=EKbZnIEWnbyhwRbwht0ZJWivkIuqtP2YR8Wu8+INGrjDl2TLI9WGTh2fMFSVN84Guf WTbyFmcte3L2qH1CZSxNu4YBlFbkgin4LHQzZyhOO0s2reUgkTo4n/K/vBYZ6REHXy0s E+PR5upv9oIOAqEcHPI+WOrEbWpKMdo+b2+3IjmemkfN8MlRtHT1lAFHszLH9oEzlInX 6cYseA37NRrbf/MDioVMw8BlsMbOivw5JEY3J8k7Ak8XvkA9tv+NCmlhk+7jKFOA0a9G cqDBoivqytPOINn4sk6gISdLUKie0a2rO/YyQ3YXjaPshDEGY7jCNevskM79iLF7v6T7 ogwQ== X-Gm-Message-State: AOJu0YyyNEBLAZgOKvAPf1XpBJ0xzFY3aEMnnlcNmCh6pag+NVr/E7DW pgegY1Kv2p9HLjkUNXxCIvax+A== X-Received: by 2002:a17:906:54:b0:9dc:2291:d384 with SMTP id 20-20020a170906005400b009dc2291d384mr1453346ejg.22.1701957557563; Thu, 07 Dec 2023 05:59:17 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id l26-20020a170906a41a00b00a1da2c9b06asm862918ejz.42.2023.12.07.05.59.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Dec 2023 05:59:17 -0800 (PST) Message-ID: Date: Thu, 7 Dec 2023 14:59:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example Content-Language: en-US To: Sakari Ailus Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Ripard , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231205084835.15871-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 07 Dec 2023 05:59:31 -0800 (PST) On 05/12/2023 12:01, Sakari Ailus wrote: > Hi Krzysztof, > > Thanks for the patch. > > On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote: >> Bindings and Linux driver require two link frequencies, so correct the >> example: >> >> ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short >> >> Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas") >> Signed-off-by: Krzysztof Kozlowski >> --- >> Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml >> index 57f5e48fd8e0..bd1a55d767e7 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml >> @@ -126,7 +126,7 @@ examples: >> wcam_out: endpoint { >> remote-endpoint = <&mipi_in_wcam>; >> data-lanes = <1 2 3 4>; >> - link-frequencies = /bits/ 64 <360000000>; >> + link-frequencies = /bits/ 64 <360000000 180000000>; > > There indeed seems to be a problem with the example as far as the bindings > are concerned but the primary issue seems to be in the bindings. Both of > these frequencies have significance from driver point of view only while > the device itself supports a (wider) range. > > How about removing maxItems and items from the bindings instead? Yeah, it makes sense. Best regards, Krzysztof