Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Thu, 7 Dec 2023 15:09:03 +0100
From:   Joel Granados <j.granados@samsung.com>
To:     Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC:     Kees Cook <keescook@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Iurii Zaikin <yzaikin@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-hardening@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2 03/18] sysctl: drop sysctl_is_perm_empty_ctl_table
Message-ID: <20231207140903.dxlazorxcolnhyrf@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="etof6dfa6kluo2qz"
Content-Disposition: inline
In-Reply-To: <20231204-const-sysctl-v2-3-7a5060b11447@weissschuh.net>
CMS-TYPE: 201P
References: <20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net>
        <CGME20231204075236eucas1p150b54f5bca6816fb8130a30496a8dbff@eucas1p1.samsung.com>
        <20231204-const-sysctl-v2-3-7a5060b11447@weissschuh.net>
Precedence: bulk

--etof6dfa6kluo2qz
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

If you are separating the work for permanently empty directories, you
can add this patch to that set. as well as  2/18

Best
On Mon, Dec 04, 2023 at 08:52:16AM +0100, Thomas Wei=DFschuh wrote:
> It is used only once and that caller would be simpler with
> sysctl_is_perm_empty_ctl_header().
> So use this sibling function.
>=20
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---
>  fs/proc/proc_sysctl.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
> index 8064ea76f80b..689a30196d0c 100644
> --- a/fs/proc/proc_sysctl.c
> +++ b/fs/proc/proc_sysctl.c
> @@ -48,10 +48,8 @@ struct ctl_table_header *register_sysctl_mount_point(c=
onst char *path)
>  }
>  EXPORT_SYMBOL(register_sysctl_mount_point);
> =20
> -#define sysctl_is_perm_empty_ctl_table(tptr)		\
> -	(tptr[0].type =3D=3D SYSCTL_TABLE_TYPE_PERMANENTLY_EMPTY)
>  #define sysctl_is_perm_empty_ctl_header(hptr)		\
> -	(sysctl_is_perm_empty_ctl_table(hptr->ctl_table))
> +	(hptr->ctl_table[0].type =3D=3D SYSCTL_TABLE_TYPE_PERMANENTLY_EMPTY)
>  #define sysctl_set_perm_empty_ctl_header(hptr)		\
>  	(hptr->ctl_table[0].type =3D SYSCTL_TABLE_TYPE_PERMANENTLY_EMPTY)
>  #define sysctl_clear_perm_empty_ctl_header(hptr)	\
> @@ -233,7 +231,7 @@ static int insert_header(struct ctl_dir *dir, struct =
ctl_table_header *header)
>  		return -EROFS;
> =20
>  	/* Am I creating a permanently empty directory? */
> -	if (sysctl_is_perm_empty_ctl_table(header->ctl_table)) {
> +	if (sysctl_is_perm_empty_ctl_header(header)) {
>  		if (!RB_EMPTY_ROOT(&dir->root))
>  			return -EINVAL;
>  		sysctl_set_perm_empty_ctl_header(dir_h);
>=20
> --=20
> 2.43.0
>=20

--=20

Joel Granados

--etof6dfa6kluo2qz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmVx0f8ACgkQupfNUreW
QU+GIAv+KWbc8cruumpWQKvgTgVlEGLGgCJVse3Kfb0DYiRjt3V7lGQZv1RSqezm
ZKMsMzljxb1o8OhymJAD1m658hQd/6pqN7z880QwPLQMLRb4SOnO9b0x3uyp+wSH
q9hEl77PaAtXa64un9iY363HUrWYhE7yTCCLRJ26WuVLAFypd7ciX7qkxEK12swX
s42K1APkW3uenFOoZxSb1HKwxGduFQYnjfaQB7/MWm4zwglExu7y9Xy9OnkavjX8
2QgE0RFSQfBUbf59fBWgMui0NdSNg0T5qFtP3yfyav/W4/BBKZiWl/7vsNPtXQ/v
K/rRsOkRxyHtmKu8mZvWoiMhPyyLMWfIuw2KPp2A+QYVVfAfWMhuqJ/9f2UTR/uM
Qmn+KW8szcU1WCM6GrG09HRREk82TROTALV0Rq0x1Vm/WF5UXpT2Sqg/Dc+japov
iF7oYcAvPsBLIm3B1fPxeWlCx6o/l9XrXHrw8FP6GCAmveb7HMpccFJZtdHRL2h9
bi1HXhWK
=NL3C
-----END PGP SIGNATURE-----

--etof6dfa6kluo2qz--