Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Thu, 7 Dec 2023 15:09:17 +0100
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Sjoerd Simons <sjoerd@collabora.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bus: moxtet: Mark the irq as shared
Message-ID: <20231207150917.6f69999c@dellmb>
In-Reply-To: <20231123142403.2262032-1-sjoerd@collabora.com>
References: <20231123142403.2262032-1-sjoerd@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 23 Nov 2023 15:23:37 +0100
Sjoerd Simons <sjoerd@collabora.com> wrote:

> The Turris Mox shares the moxtet IRQ with various devices on the board,
> so mark the IRQ as shared in the driver as well.
>=20
> Without this loading the module will fail with:
>   genirq: Flags mismatch irq 40. 00002002 (moxtet) vs. 00002080 (mcp7940x)
>=20
> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> ---
>=20
>  drivers/bus/moxtet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
> index 5eb0fe73ddc4..48c18f95660a 100644
> --- a/drivers/bus/moxtet.c
> +++ b/drivers/bus/moxtet.c
> @@ -755,7 +755,7 @@ static int moxtet_irq_setup(struct moxtet *moxtet)
>  	moxtet->irq.masked =3D ~0;
> =20
>  	ret =3D request_threaded_irq(moxtet->dev_irq, NULL, moxtet_irq_thread_f=
n,
> -				   IRQF_ONESHOT, "moxtet", moxtet);
> +				   IRQF_SHARED | IRQF_ONESHOT, "moxtet", moxtet);
>  	if (ret < 0)
>  		goto err_free;
> =20

Reviewed-by: Marek Beh=C3=BAn <kabel@kernel.org>