Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Thu, 7 Dec 2023 15:09:35 +0100
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Sjoerd Simons <sjoerd@collabora.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] bus: moxtet: Add spi device table
Message-ID: <20231207150935.1db44032@dellmb>
In-Reply-To: <20231123142403.2262032-2-sjoerd@collabora.com>
References: <20231123142403.2262032-1-sjoerd@collabora.com>
        <20231123142403.2262032-2-sjoerd@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 23 Nov 2023 15:23:38 +0100
Sjoerd Simons <sjoerd@collabora.com> wrote:

> The moxtet module was failing to auto-load on my system. Add a SPI id
> table to allow it to do so.
>=20
> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
>=20
> ---
>=20
>  drivers/bus/moxtet.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
> index 48c18f95660a..e384fbc6c1d9 100644
> --- a/drivers/bus/moxtet.c
> +++ b/drivers/bus/moxtet.c
> @@ -830,6 +830,12 @@ static void moxtet_remove(struct spi_device *spi)
>  	mutex_destroy(&moxtet->lock);
>  }
> =20
> +static const struct spi_device_id moxtet_spi_ids[] =3D {
> +	{ "moxtet" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(spi, moxtet_spi_ids);
> +
>  static const struct of_device_id moxtet_dt_ids[] =3D {
>  	{ .compatible =3D "cznic,moxtet" },
>  	{},
> @@ -841,6 +847,7 @@ static struct spi_driver moxtet_spi_driver =3D {
>  		.name		=3D "moxtet",
>  		.of_match_table =3D moxtet_dt_ids,
>  	},
> +	.id_table	=3D moxtet_spi_ids,
>  	.probe		=3D moxtet_probe,
>  	.remove		=3D moxtet_remove,
>  };

Reviewed-by: Marek Beh=C3=BAn <kabel@kernel.org>