Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1685849rdb; Thu, 7 Dec 2023 06:19:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IH17nC4hCe//+cpR3fNozsXp6vi8dwHiuyZyd64FoKkM3R02HbayQkEJ/dV0JyjMGeQ2Yix X-Received: by 2002:a92:4a10:0:b0:35d:53ae:a702 with SMTP id m16-20020a924a10000000b0035d53aea702mr2898392ilf.31.1701958759974; Thu, 07 Dec 2023 06:19:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701958759; cv=none; d=google.com; s=arc-20160816; b=V9bPEW387HstPn3NGqIN6KR6Sd+2EO9oYOmkT0E5esFx1nSOGLju7eT1Ee9HNDl+U/ SwttGBUSsXNlLRaO+dgtXsj6UmUM+0h4CkXueHpYsuS0nF8jcKsEjiGMR0PxJ7opp/wt NTU4bXy6BpW+jNM5ajaxO90a56Emt7QakyiA0q8+nLt3XoSSYMVw6fg7E5Ea7a3ql7Rp s6hhHnV6sMHcwc3FNzHUjalO/VCLQcYGc/7t3ajU6p0W/VwilE+drBmjJGW9N+Eo1uvZ Od2tlgo4Ki1E/lc0CEWlwh4a/VidNEnNN7F6bF3bICsbMZXq02ytXQgSIz74Cp7JcRYy wLdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=bsCcuGLo2J2I6ix+dXxn7SDWpUwAIlNPbaC4IivWIA8=; fh=TNn6F2kA/tYwKb83rIVEqlTi/IDocQyD9iSl0F8h4/Q=; b=jaLPCUrOZ2DWa8MauU9iAp6NCzlj7heD8QbtATywekXcLecsj7QCvZJkLTgL4EwJmo guEfk2fQ6SORNcNEtIOWBg9tmWOoKyPcrZXqhYSyDwDKFZtLJVrhfMnS9o7y7I4zmHVT UXvXBZ13Hps08POUdy3eOg3ibrBOvCvlr5JtJ8JIpFDNdtAGEabBawIUk7DiNr9vIbw5 jkYxPLHWAEm4rFAfEMvVHiLp6taTWce3xTXN//LQORzV5673ao+EirN4AXLrjs+8JUxl di4QcO8vWRO8MMhK+88y58IuKZIxcjldxqlSrLobYQXOK1FEYnRxd0xw2CbvOS08j/VP EBdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hk6K+MZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id y187-20020a638ac4000000b005c67e10f240si1237417pgd.312.2023.12.07.06.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 06:19:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hk6K+MZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 0E48680B817B; Thu, 7 Dec 2023 06:19:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443328AbjLGOSN (ORCPT + 99 others); Thu, 7 Dec 2023 09:18:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443277AbjLGORe (ORCPT ); Thu, 7 Dec 2023 09:17:34 -0500 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA06A1990 for ; Thu, 7 Dec 2023 06:17:22 -0800 (PST) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5d3c7ef7b31so7758007b3.3 for ; Thu, 07 Dec 2023 06:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701958642; x=1702563442; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bsCcuGLo2J2I6ix+dXxn7SDWpUwAIlNPbaC4IivWIA8=; b=Hk6K+MZlCrBOJJDwgyumD2wg5DmNF82fqjyHW0SDGmzbrpjcmTPpeNyXN8UEL9dk6E naiq1grlAHhLSJvQlapEAxJojBDwtMLTjWcxCARqsVIlaTOPgNrlkReyzGG/37icBL8a EfJ+APQPxxTaNOBp6HgOWpe8ZSSVc6LOwla/8oHCb7Ayv6FBkNrgh7hrLBS1cA5Ircqv /bM5r1kztB9QQkaCG/yPkc8QjhAUSGd2PSE+scPTQlsarPjFlsK7wtwTCyAVAITRwBgS kRjsqgr8GMz6vpcjf5ynIV1lirq5/LwiggWcYgqwpRS/i6AcaEXOJz+jfBaP1YplDL3I XZBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701958642; x=1702563442; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bsCcuGLo2J2I6ix+dXxn7SDWpUwAIlNPbaC4IivWIA8=; b=wo4wK4AaaurME7fAeDIMjHhAn0iy9AO09zsTUMrpO+AZ7qCLNUmGM356aSUOODDMW6 Qyqbruu1G7yEcDnZUG5niaQekQUFXKo4mG7w387xfO4Gbb4XNs28bbV11JLyTn2pQluc 8eKbTc7Z3GmxwvikE10siZb9HAKh0/gWHAvgd64IZVwVVz/XebINXHhrfkPRyY/BIy1g vOkQ31akUKpSMnz4b0OvveMzNe7aLGSKz+ycTrmjyNgs+l1HjQ6S6RvM/bNHqjkZOBne Yc+ln2luuIE2QqdsrkDOMMtGxax0i8EMjhpE997Ja192EEAkm2+LpyEyWpausfbZ7Kmi t5ug== X-Gm-Message-State: AOJu0YzFNC58EbZp+YygPGSJZSocNLusBW2cU+zM0gqTfUpmyjAFRzfC mr3SWlvW91+VTJGQitMWmruu384BtbDpHApwBWU2XwfGj3w1n3XI X-Received: by 2002:a05:690c:c0d:b0:59d:d85e:795d with SMTP id cl13-20020a05690c0c0d00b0059dd85e795dmr2665100ywb.51.1701958641855; Thu, 07 Dec 2023 06:17:21 -0800 (PST) MIME-Version: 1.0 References: <20231207063535.29546-1-axe.yang@mediatek.com> In-Reply-To: <20231207063535.29546-1-axe.yang@mediatek.com> From: Ulf Hansson Date: Thu, 7 Dec 2023 15:16:46 +0100 Message-ID: Subject: Re: [PATCH v4 0/2] mmc: mediatek: add support for 64-steps tuning To: Axe Yang Cc: Chaotian Jing , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 07 Dec 2023 06:19:14 -0800 (PST) On Thu, 7 Dec 2023 at 07:35, Axe Yang wrote: > > Change in v4: > - for SD/SDIO, tune 64 steps by default > - reduce some breaks to improve code readability > > Change in v3: > - use BIT_ULL() instead of BIT() to avoid potential left shift operations > that could cause exceed boundary problem on 32-bit platforms > > Change in v2: > - move the change made to document to the front > - change mediatek,tune-step dts property type to enum for better scalability > > Axe Yang (2): > dt-bindings: mmc: mtk-sd: add tuning steps related property > mmc: mediatek: extend number of tuning steps > > .../devicetree/bindings/mmc/mtk-sd.yaml | 9 + > drivers/mmc/host/mtk-sd.c | 158 ++++++++++++------ > 2 files changed, 119 insertions(+), 48 deletions(-) > Applied for next, thanks! Kind regards Uffe