Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <13272300-1d7e-92e8-020e-54d9cfd12ca7@amd.com>
Date:   Thu, 7 Dec 2023 19:51:43 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
From:   Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH 1/6] perf mem: Add mem_events into the supported perf_pmu
To:     kan.liang@linux.intel.com, acme@kernel.org, irogers@google.com,
        peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org,
        jolsa@kernel.org, adrian.hunter@intel.com, john.g.garry@oracle.com,
        will@kernel.org, james.clark@arm.com, mike.leach@linaro.org,
        leo.yan@linaro.org, yuhaixin.yhx@linux.alibaba.com,
        renyu.zj@linux.alibaba.com, tmricht@linux.ibm.com,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20231206201324.184059-1-kan.liang@linux.intel.com>
 <20231206201324.184059-2-kan.liang@linux.intel.com>
Content-Language: en-US
In-Reply-To: <20231206201324.184059-2-kan.liang@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T09jR0lrMW1yVWd0ZmtabTBvVUphMHpXLzc5bldETHc5ajkzcXVJM2FSZlRu?=
 =?utf-8?B?UTdqSUUzdjlQRFRpVXRHTDBqVVh4Q3ljdWhEeDkzdkhoc1hvZlg5STlBQTR0?=
 =?utf-8?B?NzlvNE1kRENCbUQxTGk4NmFhWXFpbzRoREtzY0RmRGVZMHpIdnlyVDFEanNS?=
 =?utf-8?B?cVBiY3cyTFlmNmVSTDRvcW5oZHNxY1AwelZaNDhkTEVNZGZnNkhOb1RDQktm?=
 =?utf-8?B?WnVYMDU5SWJmSnhKZUkycUZaSStSa2lDNDdGVno4cm5rZ3I1R0x6N3poZjVs?=
 =?utf-8?B?UjV0Y0hjOXJpQnRvWE0rMDBQWGJqOVp6RnBsbmU2TGdFa04vT0ZFRmNDWmRm?=
 =?utf-8?B?NzN3cnJmZjV3cmswam40YUU5TUJGQlRrMUFERlNsQnltVFBiRlpHc3RxRUha?=
 =?utf-8?B?RWJHd0xaakM2OWsyU0NrYXJqczZHTGV1a2dSOE9KQ09tNmdWZlg3U3BiUVB2?=
 =?utf-8?B?ZUtnemJjTEg1Z1J1MW40WTU2VVEwRklHR3VYZUd3RHNZMVJBTEZoTTV4Rnky?=
 =?utf-8?B?UHduODNHc0JCeSt5T3RrU3pCclJvWUNudDB1UlVjellLYXEwaTVaa3ErN1Bv?=
 =?utf-8?B?Q0xPS2N1SzBsMUxmbk5aMWgveFRXQkt1eHNYQzROTGxTbXJIdTZaR29kWFpQ?=
 =?utf-8?B?OUFWVEt1bDBHOFFYUVVncExuempwVGFxU1dUTFlGbFhzVFVqYzU3L1NsMGJy?=
 =?utf-8?B?aXVITVl3OFdEUUhyUG1sTG5JaVJGdUR6RUxrcHo1RDltellRTUgrSTB4STNu?=
 =?utf-8?B?eWdtMGh5Y2llSWpxMEtqczNpRzhMNFpLeVJWYXhXbHFEakZWdWhDOTdPNzlM?=
 =?utf-8?B?bDlpOVhoYitlYUl0QTdFdUs4M3I1ZWxrSlBxWnRxTG1Xcmo5c21GZ3JWaWNZ?=
 =?utf-8?B?bE4zV3dCcSt5K0E1TUpLdW54eXhCWHZQUzFlMUwyS1kyd0hOMjVnaGhobThR?=
 =?utf-8?B?cmUvRG5nb0hJY1NNbTgrL1RnMGhBUGM1M3hqbmsvZDVidFFBczFreHpleGVp?=
 =?utf-8?B?TGpzZHV5RU1oejRhamt6dkVsSDZaVDdOWkJpdVVnMkNwbGlsNHFHQUNnK1Fq?=
 =?utf-8?B?eTl6VWcvVmkwOHhHZDlPQ1pMbnYyM3lyM3V1ckM2cm80VGplTUV2ay8yTmNh?=
 =?utf-8?B?YXlFdjAwSy9LZVUxWUJUY2h4U2cxZmdFOXhwMkRCaTJkUzlSaVNnQWVncnVw?=
 =?utf-8?B?MnJkaUZ1U0RWenhmdVBzcUdJaEpUUlN3c1ZMSkJMYThmZjhuSXV6WlN6Q0FH?=
 =?utf-8?B?VFB1VUZDMDR2WWN2QUYvZisvUjM2c1FtdkNkWVFlMkxGMGhtNEtwTnZaVys4?=
 =?utf-8?B?cVN1Yi9OdENtZkttTkl2WitQODlTLzljL2I5MmIwUWl3dTNXWWFtbVc2KzQ3?=
 =?utf-8?B?ZU4vdDFTODdlbTJ3eXpzY0JuenkwdVFJTE91R0xGY3V6MTRLUGFsUTJPNWEz?=
 =?utf-8?B?QUhTeVF3Zmt6WGltUFluUlpueVNuaGFuTkdwY0EySm9vMWFzRE4wcnRTbGZ4?=
 =?utf-8?B?Z0FEdnNKaE1mTlBmRUJTMzd3cHl2MmpBR2x6MmduSWp3a0x5VGYvQ1dKdE8v?=
 =?utf-8?B?eGM0ZVFBL2RSczM1YnZKeVNVTk53WGxlMWRKSEtINmhqNXdXNnFoeUszMWp1?=
 =?utf-8?B?QUdXV1F0blgyTHZkTXhMNTRza2JXQUFJcWtJMXU3dkt6WUVzN21BekVnUmYy?=
 =?utf-8?B?UjlzVkkvOTBMMmVUMzdCRjhpWkJMa0VCSlBlZ1Vobm1wYVZFZnNnZGRsdSts?=
 =?utf-8?B?cHAzSzZKbXJsZFRkSm54ZHZZSnJlSkJON05lelF2amx5ZHc5M0dzZFAvMkhs?=
 =?utf-8?B?MDdHemkvU0UzSjA5dWREOS9tMi85a25Hd2o2cytBSjNCU1JXVUNjbGI1YWto?=
 =?utf-8?B?b3hxaWhzR1I4aHNOM1ZpTURFVE5jUzZpNXdiZHFDODB2MHk5QU1WZGhQLzRQ?=
 =?utf-8?B?clFjTFlnRmRtVElUQ1k1d3RxQUhvUlNSdkZxWWVkQXpWZndGSFpLT1NHZE53?=
 =?utf-8?B?VktnQTdVMTBFTTcrdG8yR0xKcHdkWlYxQk1jT0FjZ1lWamZhelJZZ3pRWXFu?=
 =?utf-8?B?KzludGU0YXhTcEpCdkt0b29tbzNGdU9IN1M5SE5HaGxzVmhOVm9nY0xuUHY1?=
 =?utf-8?Q?JnJIdD/NPz+xDQBvIaASJI+C+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5720a52-c6c5-4df6-4dc2-08dbf72fdcc3
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 14:21:54.6294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B35MCcMzcU7PXo5eZt/hT8rtbxw9RYUI47ZAMJinb559cC98Ci2n4sSYZthVaslKCzmJqBxX8tMXbckngbsW8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7625
X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 07 Dec 2023 06:24:03 -0800 (PST)

Hi Kan,

> +void perf_pmu__arch_init(struct perf_pmu *pmu)
> +{
> +	if (strcmp(pmu->name, "arm_spe_0"))

if (!strcmp(...))

> +	if (x86__is_amd_cpu()) {
> +		if (strcmp(pmu->name, "ibs_op"))

Ditto.

Thanks,
Ravi