Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1698472rdb; Thu, 7 Dec 2023 06:38:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFkzpuTOwERCJ0ppi4gorcC9z9TnRgH+82uT/UjFgtC+edJO2Ka9FE6SnW/pLAst5mW1HGW X-Received: by 2002:a17:90b:33c4:b0:286:2900:e509 with SMTP id lk4-20020a17090b33c400b002862900e509mr2142415pjb.39.1701959932848; Thu, 07 Dec 2023 06:38:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701959932; cv=none; d=google.com; s=arc-20160816; b=lhdwMON9AKHnqT+5f+p0+LMTlRG6lp4feQsc5iozYVejSk0KskRNeNjbu74mAv5fPJ XDrBO/pxbqYBcGnpt8ZQvGKGbzfJWGT7GNUxeiysVhiZCEwcpExsr7oSxocEZPliJ3tK qljrM2RX/rR0xCGXEig9pUGolQcfU1nHvF5rDWZlm9ZW05yNoFkxmaBkmJUzOpPkPgoE UhPdpLu2CSiN//sxdMQE+BQMeOZK91o+QQaDqvlWI5mA6ml2yG+qyH6SYkhiZooUGDow MZCIwHvoOIriKyzznMXdyJ3g9yXCtxV1H/4mM9IaZ1CnTfYpfZtziJV3adbVSoX7/9FU aiKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date; bh=tgcc/bhDSLicp6T+9g6ST8KzmOjsQk2jkJtndlfVIQ0=; fh=rCtTbwgmfs0PrNjk09rm6vB3IG/BA+PsvRjDOTbJpEA=; b=lnli7qX/y6ZRa33O4Ciba5QgZB05+NKD+HZtsXkjtEKBqDQTjKtntaOmKToZbafHYU Fgy5daXnOHjrXUKaorqbKOjm8mcuZKeq2nKPcDsaUrgyKVMoUK+05tAitVbEzWh8qepR ge38wFCCjzjjAiiOdeng1g40FTMHn95K4FsYYu664bYkOo+ADUC/4KNN0FTABEYibDMX Ju9bfF1yTkoc6hBNDIZ8d4lbM7VmieScmmxUOh0LqYl2z1ZP3cr51rVYENq4J9Fp2YHT fNZH07YtTH7p+dYpr2Z+UnajIvzHHujchEQF4XLCXaRS/6uzmFDrHPnmUy6Ajr3jwDf4 ytsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id f24-20020a17090ac29800b002878ffafeb3si1175692pjt.113.2023.12.07.06.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 06:38:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 863F3808E8D3; Thu, 7 Dec 2023 06:38:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443257AbjLGOif (ORCPT + 99 others); Thu, 7 Dec 2023 09:38:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235280AbjLGOie (ORCPT ); Thu, 7 Dec 2023 09:38:34 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74BA5AC for ; Thu, 7 Dec 2023 06:38:40 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C28A11FB76; Thu, 7 Dec 2023 14:38:38 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6E28213976; Thu, 7 Dec 2023 14:38:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id kkNYGe7YcWUWOQAAD6G6ig (envelope-from ); Thu, 07 Dec 2023 14:38:38 +0000 Date: Thu, 07 Dec 2023 15:38:37 +0100 Message-ID: <87y1e6yt5e.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Gergo Koteles , Shenghao Ding , Kevin Lu , Baojun Xu , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 00/16] ALSA: hda/tas2781: Add tas2563 support In-Reply-To: <85b7456d-7cf3-4885-8e71-111df53e35fe@sirena.org.uk> References: <85b7456d-7cf3-4885-8e71-111df53e35fe@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 7.79 X-Spamd-Result: default: False [7.79 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_SOFTFAIL(4.60)[~all:c]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[10]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(2.20)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[irl.hu,ti.com,perex.cz,suse.com,gmail.com,vger.kernel.org,alsa-project.org]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[17.80%]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spamd-Bar: +++++++ Authentication-Results: smtp-out2.suse.de; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none); spf=softfail (smtp-out2.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tiwai@suse.de) smtp.mailfrom=tiwai@suse.de X-Rspamd-Server: rspamd1 X-Rspamd-Queue-Id: C28A11FB76 X-Spam-Score: 7.79 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 06:38:49 -0800 (PST) On Thu, 07 Dec 2023 14:55:25 +0100, Mark Brown wrote: > > On Thu, Dec 07, 2023 at 01:58:22AM +0100, Gergo Koteles wrote: > > > Gergo Koteles (16): > > ASoC: tas2781: add support for fw version 0x0503 > > ALSA: hda/tas2781: leave hda_component in usable state > > ASoC: tas2781: disable regmap regcache > > ALSA: hda/tas2781: handle missing calibration data > > ALSA: hda/tas2781: fix typos in comment > > ASoC: tas2781: add ptrs to calibration functions > > ALSA: hda/tas2781: load_calibration just load > > ASoC: tas2781: add configurable global_addr > > ALSA: hda/tas2781: add TAS2563 support for 14ARB7 > > ASoC: tas2781: check negative indexes > > ASoC: tas2781: use 0 as default prog/conf index > > ASoC: tas2781: move set_drv_data outside tasdevice_init > > ALSA: hda/tas2781: remove sound controls in unbind > > ALSA: hda/tas2781: call cleaner functions only once > > ALSA: hda/tas2781: reset the amp before component_add > > ALSA: hda/tas2781: configure the amp after firmware load > > Please don't randomly interleave ASoC and ALSA patches like this without > some strong need, it just makes everything harder to manage. And, some look really like rather individual fixes; they deserve for Fixes tag and Cc-to-stable, at least. thanks, Takashi