Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Thu, 7 Dec 2023 09:58:13 -0500
From:   Gregory Price <gregory.price@memverge.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
        jgroves@micron.com, ravis.opensrc@micron.com,
        sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
        linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-api@vger.kernel.org, Linux-Arch <linux-arch@vger.kernel.org>,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, Michal Hocko <mhocko@kernel.org>,
        Tejun Heo <tj@kernel.org>, ying.huang@intel.com,
        Jonathan Corbet <corbet@lwn.net>, rakie.kim@sk.com,
        hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
        Peter Zijlstra <peterz@infradead.org>,
        Frank van der Linden <fvdl@google.com>
Subject: Re: [RFC PATCH 07/11] mm/mempolicy: add userland mempolicy arg
 structure
Message-ID: <ZXHdhVeel1dOxlYJ@memverge.com>
References: <20231207002759.51418-1-gregory.price@memverge.com>
 <20231207002759.51418-8-gregory.price@memverge.com>
 <67fab0f1-e326-4ad8-9def-4d2bd5489b33@app.fastmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <67fab0f1-e326-4ad8-9def-4d2bd5489b33@app.fastmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4VHDfYgT7sDTno20H/8W9PXyI59Uq9XEsMgjnJu9ExreIAbDsP54sv+Bda1p?=
 =?us-ascii?Q?5To8UJuWc9QcMol00GSTJAjIGgv/MI0v6LDAlxtuUmB8t4HNEUXGzXFZE4fH?=
 =?us-ascii?Q?zRlPEwmt9HPLt/qygTokQPZ+Hx44jhbzNLRAum0RtYKibcmrplbpnOPFnYS4?=
 =?us-ascii?Q?/Nc5GCgFFD2m+5Z0LSt+0fPqnUsiKT1Ey/ISlLYOMHh7b/8C3M4HIBcNlGMR?=
 =?us-ascii?Q?n4VK35lmBkf21ReaL6sIcIYN5UdodhNarOdBqePa/Sd3GMC2ePVDG53TWIvw?=
 =?us-ascii?Q?rbMiAisSiK0UA7sB7Z3nehZvTmmecKc/L02iCWUALWgJ5zge3xho5Rkf5CVK?=
 =?us-ascii?Q?k+FdgCBeZYH1UaGl/2VtZyI73uDX++IeyqirJHTFRVTX6P1SsGDfWI+O9pyQ?=
 =?us-ascii?Q?81a8gwXuxV8P5CnbHFyd/AqGFyxBweinvmOa5z4Oag6BUhbtwRjPUWQ6WAJr?=
 =?us-ascii?Q?jH2UtGgRh948U8eXFkt9K+K8Kk52x2dakB+PT0EtJ1DV0AsTZtZGlPPBiPnG?=
 =?us-ascii?Q?1eqDiYhUyoMzyqipxCjzZ/EeL3yZJsEr7JU1GaAthiq0AHMd5vva55zX1HGC?=
 =?us-ascii?Q?SMw3eCYi3v34MIhL43r5JsgwkcLH4udwtS8W87/+QYHa4aP33F+P7xzn/XOO?=
 =?us-ascii?Q?W9MaHHMLdg/OBj1+9B70dwjWBOPTo6KxLvKe4Po96MRbRXuJ7CGo2Qe7IN1Q?=
 =?us-ascii?Q?L082LZvtU6h5fRk3d5CsbOss4lPcblpIchn21Bi/lhA5aDohqFC1dYjNllJ2?=
 =?us-ascii?Q?SVsUYSllYWgrFuxMOZjG3Xw9+NV4vhK2OGUI5xJYFoucF8K3NfVG5WkChhNv?=
 =?us-ascii?Q?4adI0k6sOTLNL0iNzhlTqfdixlNkWw1vz96X2vMuIbsqNqOCqLUTXNem/A0O?=
 =?us-ascii?Q?0vBsW8FfbugV+qoGjpveZpQ9kQastDJS/Rcj8TYih/RieUd5u1HCPLfbZT9q?=
 =?us-ascii?Q?C1bqYvFy9p3KA52HL9mq4WB3fDNCs3O7mFxg98pHle05Ia7xbSm0ap7MgB+k?=
 =?us-ascii?Q?WiWGgRE/Nhp60vi6vseLuC/8C/UInJYWc3+yilE6P+raE+jE7nXeLNAbDM2R?=
 =?us-ascii?Q?dB1fnIkNPH6nfu/yl/tAOeeXPLiPw8s8HcLwvI6T874oyrZoGgC9gKAVvih3?=
 =?us-ascii?Q?qiWkn6rZRk/HDXkRUqplCPP0mTZs2rClXo3fjUMzXkjf5AG99nbtgcxgSsf8?=
 =?us-ascii?Q?e7Q8UO3W9CtdxDqscrCo5ybflfyQNhHYOC3LadI3R18tLF4qPlkw0upUJoYK?=
 =?us-ascii?Q?SRbvPzznqWcjS+SynjvfvZod6OFpkjcXBnAZQBlHsse2CKfOKrpzkCrNtsuN?=
 =?us-ascii?Q?zWjMED2GOoHoWKe4cVGO7sGI7FGPlAb2SOW+Cpqv/nQFNYCDYW4/UtG8oxjb?=
 =?us-ascii?Q?AE0FUGI6gipIqs/kPn4c3S3/jbF8VBpeOGoaIrMtp1czKs/pazTIlDwWFHhw?=
 =?us-ascii?Q?1ON1B7bJmQc3WYFCLkSOZa2lezppvhGPM0ibwaP+4KFYNBbdtKJcfUFdxru5?=
 =?us-ascii?Q?1tjVnbOkxohNJVvyuOvxpB6Frq1FPip20FX4rxu/VzjHFM305+mwt3062tXQ?=
 =?us-ascii?Q?o4Z7P+FEKK4QMIwnUn5qaOJ8hIHjRmmT8j9ale2IipPND1ylkE6SQdx7ODTU?=
 =?us-ascii?Q?pw=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aeba84c5-f709-40da-d709-08dbf734f2e4
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 14:58:19.0174
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0wX5lioStHt9yAxYCidYr+uftOYMQIcS9jo5Q0tMMNW6HylLn6KBJ1FKl+TgxcaOKlCLVKUZv4kTta3Gu68iiO3tweVOFxrbwvxEm6bDCQ0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR17MB4175
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 06:58:31 -0800 (PST)

On Thu, Dec 07, 2023 at 08:13:22AM +0100, Arnd Bergmann wrote:
> On Thu, Dec 7, 2023, at 01:27, Gregory Price wrote:
> > This patch adds the new user-api argument structure intended for
> > set_mempolicy2 and mbind2.
> >
> > struct mpol_args {
> >   /* Basic mempolicy settings */
> >   unsigned short mode;
> >   unsigned short mode_flags;
> >   unsigned long *pol_nodes;
> >   unsigned long pol_maxnodes;
> >
> >   /* get_mempolicy2: policy information (e.g. next interleave node) */
> >   int policy_node;
> >
> >   /* get_mempolicy2: memory range policy */
> >   unsigned long addr;
> >   int addr_node;
> >
> >   /* all operations: policy home node */
> >   unsigned long home_node;
> >
> >   /* mbind2: address ranges to apply the policy */
> >   const struct iovec __user *vec;
> >   size_t vlen;
> > };
> 
> This is not a great structure layout for a system call ABI,
> mostly because it requires adding a compat syscall handler
> to be usable from 32-bit tasks. It would be nice if this
> could be rewritten in a way that uses only fixed-length
> members (__u16, __u32, __aligned_u64), though that does
> require the use of u64_to_user_ptr() to replace the pointers
> and the reverse in userspace.
> 
> Aside from this, you should avoid holes in the data structure.
> On 64-bit architectures, the layout above has holes after
> policy_node and after addr_node.
> 
>       Arnd

doh, clearly i didn't stop to think about alignment. Good eye.
I'll redo this with __u/s members and fix the holes.

Didn't stop to think about compat pointers.  I don't think the
u64_to_user_ptr pattern is offensive, so i'll make that change.
At least I don't see what the other options are beyond compat.

Thanks
~Gregory