Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1738320rdb; Thu, 7 Dec 2023 07:34:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFuXdSq5/lbDlXx88zZK29kW1sgFiZy3I6XUmWTLJavAdr6//KY46ySJZbsDVHxwohLxQXJ X-Received: by 2002:a05:6a20:138f:b0:18f:9c4:d34e with SMTP id hn15-20020a056a20138f00b0018f09c4d34emr4658794pzc.62.1701963248797; Thu, 07 Dec 2023 07:34:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701963248; cv=none; d=google.com; s=arc-20160816; b=Q1AeBcdbnhycr9i1RzaIdVn/UPIzP058XEa7Gqjan43YHVUMxKg51ea+q4gnuA48yA OIbkK0+Lys8pMv/L4j1I1mBLqOJmWc5jydht1j8f/G13q4FSdl/ikWAIcARZANPaUbh4 q68FE3aJvQMtGOm1VX4RDPf9hWhxk1YAt6cKg0CtkP4cd9anIwJGXnXtSzFFJP/s45ML ftSDbr5O64jRzoEt72qH0ZpjQoHN01uz5y5+KnvzxzTvHIySdGbxKbhVseHsAc+O2m/j LDTVIVPQm6D6ONhE30jTgYEm0ayGYGrzMOUpACWiNHL5auYovGXov8boVJacyHfVX1U4 8pPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=7T5cm0PLVLbVz9FN3mLw2XN7qrr6hTX6uKxs2qaMsho=; fh=JWieladFfeaIwBj69e66MtYgIw576fUcTLVAEUXiV9w=; b=BhJkVHQoYwmDjy1rFINPUmBsKbHU9ahem2a5WwXaqwUBTMoQUgp/cpsJw4+M61F+lZ eaBAj69x1fODORndYHQgmTnfkJ9tgM29z3HV2ppFzC2lIAsyxRaopZU/pcLGc98nF+Fe yKvUk9Z/x5Klj0Za9L1IYKAVMaGLv5ueamqFjLmRkZw2XUB95RF/txl84P8s8sIGtemS TqI0fVHKidm5kFmvyRKrFuYTYLoeBgoxQEm+AsA/jI1jm6s8cZETvIjygiBxzZmL3xzT HsXTZ/mzrdjPWB0jO8kM4jXcVUsZdyCv+safatZfeXh+5jFUUSZua2u3zZAB0cD9gsbO 0svQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id z20-20020a656654000000b005c660a37af2si1375024pgv.255.2023.12.07.07.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 07:34:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 11CA380475C3; Thu, 7 Dec 2023 07:34:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443531AbjLGPdt (ORCPT + 99 others); Thu, 7 Dec 2023 10:33:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443479AbjLGPds (ORCPT ); Thu, 7 Dec 2023 10:33:48 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9229310CA for ; Thu, 7 Dec 2023 07:33:54 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 110BF227A87; Thu, 7 Dec 2023 16:33:52 +0100 (CET) Date: Thu, 7 Dec 2023 16:33:51 +0100 From: Christoph Hellwig To: Daniel Wagner Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke Subject: Re: [PATCH v4 4/4] nvme: repack struct nvme_ns_head Message-ID: <20231207153351.GC21486@lst.de> References: <20231207123624.29959-1-dwagner@suse.de> <20231207123624.29959-5-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231207123624.29959-5-dwagner@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 07:34:05 -0800 (PST) On Thu, Dec 07, 2023 at 01:36:24PM +0100, Daniel Wagner wrote: > ns_id, lba_shift and ms are always accessed for every read/write I/O in > nvme_setup_rw. By grouping these variables into one cacheline we can > safe some cycles. > > 4k sequential reads: > > baseline patched > Bandwidth: 1620 1634 > IOPs 66345579 66910939 Nice: Reviewed-by: Christoph Hellwig