Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1776757rdb; Thu, 7 Dec 2023 08:29:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFloII/zThnopLUL5qrG7w4+ev9iquIRoE5ccuajRQj1v0jfeKIEQF7Z1Yt/rYPiEF1u3ix X-Received: by 2002:a17:903:4c2:b0:1d0:cd14:193b with SMTP id jm2-20020a17090304c200b001d0cd14193bmr2496055plb.31.1701966591958; Thu, 07 Dec 2023 08:29:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701966591; cv=none; d=google.com; s=arc-20160816; b=V0O/5eMb1kCXBy9EHPKI1huwMMZBpAaLiRM4vPFdyauc4nfpO622FFFelmuijoZVEg m3qAme4R3BCM6G9h7Fh+0Y8k6fQ+pY4eXhgZG32/5Pr9Kz1PLwys8edzeNR3sj9xxNGD sJXmNAfklGozgJb3Tjw4WU7ijzjjbZtiRzNhs1HC+wo8dBkTUF/Qxl0fcxCWkPZNCKxT e7YQanFrE15r/aKyvFMPd40NQN/0uS9+ZP9B/FQ+ULF4DZhGACKZkhGsI+I82FWJaUfu 0ryn3CjKTYXIO3Zqkw9xuqZixLLiiO9/56KCso7z/tS3Lfl+1Je6gv48xtDJx1uqhjY9 Jecg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=I6fR/itou+AYTz0oJIy7eU7hy0iRvrqimoeymjmtrko=; fh=KQdQtC/nWjk5GuqKvcahaFk06Xt2jc52BJDaRCnqa+c=; b=ucDIh0cgmi54LOuX9StaXP11UbkhWIzq8tR4LqPs1AwRxP0wQy0BnY69VGSSDsn4mN q6MwXtpngJtgUVi6hrzNCPiWN3GK34+cpC3H9ld+dp27fLqnSPJYNssCP5YnpPT9O0ZS JfAgyxwJZniQJLKJwjokfcmVrBEff60opMctlEsGHD9LolkjfIJ/+++B4Z7L0gV+bNGz +P5hxmY5DDxQn3wCgQMABco0bh++roN0noaoBT/s3u7Gi8zOlcf7aNItoRmRDNUwxfDm R6QszLie5YAI+tJPJ9R27wYkU4J5O8TIYMlKVdaedIZDMYUAb+FVPrUFwZ181M9Yl6Yc vj1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Kvy7Py4V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id c11-20020a6566cb000000b005be00724141si1425966pgw.533.2023.12.07.08.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 08:29:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Kvy7Py4V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 9751E82B929D; Thu, 7 Dec 2023 08:29:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232488AbjLGQ3Y (ORCPT + 99 others); Thu, 7 Dec 2023 11:29:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbjLGQ3X (ORCPT ); Thu, 7 Dec 2023 11:29:23 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A7E112D for ; Thu, 7 Dec 2023 08:29:30 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D34CCC433C8; Thu, 7 Dec 2023 16:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701966569; bh=bIk2zEVd/ALsJPnzNnUpGKKfoLp6VvygCrV4NUYPhF4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Kvy7Py4VdNM01E7IR4ovzeKQYpJ0CpAazXTFaU0+LlVFKhJa+fOJ+SFDiL/ULejgO 2a5yJX24skY1woXVm/qciCgYVfOhQ7XZVDfofDm1keqA24gzRdTFcIq5bCD1zpo+zL 3J3+jl4KtUNGxwcCyvlIi2uDQO30qCIAzmZ3yPIAk79b4C0pQFXDIGobLi91soZFdk VI8UrLKkxWPg6xAiXnDHMJr5vKHz/UhUdK3vTdGzf60uaIF71i6opKBnOID0xPtRso 3fV62ZIpqTJJJ8XReBK281wn/fb5SECPg8LwO5AwCqIWNjLGGHF2n6LX2SSqakGs5t hkm6fT1RVh3Aw== Date: Thu, 7 Dec 2023 17:29:23 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Daniel Golle , Lee Jones , Andrew Lunn Cc: Pavel Machek , Jakub Kicinski , Christian Marangi , "David S. Miller" , Li Zetao , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v3 1/2] leds: trigger: netdev: extend speeds up to 10G Message-ID: <20231207172923.62ce530e@dellmb> In-Reply-To: <99e7d3304c6bba7f4863a4a80764a869855f2085.1701143925.git.daniel@makrotopia.org> References: <99e7d3304c6bba7f4863a4a80764a869855f2085.1701143925.git.daniel@makrotopia.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 07 Dec 2023 08:29:46 -0800 (PST) On Tue, 28 Nov 2023 04:00:10 +0000 Daniel Golle wrote: > Add 2.5G, 5G and 10G as available speeds to the netdev LED trigger. > > Signed-off-by: Daniel Golle > Reviewed-by: Andrew Lunn So what will happen when there are more speeds? Will we create a separate file for each speed? Will we have a separate sysfs file for 10, 100, 1000, 2500, 5000, 10000, 20000, 25000, 40000, 50000, 56000, 100000, 200000, 400000, 800000 ? These are all speeds from include/uapi/linux/ethtool.h. Maybe we should have reused ethtool link mode bits, or something... Also, the files should only be present if the requested speed is supported by the net device. So if 2500 mbps is not supported, there should no be link_2500. Marek