Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1778153rdb; Thu, 7 Dec 2023 08:31:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IH41aYq9081Y1knLcHxBH60kogZrB6JJBwkkewUmN7p1vKLz3HTXgiLJUZi0i3Qz+2Cx44K X-Received: by 2002:a05:6a20:1446:b0:18c:5795:669e with SMTP id a6-20020a056a20144600b0018c5795669emr2866244pzi.19.1701966699083; Thu, 07 Dec 2023 08:31:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701966699; cv=none; d=google.com; s=arc-20160816; b=LTRaqRlKRPOzkGAwzVW19axnoe5o5qrBbDveHFXIPhVUuq/kxp99KPyhEFSiptxojG f1i1SQotQE5AxcTFIuhoOfuqU2vqItVPzRBJdJrrXrMx1TDOmHxjhB+QoXWZRKDzUGzT x7EsRRCWTSnyS2RdGPJ+hklJMmdiRYvBPPyTGprCn1yiIduHpWUXtPtfsA7svW7yzlSX /x6eGlsBB87xcpdloVNaUZf/Jf9sNi80stUm7save/WgpT3TC0x7GRY8LYpCFwH/6hTj lXTw9uE5V1/oeQXO0hCxr2lsx9Grt/D68r8tOMuTQRVJu++7rRCJS9pv6v+NzyfT/6qN Z2ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=5rIP8xiIeStLAZxAKenikHJEOOwixpMvqcR8yCub0Xc=; fh=QEGkyzyX+JY5Etd8HYkWO4GArOxUeQOn2rA9JFHSBxo=; b=zFgCrXUxBINfRv6RPWm1Ygl9VaAMcB11xQZOgnSpexkxd2t4X+VTKNUNQ9HQeb06t6 KVNJQflsiElCuL+WQY8w5dV3UGBjDnGMgH4BcZBTNMhiw2Yl0hCcxp7CMj9zi/JsonrA bPtM3hnh9FvdXFoht9lJIyG9r1I4N+Ms0bb0wsQAApbsH1WhLMz2ZCB4b0ChE2mu7x5B Ei98gUDMq9I7gh+SlEyAK6KZwmom7fLXgVUeza3tlpBLQDIfotHBpw+87XY2aw0FLiQ0 EBH/FRahM2rb6T6/a2Dny+JsXQtP7BFxZuwctOK5g0PvduZlod5SZK2/783GBmQ+2eH8 p2UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="sMxnsD/8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id o17-20020a656151000000b005c219360d9csi1497018pgv.50.2023.12.07.08.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 08:31:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="sMxnsD/8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 4512482C5161; Thu, 7 Dec 2023 08:31:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232488AbjLGQbJ (ORCPT + 99 others); Thu, 7 Dec 2023 11:31:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443321AbjLGQbF (ORCPT ); Thu, 7 Dec 2023 11:31:05 -0500 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 252E912D for ; Thu, 7 Dec 2023 08:31:12 -0800 (PST) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5c5daf2baccso11297647b3.3 for ; Thu, 07 Dec 2023 08:31:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701966671; x=1702571471; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5rIP8xiIeStLAZxAKenikHJEOOwixpMvqcR8yCub0Xc=; b=sMxnsD/8UW1venRLzWrYQDXljCWKOCPybe/VCyNmXLC+x8UoRUbe/CX+BfK2BfLY1G eKqP3ZyzwFKeDKLM7oZldXIAUOB/zetvlFY/tz9GT5RuRpLTLxljXxrR0vmGL+PX7uuM +krG91QILeNdcNNl6MQ2VC92N9PePPlnVNwV9g11dicgZb2moOh7rUedpg+qXQLkAPy1 5Fvz+4Ug6MRqU2FDMUcf0459sQDtVJeuSDpFxHfWaYClMXAwcBxXI54u0zGubc5luK1m Ye9J3cRNnOhQNWSW6RY3G/aOovyumE8hmy33WY8yYfNX2gsuRrt3HrMe7PFqHmJQPlZX k+DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701966671; x=1702571471; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5rIP8xiIeStLAZxAKenikHJEOOwixpMvqcR8yCub0Xc=; b=LJJcUkrXBJI/aJBHB3QSOWdQntx7bDWI9LCuYOJZe5advf1Kf/MzU0ahA5ZW6Hneq9 RMdEJygdtpLJDFbf+VqUSIrjFGp4yXmTBFeVmMYpIDNFoTs7Cb67aEkbsGSb5iQgTS29 paTiZNSGbjUxoL+fTAZX7i6C7nXdgYNSyb0ThnTOyHhZ4aWcEcWGBQXGh+pZfdk48IlL QhVvlkd9PuvDtO6uAzmeZJ3gl6gPKNtH5/qzWpc1KsAEBhf/p4ecETyyp8ZX4iWl420Z OaQpPOQ0pytVr6tk1AnRCkH3ii3fhX3pR6DtJO5UlBhcSqv2EeP2EkDiPv2uRp+LW5e3 nNPw== X-Gm-Message-State: AOJu0YzV0+9dNMCjpoItDZl/VQ+qE3mRphnirmXZB+BeLiV1UPpj69+8 K5F5aYq+/YIuVRkC4KRIKK8pWU58kpw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:cc44:0:b0:d9a:e3d9:99bd with SMTP id l65-20020a25cc44000000b00d9ae3d999bdmr35659ybf.5.1701966671331; Thu, 07 Dec 2023 08:31:11 -0800 (PST) Date: Thu, 7 Dec 2023 08:31:09 -0800 In-Reply-To: <6cd419ff-97d9-495b-bc9c-0c53c4b1e3d1@gmail.com> Mime-Version: 1.0 References: <20231206032054.55070-1-likexu@tencent.com> <6cd419ff-97d9-495b-bc9c-0c53c4b1e3d1@gmail.com> Message-ID: Subject: Re: [PATCH v2] KVM: x86/intr: Explicitly check NMI from guest to eliminate false positives From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , Andi Kleen , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 07 Dec 2023 08:31:36 -0800 (PST) On Thu, Dec 07, 2023, Like Xu wrote: > On 6/12/2023 11:30 pm, Sean Christopherson wrote: > > Please don't make up random prefixes. This should really be "x86/pmu". > > Thanks. > > I'm hesitant to categorize about NMI handling into kvm/pmu scope. Why? Literally the only thing this can affect is PMU behavior. Even if there's a bug that affects the kernel's PMU, that's still x86/pmu as far as KVM is concerned.