Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <77ee045d-e5e0-4157-ae0d-cd8320a33eb3@kontron.de>
Date:   Thu, 7 Dec 2023 17:42:43 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/bridge: samsung-dsim: check the return value only if
 necessary
Content-Language: en-US, de-DE
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>,
        linux-kernel@vger.kernel.org
Cc:     Maxime Ripard <mripard@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        dri-devel@lists.freedesktop.org,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
References: <20231207161056.183442-1-dario.binacchi@amarulasolutions.com>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20231207161056.183442-1-dario.binacchi@amarulasolutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGNzQS9TQlZTbmZEbEh3WVM4dHJvbnZDQVkzOFZlazZmeHMyZDdib005L25h?=
 =?utf-8?B?RmF6czVmMXpUT2FhcmdhOVhGT2hIQnBuZXh6VUpvcGR1N3F4eVFxcEI4WVN5?=
 =?utf-8?B?Sm10UEl3cCs3NldEV2I5RTkrcEhDOFdLVHdwcnBhNlJKc0s0QiszVXFhbisv?=
 =?utf-8?B?WlVqdXJjalJpcUpKblNYTGtRQ2dqM25neEswY1BiWXhaa3Z2N1dVMTR3T1lO?=
 =?utf-8?B?aEQ0VE5VQ1hYUTYxeXdVenlXZVBUZ0VOV21hVTAwdldWYkYzNzJwQll2UVVs?=
 =?utf-8?B?QnB1cjgrdEdJOGE3VE42VTFmeDhZNVkranR0UmdKNUpMWnNEN1JQU3I2T2l1?=
 =?utf-8?B?dlVEOUlXY3d2dnFMNmx3Y0VZUVo0Z3lPUndVRlpiMVlCMDJQV1d1cVhvN1Q5?=
 =?utf-8?B?ZUhjcU9JellNUmFWR0hGblVySWZvYmRwYVhjYTdab2JCSFc5SzJGaVJPdUdr?=
 =?utf-8?B?UzJXZUpLc2RVM1JYdW1sOVhrN0Nta2UyN0hHMEJYV2VqQTBuRktPNDVPZFRK?=
 =?utf-8?B?clhjR29oQjJ3QlRLOXp3TVhVMzR4RytyVG02K3paWW9CcVRqNWxUeHdJQnJ6?=
 =?utf-8?B?ZlEwR0pZdjJxSGNLcFM3dWRGOGlDenlOVUNmelhuZG40cjhUUUk4OXZWSkV2?=
 =?utf-8?B?aWJUZHdjSjdHeExaYWVjVTkva0lXQlUyR09xSEh0Y2ZHNHY5ZWZZVCtFTTFj?=
 =?utf-8?B?QjFnZHFTQVdBWldGWTJlaFdPeFgySmEvR21VcUhydVZYRnlZZGpRZjdUSWdz?=
 =?utf-8?B?Qm9PeGFIKy93WG45bzN5VzZsQ2dGRzlJTVVKcXZmSWdqVzFWNXV2NWlyZkIw?=
 =?utf-8?B?OWNnU0tGbzlzaWp6aERydWNtOXd1Slg3aGRCUTNReHRNYnhXL0RQcm5pUm5U?=
 =?utf-8?B?bVVBWURtaURsS3I4Yi94ZHdLUWM1QVhtdmhwZSttN3pSMDZrd1M1MVN6YlRy?=
 =?utf-8?B?Q0EvbDR2V1d2WURxck1BM3U4N3FHWE9HbXp1WFVpOWUwdG5UWjQ0dlNmdXVt?=
 =?utf-8?B?OC93dFdhQXVFeFp2bkphczBKTDZQUWtHSlI0SW84N1lETGNRamV3M2tUMmda?=
 =?utf-8?B?akh3dU41Nld1RytMT3NCT3Zwd1VWK3N1YVZqUktPSTlERlZVeHB6REdxd1lT?=
 =?utf-8?B?SE9JaE9lMjBwa3pGSWhzV3VtUUw3WCt3azRDZzVBWFowTml6a1BmdmhRNmgv?=
 =?utf-8?B?Z0JUc2Q1SE1tcEpSY0ZaRjVaemplY3RyczRnWGFQWThBYWs1SDJFL0JxYTMy?=
 =?utf-8?B?cnVLMmZYS0trQzY0Y2Q3bDJMNGRCVmJENnBYYXdwYmlMRWxYYzhMSCtsQWRW?=
 =?utf-8?B?RWZYTk9FRzBPVW5WeDNIc05BSCtLOUVrc1lPUDF0T0ZQVDI1ZXNVcGlMQmg2?=
 =?utf-8?B?UEhMTmpKREpLdGN2R3ZsLytST0JqY1F3OEVQa1ZiQnZPZE9NK08vMjVQRE9h?=
 =?utf-8?B?UFVNYWYyV1VtQ1Nta1dqZWFBN3ZzdDBQUVd3U1M4WEozK2VQWVl5UFNXUU5P?=
 =?utf-8?B?M2NvSUo1b3F5dVI4djdoTmR0ZEJBY1dwUUJRVkNkUkNrb2VIeCtReUQvV1RE?=
 =?utf-8?B?L1owVnJhTERHellhMTBJdmVueUlRRk51YVdaSmhBb0tXbDZnMTI0Q2NneVcv?=
 =?utf-8?B?TzNkdmFTSkpubGxFMUFvbmR3Z25aaW9BSjBjNEloREFrVWNGLzd1TkpHQXB4?=
 =?utf-8?B?YlJFZi8wV3BMYWFub1ozT0pRaDlsdUJjVmZiQzluVE44SkpQSEZFVE9DUktL?=
 =?utf-8?B?ajhCd2I4RjBWbkhPeXdlSWUzb3JDanV0d2xSMFhON3NOS3VUajNlVnp3a09T?=
 =?utf-8?B?Tk4zaFJpK3VIak9MNnd4RHNUZzA0Mzl5d1BNRFVhc3hrTnNhWXZUOFFYY3Bn?=
 =?utf-8?B?YThiblc1ckVKOVhGR0pqMU5rR1o0Y3pqaWlEOWFLVzZMYTU5UGZpQWQyVy9t?=
 =?utf-8?B?TFBiREwzeC9sQmhJWlVybVo0QmdmNXdyb3JGTXFaaDEzNndyek5PY2JBVzlV?=
 =?utf-8?B?bEFLZ3dXMStmNWh3c1JaVVl4M25hZnB2bSt3WnBzVFRiSG44bDlaTW9Jc1lF?=
 =?utf-8?B?Q040cU82MnlXYjZ0Rk44VFVLcEZVV2h5K2VYbVJ6TEdKQ1pkT3UwczIrS2dV?=
 =?utf-8?B?ZUV0bjd5ZlZ1bUdxZGhMOXF2VHc0bERrS3cvV1ArZVhEK1hOdmRweXlGa3hZ?=
 =?utf-8?B?a0E9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d32a8ff-a28a-4509-6b42-08dbf7438ab6
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 16:42:46.6310
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ad1cJH3Zi3AwZpdgQzva2bKRRpgnJnkMkftXd39wTmiOIoAwPvoE1XGtynGCCVoWTJy5dQ/aoUqY0ZuN/58tvIpym7gtPUJ13cWkHjshiD8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR10MB4100
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 07 Dec 2023 08:42:59 -0800 (PST)

On 07.12.23 17:10, Dario Binacchi wrote:
> It was useless to check again the "ret" variable if the function
> register_host() was not called.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

> ---
> 
>  drivers/gpu/drm/bridge/samsung-dsim.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> index be5914caa17d..98cd589e4427 100644
> --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> @@ -2020,11 +2020,11 @@ int samsung_dsim_probe(struct platform_device *pdev)
>  	else
>  		dsi->bridge.timings = &samsung_dsim_bridge_timings_de_high;
>  
> -	if (dsi->plat_data->host_ops && dsi->plat_data->host_ops->register_host)
> +	if (dsi->plat_data->host_ops && dsi->plat_data->host_ops->register_host) {
>  		ret = dsi->plat_data->host_ops->register_host(dsi);
> -
> -	if (ret)
> -		goto err_disable_runtime;
> +		if (ret)
> +			goto err_disable_runtime;
> +	}
>  
>  	return 0;
>