Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 7 Dec 2023 17:46:04 +0100
From:   Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To:     Waiman Long <longman@redhat.com>
Cc:     Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Yafang Shao <laoar.shao@gmail.com>, cgroups@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH-cgroup v2] cgroup: Move rcu_head up near the top of
 cgroup_root
Message-ID: <65h3s447i3fkygdtilucda2q6uaygtzfpxb6vsjgwoeybwwgtw@6ahmtj47ggzh>
References: <20231207134614.882991-1-longman@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yoh2mfr4t3txcwc4"
Content-Disposition: inline
In-Reply-To: <20231207134614.882991-1-longman@redhat.com>
Precedence: bulk


--yoh2mfr4t3txcwc4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 07, 2023 at 08:46:14AM -0500, Waiman Long <longman@redhat.com> =
wrote:
> Commit 77070eeb8821 ("cgroup: Avoid false cacheline sharing of read
> mostly rstat_cpu") happens to be the last straw that breaks it.

FTR, when I build kernel from that commit, I can see

> struct cgroup_root {
> 	struct kernfs_root *       kf_root;              /*     0     8 */
> 	unsigned int               subsys_mask;          /*     8     4 */
> 	int                        hierarchy_id;         /*    12     4 */
>=20
> 	/* XXX 48 bytes hole, try to pack */
>=20
> 	/* --- cacheline 1 boundary (64 bytes) --- */
> 	struct cgroup              cgrp __attribute__((__aligned__(64))); /*    =
64  2368 */
>=20
> 	/* XXX last struct has 8 bytes of padding */
>=20
> 	/* --- cacheline 38 boundary (2432 bytes) --- */
> 	struct cgroup *            cgrp_ancestor_storage; /*  2432     8 */
> 	atomic_t                   nr_cgrps;             /*  2440     4 */
>=20
> 	/* XXX 4 bytes hole, try to pack */
>=20
> 	struct list_head           root_list;            /*  2448    16 */
> 	struct callback_head       rcu __attribute__((__aligned__(8))); /*  2464=
    16 */
> 	unsigned int               flags;                /*  2480     4 */
> 	char                       release_agent_path[4096]; /*  2484  4096 */
> 	/* --- cacheline 102 boundary (6528 bytes) was 52 bytes ago --- */
> 	char                       name[64];             /*  6580    64 */
>=20
> 	/* size: 6656, cachelines: 104, members: 11 */
> 	/* sum members: 6592, holes: 2, sum holes: 52 */
> 	/* padding: 12 */
> 	/* paddings: 1, sum paddings: 8 */
> 	/* forced alignments: 2, forced holes: 1, sum forced holes: 48 */
> } __attribute__((__aligned__(64)));

2480 has still quite a reserve below 4096. (I can't see an CONFIG_*
affecting this.)

Perhaps, I missed something from the linux-next merging thread?


Michal

--yoh2mfr4t3txcwc4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZXH2ygAKCRAGvrMr/1gc
jpZuAP9RgMwrR6LBFr+2ohXuCMXaICW4Vd3Wj2jt2+aVwhZUMwEAv+h6B/ZFotnw
BWbde0bO3MEumhkx4R695l/j/sSxdws=
=dUG2
-----END PGP SIGNATURE-----

--yoh2mfr4t3txcwc4--