Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <21e1b508-328a-4ec0-9f1f-75773f2686c3@kontron.de>
Date:   Thu, 7 Dec 2023 17:58:25 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 04/10] drm: bridge: samsung-dsim: complete the
 CLKLANE_STOP setting
Content-Language: en-US, de-DE
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>,
        linux-kernel@vger.kernel.org
Cc:     Maxime Ripard <mripard@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jonas Karlman <jonas@kwiboo.se>,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        dri-devel@lists.freedesktop.org,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        michael@amarulasolutions.com,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
References: <20231207141723.108004-1-dario.binacchi@amarulasolutions.com>
 <20231207141723.108004-5-dario.binacchi@amarulasolutions.com>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20231207141723.108004-5-dario.binacchi@amarulasolutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzB1UW9zNXk4NnV5RUc2cnNZaFdXcDlKeE9YR3hEWThpSk9ZZ3NCWUNYcVpa?=
 =?utf-8?B?Vm41akdINzNCbXk0aWlRd0E0emlzdkh2elhDVDlDcHVYaTg1ckEzWDA3OFBu?=
 =?utf-8?B?Z0pWUWMwMzI2aUd5N0lxZm1KN2tzTlJwbWZJRzhYOGVacGJRY2xXUzA4U2lS?=
 =?utf-8?B?WFh6cjMrOE80Y3pyTUN5NjMzZGxPSFFrYit6RU8zcitUcnlZN1J6Y3ozeUFW?=
 =?utf-8?B?MnNzekE0M1dQTXBVajY4T0JjYktRbEVWSHcxZjZuQXI0UU9MNnhVU2VMTVBj?=
 =?utf-8?B?RDdCemhWd0xOWDdlS3Y1WjIrclVNSzhlRk1NZ2JRVUx4WTdib1ZpTGZGaTJ0?=
 =?utf-8?B?NlV0djhaSGFSRlRFZ0FxTGZidThZM01jQXYxVlB4aXVuNzJuQ3cycEpBaTdj?=
 =?utf-8?B?SU1COUZ5MVRHSVJFcG5LTi93THd6b2Z3L1llYml2RHR0eXhVbVUwTVRCR0pG?=
 =?utf-8?B?TXFhSlZwdWxoaVo2V29vQUp1Uzh0dURsMkJkam40TDJFYWxkT2FrVUxUVVdz?=
 =?utf-8?B?bEticjIrTlJNdkVhTEJORVBOWkhQL01HdThqMmNOb09wSjE3UG1vQjNtOU9l?=
 =?utf-8?B?M1pWZzdEN28vR1ljV0QzclRzT1BKUU9FcUFWNGVkcnFlemJldXlhZHhtZ1BO?=
 =?utf-8?B?dmpVM2VIVGFJN3Q4QTV3VFB5a0JsVElaTWdqZnRmQmtVM0UvTTVacjFsNHF4?=
 =?utf-8?B?NmUvL1ZtYVh1RkdaclZveDBtTmdPYndMNHF6UllsMFZxaVF1dS9waXM3M3VN?=
 =?utf-8?B?SFo5L1BQb3pod3E4Qzd5MFZrUHRScy9wd2txV3RGbjVDM1NCSFpwc1c3Ykx4?=
 =?utf-8?B?am9HL2lVNlBOZUdGMDV6a25VSTBIYzFGazFPdEpOSmxOeTRIc1djRnJQa3pk?=
 =?utf-8?B?R1BoY1krUzZZLzZJR3BPRnc3czBLL0hyMW5WNUtoYWxVS1l2d1Q4NU9sWStR?=
 =?utf-8?B?cFZCbVBzTGd4VXdYQktYdXBkU3l3LytZSk03M2k4THltSFM4Y0NENDk0aTZQ?=
 =?utf-8?B?Z1czZ3NiMWdFMGFObjBxTWptOU81K3VFeGxaeUJOK0NZbnVYTWIzZ2JTSmJk?=
 =?utf-8?B?RmVveGFISkNuM3F0bFhRaFpKckJ4Y3hGRDRyQVNJL29VVmt1MXFGbVp1QVBi?=
 =?utf-8?B?d29OSEpPTVhQUVhZUm1LMHBQYXN4clNTNW9Tb3FNOGhrbVk1NDFpRUFudDlJ?=
 =?utf-8?B?T0FZS2l1QVB1WkZQclZ0RE1mbC9jZlpIMWdHUDJiN0tld1pZa3BXbjBjVTlS?=
 =?utf-8?B?T2JqTi9hYTIzYzU0MGZ2UEgxYUVQNWZnellRai9zSFRtc1ZJSWNOT3pYeDB2?=
 =?utf-8?B?MTN6eW15VGhLbWFDRi9pMkZQRWhiWHgzTDdqR21ZcWt3OUpNLzdYSW5SdDdZ?=
 =?utf-8?B?NGdXU2hRQ01pRTkvcGxxN2NDZk15UGwxZDF5SHY4bTllNkYzUjZYWnZZeVRl?=
 =?utf-8?B?TFNrMUhDNmF0cHZ6U2ZnQUlPdW9kcEZrZlErMURyU0l3WjhySkFPcXkrZzNT?=
 =?utf-8?B?NHhROWxYSmFxL2twczdSWXF2aC9SSGNlTGRKNWoyaTdDeHl2eEsrQklnZnl2?=
 =?utf-8?B?c25iSVAvZzNUdzJKYkQwSlBhcUtlQnZDNm5QVmIxTWUzNVZidGZqSXJnU3B3?=
 =?utf-8?B?cjBweGVtSHBkOEdpeitlOHpCLzBoTi9UVFVpU1dDYk9JcnBET25QMlJUeVV3?=
 =?utf-8?B?cmN0Umk4MHJwOURiVHdsTk9ETWNzVUF3N1RCN1JoV3lmWEtBTVJHeE5qSlli?=
 =?utf-8?B?dk1WbnVqVUMxZ0lUeDFBK3M2OVZIZVoySVI1ZWVsQmdRMExZQnhuTE1oS3dB?=
 =?utf-8?B?VzFicE9vcHFjSENQbG5MQkpkRnlNWnd0ZkUyRzNBOWwxZ2dvU25Gb2pCOWFC?=
 =?utf-8?B?STgwOGU5dVZjcEVaR3QxbEFGNHJmWFIyUWlBbitIN0lrOUlZN0IzWEd2WHg4?=
 =?utf-8?B?ekhtM1ZXQUJScVNHZk5KRGZyYXRMQ200elR5L0tTU3F2eVBxaStjNW50Tlk5?=
 =?utf-8?B?K3ZaYWhOK0lHWE0xbmVzZ0p1Y2ZtQUhKQnltNDdnUGRXSHNXQnBZZlV4dy9H?=
 =?utf-8?B?NE5sNjJZUGp2K2hRSW1zdWxVTFAyNXNRekJIRS9zT3daRWlSVUhCSm52SGkv?=
 =?utf-8?B?OC9NejVRSzdDcGVtbGRFRk41dngwM3RaQlFvZkhLRlVsZFFudW1RTHZrcFl1?=
 =?utf-8?B?b3c9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: cd2430ba-d50d-46b2-4bb1-08dbf745bbbf
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 16:58:27.8693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M2M9XrEWrBYaumrpLfO7fSEhv1i2ZrMk/4ovuF+u+m+d1JvTkdkrF9q/P9coJgPXCMLAm+hEnJgkw12eCvW0JBkABtVJl0BZgEfMEQDht7s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR10MB3760
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 07 Dec 2023 08:58:39 -0800 (PST)

On 07.12.23 15:16, Dario Binacchi wrote:
> The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp
> platforms (i. e. not exynos).

This also affects i.MX8MM, so better just mention i.MX in general in the
commit message.

> 
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> 
> (no changes since v1)
> 
>  drivers/gpu/drm/bridge/samsung-dsim.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
> index 15bf05b2bbe4..13f181c99d7e 100644
> --- a/drivers/gpu/drm/bridge/samsung-dsim.c
> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c
> @@ -96,6 +96,7 @@
>  #define DSIM_MFLUSH_VS			BIT(29)
>  /* This flag is valid only for exynos3250/3472/5260/5430 */
>  #define DSIM_CLKLANE_STOP		BIT(30)
> +#define DSIM_NON_CONTINUOUS_CLKLANE	BIT(31)
>  
>  /* DSIM_ESCMODE */
>  #define DSIM_TX_TRIGGER_RST		BIT(4)
> @@ -945,8 +946,12 @@ static int samsung_dsim_init_link(struct samsung_dsim *dsi)
>  	 * power consumption.
>  	 */
>  	if (driver_data->has_clklane_stop &&
> -	    dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS)
> +	    dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) {
> +		if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type))
> +			reg |= DSIM_NON_CONTINUOUS_CLKLANE;
> +
>  		reg |= DSIM_CLKLANE_STOP;
> +	}

I really wonder what the difference between DSIM_NON_CONTINUOUS_CLKLANE
and DSIM_CLKLANE_STOP is.

If Exynos only has the latter, it's pretty clear what to use. But as
i.MX has both of these bits, should both be set? Or is setting
DSIM_NON_CONTINUOUS_CLKLANE enough and we should leave DSIM_CLKLANE_STOP
alone?

Maybe someone has a clue here. The description of the bits in the RM is:

DSIM_NON_CONTINUOUS_CLKLANE - Non-continuous clock mode
DSIM_CLKLANE_STOP -  PHY clock lane On/Off for ESD

>  	samsung_dsim_write(dsi, DSIM_CONFIG_REG, reg);
>  
>  	lanes_mask = BIT(dsi->lanes) - 1;