Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Suman Ghosh <sumang@marvell.com>
To:     Zhipeng Lu <alexious@zju.edu.cn>
CC:     Chris Snook <chris.snook@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Simon Horman <horms@kernel.org>,
        Yuanjun Gong <ruc_gongyuanjun@163.com>,
        Jie Yang <jie.yang@atheros.com>,
        Jeff Garzik <jgarzik@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] ethernet: atheros: fix a memleak in
 atl1e_setup_ring_resources
Thread-Topic: [EXT] [PATCH] ethernet: atheros: fix a memleak in
 atl1e_setup_ring_resources
Thread-Index: AQHaKRsv7nzqkhz5D02RUtwgtknIiLCeDKvw
Date:   Thu, 7 Dec 2023 17:08:15 +0000
Message-ID: <SJ0PR18MB52161F73B08DA547F7A8F3B8DB8BA@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20231207143822.3358727-1-alexious@zju.edu.cn>
In-Reply-To: <20231207143822.3358727-1-alexious@zju.edu.cn>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E+HxGOYSb0UTFokqPEL2QiszhOZ60LmXu+/snzRbgofIxKia52IoR+n6JeJ6?=
 =?us-ascii?Q?AC+SBzuKUP89cbcy8mb/kws0xdEtiJMBnH/yEUXyFipSXpr55xx5BqVlxiZx?=
 =?us-ascii?Q?SsA8fD+KCM82ImE0fysvDpRpLTUaHeG685pB5+gJt58qyzo7kCOcQlgQRsKf?=
 =?us-ascii?Q?czPwYKAxnefDao0X2VJ4kfJ+J+zxdZLZWuEiaoyA9yfwBIl74qruFbYO9Ow7?=
 =?us-ascii?Q?B+NWDKmT5NCWmAatOe4TkFC2GfFWRmtc24jCr9YWl2w2rTxzEf1ZQzKK5f8Z?=
 =?us-ascii?Q?i1vnJfD6btUBr5JeCRHpd4iCdmO4Ht87wQ29Mnxk03C8cqDTM423AAEOI6J5?=
 =?us-ascii?Q?C5j6KwHQ0kAPfjpdSGXHHlcat4YbKZCaeI6j2QLOsoXKcdGCjBx2eYY6R7e6?=
 =?us-ascii?Q?Iedl1j2wOcnr7p1/iF09yucz02e/vos417Ja4akJM45YhWZJZyxzPerK76Js?=
 =?us-ascii?Q?XEbZSO+FXn8qcclYKJMpZhPkirL3qDIlwJ7DeRxe3hxXu2bPf5GSw7/VC0wb?=
 =?us-ascii?Q?h100bA0qLy5Tp5OYu9QQwV6l48b+SvN/0EZ4T+Uzbus7aM/CVTkYPzOVMem7?=
 =?us-ascii?Q?bIhCRKIhW0x1H0dTtFiZt/4/SJ99cpoMnF6hkVWqOIr+P5ZNZmvBLlLn5ccl?=
 =?us-ascii?Q?VJaVjBRH6hE8cl25KqilkSbryypjKpfxistgeShK6VWXKU6gYC1oQM/u6aFZ?=
 =?us-ascii?Q?Ybiz4St9hOmNfJoHSZXVB47MGpaF+xfYcql9Dtbr/D/DvCdf/eGpUbBLW10/?=
 =?us-ascii?Q?+E/kfwDFxcOdomqMtqgfiC2jzYU8uMcOqZonOmjPuGTsWaVW7m7zQSvZICXm?=
 =?us-ascii?Q?ozC0/oFcRTPRFyf4hzJVtojBsyhUy3vzuNtSGPV8l90FyDlSctjLkQfUlnop?=
 =?us-ascii?Q?DIhiw5vn2XzKdknCFxJXpHjDB/tkmlrYgcw9YnIt1wRCKfrnrwiinn0NMkDE?=
 =?us-ascii?Q?8QJCgamNiUl30mNH1Xu4g3UhgV9XzPR5nZK0RxzCzlk8DHPhhWmtCx6GZtOm?=
 =?us-ascii?Q?rt9C71ZksMkRVyXm3M0wItfHIqdWv7FbfdQi0we+EFYcUk9vfal6/OaLvRK8?=
 =?us-ascii?Q?kEO94yI/OAuu7OD63Rlah2sAY8w4SVj9IdZ2OxxgiQFJCxPCQBZ5jX+FQ9uZ?=
 =?us-ascii?Q?4GqlhwH3ZJTNy/ymO3gXADoS4qwIi3YuodK+fE0iWTj3wTre0WXe2eKGbW0Q?=
 =?us-ascii?Q?/vNGU/HfmiSm3nh+AXosMPRNiKFqkXxeyBNaeIzEQr+ZsK4SkW/VHZFPyzvp?=
 =?us-ascii?Q?+iClEBe7Ov23cjEbVD0dpROSRN0ms2iTO1bLAdRW+hvwTm7B4HQKG4wQN5xC?=
 =?us-ascii?Q?Wuj4+qUbDp9FeVG9z6mT9OqLSxB9RHvYi72SZowBBTn0iFA3kR0x4OI4+dHm?=
 =?us-ascii?Q?3ehhoShmKmL6cBgKffT+J6/oqLUQqy6pA5jegrHwMwHTzWxTvyC38Muph24M?=
 =?us-ascii?Q?/CgSAa+Uivkc26I+OOeUykJg5Q50lkfq5VTEb/8nli4mskKXn/caj0ii4n+N?=
 =?us-ascii?Q?vOhEV2A9hqJr0j1NO4QXoySjn6/1wq+msVcLSiDiJUCKh26bmi4RZOlYpaBW?=
 =?us-ascii?Q?jrPFDof/1pX+8uDx78JnzDTbZTsflsNrCIjNpK3G?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d61cfe9-9436-486e-bd52-08dbf7471a0f
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2023 17:08:15.4886
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j3ori12JhBQUpoeVCx1gPQu18PyyWSIg4stCgXzEM5L7jb63uvk4gbIRhHUlng9Mx5XQNgrbV4d9+9m1ffRlnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR18MB5588
X-Proofpoint-GUID: 7bjBNcryJIHSTaB_6Y8YcZe51i0Z95d1
X-Proofpoint-ORIG-GUID: 7bjBNcryJIHSTaB_6Y8YcZe51i0Z95d1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-07_15,2023-12-07_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 07 Dec 2023 09:11:07 -0800 (PST)

>diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
>b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
>index 5935be190b9e..deb5a3f207cc 100644
>--- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
>+++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
>@@ -866,6 +866,7 @@ static int atl1e_setup_ring_resources(struct
>atl1e_adapter *adapter)
> 		netdev_err(adapter->netdev, "offset(%d) > ring size(%d) !!\n",
> 			   offset, adapter->ring_size);
> 		err =3D -1;
>+		kfree(tx_ring->tx_buffer);
[Suman] I think we should do tx_ring->tx_buffer =3D NULL also, to avoid use=
 after free?
> 		goto failed;
> 	}
>
>--
>2.34.1
>