Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1807507rdb; Thu, 7 Dec 2023 09:13:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEu1xnifma8zGdzbgi9G2P28k2fhsWz//LN4iqjaFcwRZmag6verEM4TrjxTKsCa7PgabU9 X-Received: by 2002:a05:6a20:748a:b0:18f:97c:926b with SMTP id p10-20020a056a20748a00b0018f097c926bmr2459879pzd.80.1701969207672; Thu, 07 Dec 2023 09:13:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701969207; cv=none; d=google.com; s=arc-20160816; b=08Rdw7P6agt16bI2jkb3ebmfPRftuPb4lrPWziWarJ4Dd5SYp83rwP7TKxJGpDaCx9 vLrMo6zTtNLZ6iwDEGlb/13LnLVRpASofFn42GA5MY+d+OJj0JNw84CMB1qWrYexnhPB jBOI9ijV7U2Q/s3sfyChzlV6AMbj1doFbVGHrTabcjShLTAS5S5FNLXP1tF+pVvQ1FgY fKuUcKFrUN4s7w/TYU+dFBotmpNthS3WaM9kOTCvn4PaSlu7TSb5vqgr3Ik/YyyLZsro 2D58i7P7ckBTQbjc47ds35Ol3e6XzUB0fiKtTp8gB2qBkDGd5GBPaL0RHNmcdkn7+mAJ jZtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=FagnchcKBAODMcKWhQg86dyB2rRLvNvfqi/0fWTS4Lk=; fh=jvfVMV2RW5BoX5Gan8vRQ7k9FO4OD6rayMGtUR8297E=; b=ZCxdBpjQbArwHAc3UhZtAnWP8JqHPgBDW91QLy7Wcim6S2IgrfSkMZBJJ4AmQsa/1m o7b4wYlqJMM1Fdl9oDjSZUPK/jBeoxDRbqe/WLwA/Ve7HBy+LtDX2oV1X+Vj/9l0YnxU 3y1ehZKL1RRr/cvtWDGEeTBcdGsvjTDGQ2b+W6rSvTT2h02sUmYi1roz5ROG+5lZ8dQb k2bi3xtqag39Nteb5KNBox4hjO21G+JUz0VGEMTQ/AwDyjPDNgsMIb1aHRyKOxbCawT7 EnZu/rP51qsiji9dxRSPKQlJpBAymE5lSAzo+1k9ryG39ep0qxd9eB2IApYsgxW4K2P0 xpuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DnuPJnxD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id 20-20020a631754000000b005bdfdf1c44dsi24722pgx.126.2023.12.07.09.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 09:13:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DnuPJnxD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 5993D82A5157; Thu, 7 Dec 2023 09:13:18 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443223AbjLGRNA (ORCPT + 99 others); Thu, 7 Dec 2023 12:13:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjLGRM6 (ORCPT ); Thu, 7 Dec 2023 12:12:58 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 391E2E0; Thu, 7 Dec 2023 09:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701969185; x=1733505185; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=sdZDQhsABjBMs2ZU+jeFXjhRmCQapnRfv9iegKEmDDs=; b=DnuPJnxDDzHEGN8z49RoDDfG8Arh5kkPjPkY9QAEHvrPLSyumbk6RQbD 8ShtAPHeN2T5wc4pN9tE8yhl8VBl8LVEMkym6+9aBUozP/lNk6ONw1BdE wH2G/c3/t687ARXYGXLLpN2QqV8z2AxeTp7LdAvUqnEfUmosEfwdOuP4x DkOovKdtQp9ynTZBRokF1TXZMqwIp0w5ToYzQhtmnR+Rp8ClSycT1F2aj nHWMbCunzNxvesE2OSITGjLzyIcyQsZy+fwUijukq2zInO2TaUEwneLy7 KalbLQXh07cywRGnOEtAkNNLoz/rZORNMiQ0jFqBGQ6XGgdixCiNR+wfr A==; X-IronPort-AV: E=McAfee;i="6600,9927,10917"; a="374432049" X-IronPort-AV: E=Sophos;i="6.04,258,1695711600"; d="scan'208";a="374432049" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 09:12:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10917"; a="721547226" X-IronPort-AV: E=Sophos;i="6.04,258,1695711600"; d="scan'208";a="721547226" Received: from adlilak-mobl.amr.corp.intel.com (HELO [10.212.147.208]) ([10.212.147.208]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2023 09:12:41 -0800 Message-ID: <53592a3a-3d96-4aa1-8357-ec595f59c5f3@intel.com> Date: Thu, 7 Dec 2023 09:12:41 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/vmware: Add TDX hypercall support Content-Language: en-US To: Alexey Makhalov , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, hpa@zytor.com, dave.hansen@linux.intel.co, bp@alien8.d, mingo@redhat.com, tglx@linutronix.de, dave.hansen@linux.intel.com Cc: x86@kernel.org, netdev@vger.kernel.org, richardcochran@gmail.com, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, zackr@vmware.com, linux-graphics-maintainer@vmware.com, pv-drivers@vmware.com, namit@vmware.com, timothym@vmware.com, akaher@vmware.com, jsipek@vmware.com, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, airlied@gmail.com, tzimmermann@suse.de, mripard@kernel.org, maarten.lankhorst@linux.intel.com, horms@kernel.org References: <20231206071527.59171-1-alexey.makhalov@broadcom.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20231206071527.59171-1-alexey.makhalov@broadcom.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 07 Dec 2023 09:13:18 -0800 (PST) On 12/5/23 23:15, Alexey Makhalov wrote: > +#ifdef CONFIG_INTEL_TDX_GUEST > +/* Export tdx hypercall and allow it only for VMware guests. */ > +void vmware_tdx_hypercall_args(struct tdx_module_args *args) > +{ > + if (hypervisor_is_type(X86_HYPER_VMWARE)) > + __tdx_hypercall(args); > +} > +EXPORT_SYMBOL_GPL(vmware_tdx_hypercall_args); > +#endif I think this is still too generic. This still allows anything setting X86_HYPER_VMWARE to make any TDX hypercall. I'd *much* rather you export something like vmware_tdx_hypercall() or even the high-level calls like hypervisor_ppn_reset_all(). The higher level and more specialized the interface, the less likely it is to be abused.