Message-ID: <475561E7.80304@skyrush.com>
Date: Tue, 04 Dec 2007 07:19:19 -0700
From: Joe Peterson <joe@skyrush.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071127)
MIME-Version: 1.0
To: linux-kernel@vger.kernel.org
Subject: [PATCH] echo ctrl characters on INTR/QUIT/SUSP
Content-Type: multipart/mixed;
 boundary="------------000004040002060903020005"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1983
Lines: 50

This is a multi-part message in MIME format.
--------------000004040002060903020005
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

The stty setting, "echoctl", directs the tty to echo control characters
as a normal letter prefixed by "^" (such as "^C" for the default INTR
setting).  Linux does not currently echo for the INTR/QUIT/SUSP signals,
whereas all other "unix" variants I have used over the years do, to my
recollection anyway (I recently tested: Solaris, BSD, Mac OS X).  I find
this a really nice feature, since it becomes very clear at a glance that
a terminal process was interrupted explicitly rather than finishing
normally (when I am running many things in different windows, it's nice
to verify which ones I interrupted).  It's just nice to see that echo
for positive feedback, and it seems to be standard OS behavior.

If you try this patch and don't see the echo, make sure echoctl is on
("stty echoctl").  I have applied this patch to 2.6.22 in my tests.  I
welcome feedback, as I have not seen this issue addressed before.
Please cc me at my address above on replies.

					Thanks, Joe


--------------000004040002060903020005
Content-Type: text/plain;
 name="gentoo-sources-2.6.22-echoctl.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="gentoo-sources-2.6.22-echoctl.patch"

--- linux-2.6.22-gentoo-r9.old/drivers/char/n_tty.c	2007-12-03 16:25:05.000000000 -0700
+++ linux-2.6.22-gentoo-r9/drivers/char/n_tty.c	2007-12-03 21:58:44.000000000 -0700
@@ -761,6 +761,9 @@
 		if (c == SUSP_CHAR(tty)) {
 send_signal:
 			isig(signal, tty, 0);
+			if (L_ECHO(tty)) {
+				echo_char(c, tty);
+			}
 			return;
 		}
 	}

--------------000004040002060903020005--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/