Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Suman Ghosh <sumang@marvell.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Zhipeng Lu <alexious@zju.edu.cn>,
        Chris Snook <chris.snook@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Simon Horman <horms@kernel.org>,
        Yuanjun Gong <ruc_gongyuanjun@163.com>,
        Jie Yang <jie.yang@atheros.com>,
        Jeff Garzik <jgarzik@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] ethernet: atheros: fix a memleak in
 atl1e_setup_ring_resources
Thread-Topic: [EXT] [PATCH] ethernet: atheros: fix a memleak in
 atl1e_setup_ring_resources
Thread-Index: AQHaKRsv7nzqkhz5D02RUtwgtknIiLCeDKvwgAAKkwCAAALocA==
Date:   Thu, 7 Dec 2023 17:54:44 +0000
Message-ID: <SJ0PR18MB5216F502703DA2B49B013BC7DB8BA@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20231207143822.3358727-1-alexious@zju.edu.cn>
        <SJ0PR18MB52161F73B08DA547F7A8F3B8DB8BA@SJ0PR18MB5216.namprd18.prod.outlook.com>
 <20231207094220.77019dd0@kernel.org>
In-Reply-To: <20231207094220.77019dd0@kernel.org>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?H5AZVM9le1wxO/zU76hxFL26JtKSppyDBnGyVZoWilAsoJEpEh887Too+R2O?=
 =?us-ascii?Q?o/2s1cEy+aJCtvpoW9oAzn+mNmiaUApSDl1pQAaqi11PktCfdDGMxTLsb5+X?=
 =?us-ascii?Q?WLRJh4KypZ27bxwq9rD85IhpAyg7A5M10QltxH78I3XeUGAu16JTiJ4orsPU?=
 =?us-ascii?Q?sat1tSyFeSz0bNnDelW7K/LZogOILkID2t4I+2RMDJDCAKeBJb0vj5eulkb7?=
 =?us-ascii?Q?R78ND7Ixtjh7bnXIfjRNnOChg05bhsNQTiVWtfDAbhM/Tp1M2tfk3mYV357J?=
 =?us-ascii?Q?/Kcn/b2ctmRG1Uk06wRTZc5fiUdoDYN+zlyhnznSKdcyU4UIunLl0F5IQUgK?=
 =?us-ascii?Q?z7eupw+qcdhwtUuPvEeHWuNjybSv45Kl4DIZZ/n9MMYncS3MuALvPEkCtWYQ?=
 =?us-ascii?Q?dhs7U2mcctB1renKWE7CiOxlmcTvhswJuCvjnvCXZg7jjGJwO06P+fE/FtrA?=
 =?us-ascii?Q?BsRc1ZTYPVgbkqaj7gokFNECFlwUSW95Olmq4M94mpAf8M8vpdawpEMDi5kg?=
 =?us-ascii?Q?VTGwdiRygtQga4gpDXrBr6JPUm61lnY3f6uszA6pIxQYk+wAfv2GcyiwKcCn?=
 =?us-ascii?Q?fmI8ptF1zhcAKaSuq7DMW/qEHi04+y3rY+0vCln2gI+qql83RntKesva0Yb5?=
 =?us-ascii?Q?c/BVjg96D4wA1rGWJUnI3sq6STfIT/NqimoHBuxxHqLBSo5HSpJtPtYEXt5u?=
 =?us-ascii?Q?Xq18UxgfHY3sfiHdRJcHdMG+tn9ADXA2LlNvfqUEBrC3pJH9QpGPc6pqo/GN?=
 =?us-ascii?Q?DJ9wSI5OnANGeXdTdVqnBUUCNs8BZW/P8rTUnLi3zbBHoq/mP6q9zdmIVBny?=
 =?us-ascii?Q?jNbg2lbbURv6+xi9ZK9UyWCbFU4DiDurnWeoZl2vH61GnpQnEexD2YxNxlJo?=
 =?us-ascii?Q?ktzsHRRXOCY6I11TOLvRh3R7uitZ2ANO+vaWYu7NN5bF3TA7Mq+lpSSkfvet?=
 =?us-ascii?Q?v0qDUYUy9RE0YoQ552SOVr3lv2SZbAsrbHBZ+MXSIr5ZFzKq1VMHNiDk7lW4?=
 =?us-ascii?Q?HWANZfDN54jQfdkVMVIpRpPHoY5HloD/QXuqdQaOeMcrlzYYOfW37DjmxXI2?=
 =?us-ascii?Q?icdh4h6UNmXsAYFZqztNImryrke///g6+slXP/FjU/M80IkODQZkZA2ZB62w?=
 =?us-ascii?Q?cD3mdu3JOrFN42uoJ6Wf6vye5Qa9zoXQCWlnMkjcsV8hBVZkkw/F3KBUPLEI?=
 =?us-ascii?Q?tsWy3dzJ96VOeunD8pYE3tlP8C0qq646vgsPwt7Zp4utLXBnRmpYzyf0o28T?=
 =?us-ascii?Q?OvYYsJ8ZiKWjVQSu5Mt6XxUNlEMkN30ucFwuLuBJDemBoVSi1AWPejcdA9wF?=
 =?us-ascii?Q?sSA0Nnmkq6lJfA50rt6XOrAddZ/kAEwP/HRzQ23STkNsXSJuJ+o761lEfIaR?=
 =?us-ascii?Q?Wu0gb+yR0PQ3mXi+KLF0x55XubemNdofE4EEEo/MPaLYf6Zb54HU6127JiT1?=
 =?us-ascii?Q?3c1jJ+3hhqOZ/lWGlFUqA9AsHchLJ8iSscskIQQcvsmJssadE8F3DfQkaIbf?=
 =?us-ascii?Q?iyagrlxpjJuVD/og3MMESwzWb1UdvHkLhfYG9vmfiMIlrQCNukMg2rY39rBW?=
 =?us-ascii?Q?tq4NeX6ng9jNyYTPkl6SR9muzM5qGdQmGP7idIMg?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 515a206a-cdb6-4c72-c1c2-08dbf74d98b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2023 17:54:44.8951
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 76X95dOZ132RYlfoJRz7aGm5/m6zr2KtLUI7by97y206YlurikKpYA9H+0hOLbuh2dTdEafr8faQBU5DgKjWrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR18MB5780
X-Proofpoint-ORIG-GUID: N0HUXQJ0piIYrYhPyXPfm2kqzCZkKQ5M
X-Proofpoint-GUID: N0HUXQJ0piIYrYhPyXPfm2kqzCZkKQ5M
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-07_15,2023-12-07_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 07 Dec 2023 09:57:26 -0800 (PST)

>On Thu, 7 Dec 2023 17:08:15 +0000 Suman Ghosh wrote:
>> >+		kfree(tx_ring->tx_buffer);
>>
>> [Suman] I think we should do tx_ring->tx_buffer =3D NULL also, to avoid
>use after free?
>
>It's up to the driver. Some may call that defensive programming.
[Suman] Agree. I pointed it out since this driver is using this approach at=
 other places. But sure, it is up to Zhipeng.