Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Thu, 07 Dec 2023 18:58:12 +0100
Message-Id: <CXIAOLFK6TFO.1J0V4C5I03Q5F@bootlin.com>
Cc:     "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Russell King" <linux@armlinux.org.uk>,
        "Jiri Slaby" <jirislaby@kernel.org>,
        "LKML" <linux-kernel@vger.kernel.org>,
        "linux-serial" <linux-serial@vger.kernel.org>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        =?utf-8?q?Gr=C3=A9gory_Clement?= <gregory.clement@bootlin.com>,
        "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
        "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
        "Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
        "Tawfik Bayouk" <tawfik.bayouk@mobileye.com>
To:     =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
From:   =?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>
Subject: Re: [PATCH v5 2/9] tty: serial: amba: Use linux/{bits,bitfield}.h
 macros
References: <20231130-mbly-uart-v5-0-6566703a04b5@bootlin.com>
 <20231130-mbly-uart-v5-2-6566703a04b5@bootlin.com>
 <2023120742-argue-slighting-6120@gregkh>
 <CXHZXP7XVD0T.24N3YDLX7I929@bootlin.com>
 <42e8faf-5293-18e4-3877-25e4d094f1d@linux.intel.com>
In-Reply-To: <42e8faf-5293-18e4-3877-25e4d094f1d@linux.intel.com>
Precedence: bulk

Hello,

On Thu Dec 7, 2023 at 10:56 AM CET, Ilpo J=C3=A4rvinen wrote:
> On Thu, 7 Dec 2023, Th=C3=A9o Lebrun wrote:
> > On Thu Dec 7, 2023 at 2:37 AM CET, Greg Kroah-Hartman wrote:
> > > On Thu, Nov 30, 2023 at 03:07:14PM +0100, Th=C3=A9o Lebrun wrote:
> > > > The driver uses bit shifts and hexadecimal expressions to declare
> > > > constants. Replace that with the BIT(), GENMASK() & FIELD_PREP_CONS=
T()
> > > > macros to clarify intent.
> > > >=20
> > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > > Reviewed-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> > > > Signed-off-by: Th=C3=A9o Lebrun <theo.lebrun@bootlin.com>
> > > > ---
> > > >  include/linux/amba/serial.h | 248 +++++++++++++++++++++++---------=
------------
> > > >  1 file changed, 127 insertions(+), 121 deletions(-)
> > >
> > > As 0-day had a problem with this patch, I've applied only patch 1 of
> > > this series.  Can you fix it up and rebase and resend the rest again
> > > (while adding the collected reviewed-by that some patches in this ser=
ies
> > > had)?
> >=20
> > So the issue is this: the header file gets included in
> > arch/arm/include/debug/pl01x.S that gets included in arch/arm/kernel/de=
bug.S
> > (see #include CONFIG_DEBUG_LL_INCLUDE).
> >=20
> > I don't see any easy way out of this, so I guess it means the patch mus=
t be
> > dropped. If someone confirms that there are indeed no solution to have =
BIT(),
> > GENMASK() & FIELD_PREP_CONST() accessible from assembly, I'll send the =
next
> > version.
>
> Yeah, it seems to require UART01x_FR_TXFF and UART01x_FR_BUSY, plus=20
> UART01x_DR and UART01x_FR that are not touched by your patch.
>
> I suppose the rest might be convertable though..

Thanks Greg and Ilpo! v6 has been sent.

Regards,

--
Th=C3=A9o Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com