Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Thu, 7 Dec 2023 12:06:28 -0600
From:   Aron Silverton <aron.silverton@oracle.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Saeed Mahameed <saeed@kernel.org>,
        Jason Gunthorpe <jgg@nvidia.com>,
        David Ahern <dsahern@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Leon Romanovsky <leonro@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>, Leonid Bloch <lbloch@nvidia.com>,
        Itay Avraham <itayavr@nvidia.com>,
        linux-kernel@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH V3 2/5] misc: mlx5ctl: Add mlx5ctl misc driver
Message-ID: <uedlocmp2guvvhgxe2cjrjog3qf6pd7puj7idpygxxpjrnnj2p@nqmg66juf6xm>
References: <20231128175224.GR436702@nvidia.com>
 <20231128103304.25c2c642@kernel.org>
 <ZWZJGF7moDM_k6TU@x130>
 <2023112922-lyricist-unclip-8e78@gregkh>
 <oxtcvxwbj2hzv4lxnxubo3hoxn7diyzhm2oj3tsw2toxbc3og4@ddglhm6r3oa5>
 <20231204185210.030a72ca@kernel.org>
 <fgalnohzpiox7rvsf3wsurkf2x3rdtyhwqq5tk43gesvjlw6yl@i7colkh2sx5h>
 <20231205204855.52fa5cc1@kernel.org>
 <kakenvblxlgrkjvcrwfflnkm6n5fpxgr4qifwkdttjascth3te@57us7mblobjz>
 <20231207092329.3ec04dca@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231207092329.3ec04dca@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cQV2tW3M3eFLBjGDDWXblCkmLqdJubuywJ6uJhM6xTkQ2DIW7zyemmLtopRx?=
 =?us-ascii?Q?UnbY/y1gXmowWdduZBTO1LX5cg95D9AaN+szl3OsCEP30F11ii4NBJoYzIsY?=
 =?us-ascii?Q?BezoNAmQRdKyY+NhTkY+aZgEt1sHsSauh1E5mP08PdRHjAuxBAu+Zjx3LIEz?=
 =?us-ascii?Q?8oOyX5c9cT5nwEuWrfm4qibfiRUJwWeTaL37bTFkVGkiGG5bWT4tSOnRBPUG?=
 =?us-ascii?Q?1d/Fmx2Ho/E75wbjbYwECdIC+bVdGqRm4C7bSG1rO6+FQXLO7JKBzB67RzEX?=
 =?us-ascii?Q?5iikCH0rLiLzoJ/wblyHk/GhHd6/23nvjLz+2ASUX4szE+J26kNzz3KjQMXT?=
 =?us-ascii?Q?m88bIKVVXHXkawQy2/oRaQDVu3t4UWdgKbSqP1nW3B+8GJc7u6B2DVOd+zv2?=
 =?us-ascii?Q?91wj3hD3feXz3JDAwiAH0se/1j8jmH3Xk6TArZajWw4nQ5VSx5spiHelIV8j?=
 =?us-ascii?Q?DkUSF5stEphgi0BoMbVawPP6Fqjp05jZw6vr22rPyB2to2GiF8cbVEVkGH79?=
 =?us-ascii?Q?aD9BRRkVIVE3vpeAsvYpHereyxCzLO+7a97h7t9jh6n2YWJZwb+fI66NTWwT?=
 =?us-ascii?Q?BSJkLT7afC6SzOGg8z3TbSpkiKiW6KUkCXgtggy8D9ZYPQ6VedSayARKE0Kb?=
 =?us-ascii?Q?GWdekGH4G/oKwBrVEMW8kZvXkaCeYnY8u3HmMCufutOUbOX+RPiImqWyeeH7?=
 =?us-ascii?Q?gqz4GjwBSQQIWpLsjT88IqXPavZU7snawdPdkUCkwAz972JP+JjoHG3xI4py?=
 =?us-ascii?Q?EhioA7X1b+woT7Fyxa6aQI4eDp8d4L5kRVb/ORqMX29//bSM8+Ymk9rGH8/2?=
 =?us-ascii?Q?t+yj9qr4kewZrKb9uBhGnWDrsWpyVMKRHrenklgL1W0uoBtcOZnRnxZbU6Hy?=
 =?us-ascii?Q?jzxDJmaxkCCU0z/tPnHj7juvonqEbu9B41HHQZaDpvHQCxzrAU3/95W1yipo?=
 =?us-ascii?Q?NItfwD2pv8oV7sPGP+OkLBR1+SKL3lbq6FeIWPTIU5iXuF3eiuXVaYx5+ScE?=
 =?us-ascii?Q?s8PO+t4k1qw5MBI1apP/nvcGrG6pTKtkRs4oVumtaH5clDAHtP0K/mHnq7qk?=
 =?us-ascii?Q?zAgqXiXmBAbQDqKbiPZuX9eQJdLx7uT/netRIIW53oprdCO3+25bRQZQgxDC?=
 =?us-ascii?Q?2SIl6PndGVjSGqKDDL+xCehl+gFsbsTX48KTEbMmpXYZj3ObLl7RlBhpeMjh?=
 =?us-ascii?Q?wf8a2EebcNXf/hTtGXZ/Im0rHj8JlVmXeZEMXgj5tCQIggWN24jBFAvETPd1?=
 =?us-ascii?Q?t/6TDHMcb7UdjqnQwKxMD+VEztwuP3nr652rZeceK5JDtuVSZN3evmeD3E8j?=
 =?us-ascii?Q?dUyh4mFHQIseOqvYvAnW033lPT4/p2UuelWmDxQiBJLycCwyGJ3ugoGSmOgZ?=
 =?us-ascii?Q?m6w5UiYFuyzvXDQQQCcmqfK0ZlZVQNpwl3Pc/Usn3JKSw4s/tVV5lYFlMg/Y?=
 =?us-ascii?Q?eUz5JJl7pvCLUsyOwv9YWZiJkilHqu6QwYfn+dlBNHVT4vLvLdKjBnJ4RHrL?=
 =?us-ascii?Q?pjyDA+2VgZChWcvsrla1fC6IO4trfsxOy8U7kfSbGDMQUXE3kvsfQvYgsq0v?=
 =?us-ascii?Q?MLBy7ULlvEX3EO8d4YsWU2CThXBH9jEJkjGqRcluy3ixY4rxJ4ODnZPkXoEP?=
 =?us-ascii?Q?rw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: t0bMgx0boDSGkbpBJvkcBX619VGwc3qzNuiqZuwKODc8/62890f1Lu7nTDXWx3Bzxs9P3Z+gFFrexV0uPK4s4VvUHKxDH+gVAmyWIyvdgwZvjt5YftJTCx+K94OwTGUVyWipiY+xrTumy7XO48IHJBUYF57fJpnAx5EqvYXRyWugTb/MyRNhJltzhZ6JxFIFYnzDATE/u/3IRSBGBGXK883HDteTIqHb2j9WGvMuVB/HPoTNkygjO1F44hbAbh+6ck+GnT8heuexnuywOD60rq+fcO6nZ2ypg01202NiO2WfbqNKlWzk1LbXje68IJ/U/CvGgPp1GTskNXSU/vivhOSKl+R+htlMhFz2Cp+xt9kYkt5CSY7D8RUUeglPaSh3NeKsLyDk3B9mk0n8EzVIp/Axe8NQEhntPoFJWx1rvGcBgB9oimaH0yOJKBziWBonEKwCBRjL6Qox6CLFDpoG6i2ML66T63z46FtyXSg+5hvPKKOQX6y8I2CgTXzbzstnsSKSatxBviuNfBBPzDRru8x65aTz4trjdo98gsy16F1t6CJMvWI+LsJtV0spKVm0SUi5DyQTJgyt9B5L06IowtMfKILqQovLQ3BEdGmknckyM7Xo+KhVVpMtHWClxEWDxcx4dn2hGp1Hiqw+SiIPhCiHOM3+0LYAdAz5c85s9aGFo8jztwGWmtvcDF6IFhMACdxh0fxnE45+FqxyaBv/U50nQpmS3Wo1Lm2nn3tIbmof/4jHy/tyKCnEvw8ALOVLb08pdiivYIscOWYiMyk9Imh4uZg8VWGIr/rQRMB2Xmf9Zep6e47L3YcTvPWp04T0MuqOPbmMhI4J/LhCs7/1v64hZulwM1WRAegnTCY7qOXMMkAa8YkI9oSrWDnw7e9+V8DzDyS4tGBefbKJSX/97Q==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f242885-3ad3-4055-1de1-08dbf74f3f8c
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4309.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 18:06:34.4807
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qQBaFvEIxVPf0qY2WhliulwHn3vvWlIXARc3KONlaS7yFZ1gVXc4IGt9JQTU6yihCmu6mOIR7Fnu5yk+oNmc+DGZTPJlprk/zl+fmWbK0t8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5072
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-07_15,2023-12-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 phishscore=0
 bulkscore=0 adultscore=0 mlxscore=0 mlxlogscore=758 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312070151
X-Proofpoint-GUID: VvI8v6ZNnF1HpQHMCfHWValm47J_9aKx
X-Proofpoint-ORIG-GUID: VvI8v6ZNnF1HpQHMCfHWValm47J_9aKx
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 10:07:06 -0800 (PST)

On Thu, Dec 07, 2023 at 09:23:29AM -0800, Jakub Kicinski wrote:
> On Thu, 7 Dec 2023 10:41:25 -0600 Aron Silverton wrote:
> > > I understand that having everything packaged and shipped together makes
> > > life easier.  
> > 
> > I think it is a requirement. We operate with Secure Boot. The kernel is
> > locked down. We don't have debugfs access, even if it were sufficient,
> > and we cannot compile and load modules. Even without Secure Boot, there
> > may not be a build environment available.
> 
> This 'no debugfs' requirement is a kernel lockdown thing, I presume?
> Are we expected to throw debugfs out the window and for all vendors
> to reimplement their debug functionality via a misc driver taking
> arbitrary ioctls? Not only does that sound like a complete waste of
> time and going backward in terms of quality of the interfaces, needing
> custom vendor tools etc. etc., but also you go from (hopefully somewhat)
> upstream reviewed debugfs interface to an interface where the only
> security assurance is vendor telling you "trust me, it's all good".

IIRC, with lockdown, we can read from debugfs IFF the entries'
permissions are 0400. We cannot write. It's not suitable for
implementing an interactive debug interface.