Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Thu, 7 Dec 2023 18:20:49 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Gergo Koteles <soyer@irl.hu>
Cc:     Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
        Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 03/16] ASoC: tas2781: disable regmap regcache
Message-ID: <0b836c10-b21b-4275-8dd0-254dd5467497@sirena.org.uk>
References: <cover.1701906455.git.soyer@irl.hu>
 <21a183b5a08cb23b193af78d4b1114cc59419272.1701906455.git.soyer@irl.hu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="87ASVyUZXk4suEIf"
Content-Disposition: inline
In-Reply-To: <21a183b5a08cb23b193af78d4b1114cc59419272.1701906455.git.soyer@irl.hu>
Precedence: bulk


--87ASVyUZXk4suEIf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 07, 2023 at 12:59:44AM +0100, Gergo Koteles wrote:

> The amp has 3 level addressing (BOOK, PAGE, REG).
> The regcache couldn't handle it.

So the books aren't currently used so the driver actually works?

>  static int tas2781_system_suspend(struct device *dev)
> @@ -770,10 +758,7 @@ static int tas2781_system_suspend(struct device *dev)
>  		return ret;
> =20
>  	/* Shutdown chip before system suspend */
> -	regcache_cache_only(tas_priv->regmap, false);
>  	tasdevice_tuning_switch(tas_priv, 1);
> -	regcache_cache_only(tas_priv->regmap, true);
> -	regcache_mark_dirty(tas_priv->regmap);
> =20
>  	/*
>  	 * Reset GPIO may be shared, so cannot reset here.

How can this work over system suspend?  This just removes the cache with
no replacement so if the device looses power over suspend (which seems
likely) then all the register state will be lost.  A similar issue may
potentially exist over runtime suspend on an ACPI system with
sufficiently heavily optimised power management.

--87ASVyUZXk4suEIf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVyDQAACgkQJNaLcl1U
h9A5HAf+Nlxq4xn9n9KdkGpBh57gkb+jV1RuCOHHhqKL7UAdfrt91gUdNVLq1Gvi
ReW5ZeaUE9EjXZo9FGiFaEc6WEP0TzDJi1a7bOyjtR09RU3ec03i8qd32LO7seEd
n/zyRK+X7umxfYsZGTJiXpzLyN9VC96bh6jNkHJmeToQ5LXZsicJ1bolctD6gfXK
8c7YEYL6Jrfx4Q3yfloOfHPHMzFrIrA+08fny0Dx+kaMfsWYGk2VcmaSYUbaP9y4
OhDEOF1sy3RiXsHJxDNIZubb71fuOqSszQQbS2At9b98GwTVTs8xnM61Xx/Yv1gq
8oQk2dsruB2j4P0IeFFcVp3UOQGKiA==
=F7Ae
-----END PGP SIGNATURE-----

--87ASVyUZXk4suEIf--