Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <bf59d8f2-7977-4dc6-afca-9c80e06ee549@intel.com>
Date:   Thu, 7 Dec 2023 10:35:25 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 08/26] selftests/resctrl: Split measure_cache_vals()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
 <20231120111340.7805-9-ilpo.jarvinen@linux.intel.com>
 <c303ba1b-d7bd-47cf-9e81-8ea0c60b973c@intel.com>
 <e87d8ba-141a-5779-fc6-27e4735fc1bf@linux.intel.com>
 <8f6c7b40-5218-4427-865d-55e5f09c594f@intel.com>
 <f6f42f73-ef84-535-78d7-c93685625aca@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <f6f42f73-ef84-535-78d7-c93685625aca@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3d4eTFYZFYzRkdGRFZMY3lIa2s2Z2sxeGxMTHBIYmtkYU55NTdkZTd3cHQv?=
 =?utf-8?B?K2gxRjRjak5zekhPdFF1VjNxWmxnYU9yc3VnN1VoK0k4TE1OKytIcXVVbVdM?=
 =?utf-8?B?TlZzczBmU2ZmWnJHN2pFSGRlVVd4UjZUK3BkUDZVNmZhOTBHSDZhUzJNVlJC?=
 =?utf-8?B?VEZJMVByL2RpRm5GVGZySE00VHdXK0ZaYkx0MGY0RGZyeHZ0TVJybGZPNjlW?=
 =?utf-8?B?Y096VjdEZjdDMVYyV0ZiTHRSYzRYZTZoMTdIc3VlcFhZa1ZNNVRSajNRTm5i?=
 =?utf-8?B?SGN2RndBVGI1SG1DcU9WanhGUEl1anp3RDZTMjBzeis3SXU3cHZKNWxGa3pm?=
 =?utf-8?B?cUJlTU1wOXdYU3VaU0FhT1lta0hEYmpVZ3JOZENobmdkamJWWUsxWVN2bnpy?=
 =?utf-8?B?YTlUL3R2Q3lSQ3ZmM3NQeWxudE1QZzJqb1hUWU5FSU1IeW5hV0x5VEROd3k0?=
 =?utf-8?B?Nzd0Mng2T05UOGdHZjNmbU0rOHNDZzRLL3hBb3hTTnRFekV2d0pINHJLUjB1?=
 =?utf-8?B?cVVJSlorbVRXdTUxTUZzV1M4NUUrdHJQTElSZS90eHQzQlp5L1A1cTJoTU1a?=
 =?utf-8?B?TWhUWTY1T2pyUjg4K2phMENza0h1MUdXM0p2encyWDI5MVZWaTkzOUJQNjBw?=
 =?utf-8?B?Zlg3d0w2NHJsM2JNNEo0S0oySW92cjIreXRzMHhjeE5tWmwzQ0FuTmNKcTVm?=
 =?utf-8?B?S1JYc0JUMkpaOC9UQ1FGUC9zTTNja0tlNk9UcXVRUHlFL2RmM0oxVWdaM2JG?=
 =?utf-8?B?SVRyOCtOb2p3VkVJekpXZXIyTjMyVjFNd1g3K1lIaVZZSmEvZzBjWlQ5QVJx?=
 =?utf-8?B?aW5HOWFqb0d0cnkwT0dpNTd2RkFJY0JrSzlDOGk2WW10REQrWXZ3MkZaSW1W?=
 =?utf-8?B?ZVpIQ3dYTU1sTEpjcUd6K09LRHFZV1F0Snluckw3ZnZ1Ylg1WDBoVW5BR3Z1?=
 =?utf-8?B?eDJtbno3TzczVmVaTGNyYm9Id0FRTFZyb0FRTzlERXRmdHRHb21RMDd4cmUx?=
 =?utf-8?B?eTRNdXNMZGN5bmZudzNuVFpTZnltbWVBUllBR0hXSjU1SXFDdlRIMnRwTHBy?=
 =?utf-8?B?MTZYeUppclhDNTJRSEtwa3Z6N1NibW01Nmx4WnlWQWRTWkJCNEt3cFRVdlg4?=
 =?utf-8?B?M3o1cDZsOS9qYzZRQ0E1YllkYXZBckwrUUh2SU8xbkNqTXdDMzFVeFA4T2lY?=
 =?utf-8?B?NG9zNmFPZWt4dkRjUzlVYm9EVHUzNlpJbUhtNUU1ZFF3VTdQeEd1ajdTWDRG?=
 =?utf-8?B?RjRDZ1d4Wk1zbDgwVXhXaUFKeHk1VGtwN2xvWHE0ZkRhL1VMWjVXNmFILytw?=
 =?utf-8?B?RzBYMnpNcFB6R2ZtSDRaTTVURUkzb24rVWdyM2hmeC9ESEJ1NWY4eHBUWWIx?=
 =?utf-8?B?V2lqTlN2Qm14Y0p3bVJVS2d3VGVoVDcrTGl1R0FnVTM3aW53eS9BbGlrNDJu?=
 =?utf-8?B?eHowT3orNzFFYzd4RFVmeExtK2V6NlpJcVFMdmFTSHFsL1dmZ0lBTWdHeHQv?=
 =?utf-8?B?K3BJcnRsbitKaUdMeUlHdzhyT1ZkTzRaQUZpRWthWEZLS3FIeFVtdWRKSzVx?=
 =?utf-8?B?Qi80QzJQc3R4S1cwc3hhQUljUExMOTFXbTFPeVc4ZStyajF5aVVGanIvZGE2?=
 =?utf-8?B?MllZSFp0dy9yUmRDQVpOL0s5cGVVSTZ2YWhMcW43dzU3dWZIRUV6TEVBVDJG?=
 =?utf-8?B?SC9vaGRObm5YSjdUSWJlNGVTVklFZkRNMnBkak1TeXhQZUc2NzVGSjBCMFZ2?=
 =?utf-8?B?OEZFczU1anU5OUpZbDdKKzJkOXlSYVZoa2Vrb1pLT01KZ01SSG02NjVMVmx4?=
 =?utf-8?B?VlJFY0NlZWxwbE1ybUtpb0pqSFJQWWhjbXRRM3NCNGVsREFvdjVQeGcyVEZU?=
 =?utf-8?B?bU0yWmdQcUQyRnlTM3VJNlFWM0tiK09VSWlaZDBaUDdyYjBKeXROV0NLTnZl?=
 =?utf-8?B?dzd4Z2loM3VEQ0JsU29JNldzT244a0dFNHdrUmM1SXFmSm9KQWQ3MjdMZVll?=
 =?utf-8?B?cTJYUDZKSGpORmdhQ1MrWnBUTFBwZUlpVU96WlBOYmdXY0JWaTVOMFJabHNP?=
 =?utf-8?B?eGp1U1g4cVluZWNhaGNtWkNlNlh3Zy9USEpERmtlRWZlOTdrcHJ5N2xmOHc3?=
 =?utf-8?B?MUxlWTFJUkVNbGczK0pJdS9VcDJLM0s1STlVdXpSZHIyZElVNzQwTzhHbDBu?=
 =?utf-8?B?QXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b7ee73a9-424a-4172-84c5-08dbf753488a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 18:35:27.6033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7DBvWt39ezSyNKkrorUMXPbj/l8Bn0k7XrFeRHo51A4FHz2CKR5oF5P3IpRHrpzebBNdG7WMeSQylXN6QtGSt3XtS+pegxOZlUjhivh+ZOo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5373
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 07 Dec 2023 10:35:39 -0800 (PST)


On 12/7/2023 10:33 AM, Ilpo Järvinen wrote:
> 
> I already spent some moments in converting all return error -> return -1, 
> since all such places do perror() calls anyway (which I also converted to 
> ksft_perror() or ksft_print_msg() where perror() didn't make any sense) 
> there's not much added value in returning the errno which was not 
> correctly done in the existing code anyway.

Thank you very much Ilpo.

Reinette