Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <ae9e4984a50842e056363cbae73ea01a745aebb6.camel@linux.intel.com>
Subject: Re: [PATCH v12 13/14] crypto: iaa - Add IAA Compression Accelerator
 stats
From:   Tom Zanussi <tom.zanussi@linux.intel.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        fenghua.yu@intel.com, vkoul@kernel.org
Cc:     dave.jiang@intel.com, tony.luck@intel.com,
        wajdi.k.feghali@intel.com, james.guilford@intel.com,
        kanchana.p.sridhar@intel.com, vinodh.gopal@intel.com,
        giovanni.cabiddu@intel.com, pavel@ucw.cz,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        dmaengine@vger.kernel.org
Date:   Thu, 07 Dec 2023 13:59:39 -0600
In-Reply-To: <4f53df8e-0957-44b6-b18e-e4362800e180@wanadoo.fr>
References: <20231205212530.285671-1-tom.zanussi@linux.intel.com>
         <20231205212530.285671-14-tom.zanussi@linux.intel.com>
         <4f53df8e-0957-44b6-b18e-e4362800e180@wanadoo.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Precedence: bulk

Hi Christophe,

On Thu, 2023-12-07 at 07:22 +0100, Christophe JAILLET wrote:
> Le 05/12/2023 =C3=A0 22:25, Tom Zanussi a =C3=A9crit=C2=A0:
> > Add support for optional debugfs statistics support for the IAA
> > Compression Accelerator.=C2=A0 This is enabled by the kernel config
> > item:
> >=20
> > =C2=A0=C2=A0 CRYPTO_DEV_IAA_CRYPTO_STATS
> >=20
> > When enabled, the IAA crypto driver will generate statistics which
> > can
> > be accessed at /sys/kernel/debug/iaa-crypto/.
> >=20
> > See Documentation/driver-api/crypto/iax/iax-crypto.rst for details.
> >=20
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > ---
>=20
> > +void update_max_adecomp_delay_ns(u64 start_time_ns)
> > +{
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u64 time_diff;
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0time_diff =3D ktime_get_ns()=
 - start_time_ns;
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (time_diff > max_adecomp_=
delay_ns)
> > +
>=20
> Nit: unneeded NL.
>=20

Good eye, thanks for pointing it out.

Tom

> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0max_adecomp_delay_ns =3D time_diff;
> > +}
>=20
> CJ